)]}'
{"id":"openvpn~1218","triplet_id":"openvpn~master~Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-04 15:36:42.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-04 15:36:42.000000000","reason":"Change was submitted"},"1000030":{"account":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2025-10-04 00:55:37.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3","subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()","status":"MERGED","created":"2025-09-24 16:36:25.000000000","updated":"2025-10-04 15:36:42.000000000","submitted":"2025-10-04 15:36:42.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1218-wconversion","meta_rev_id":"f8982b21a375881d64578a7a006ffcac1751fdcd","_number":1218,"virtual_id_number":1218,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-24 16:36:27.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-24 16:36:27.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-26 16:09:29.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"state":"REVIEWER"}],"messages":[{"id":"fd5ce9badcbfd10c4f00a4f677fb4ff1d5e0c770","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 16:36:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9907a8c104cdf4e9b1ab86b4153b520c054730c4","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-09-26 16:09:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"09181c56244877b3e6e8b40046db76bb8699e0e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 11:03:19.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0ca1ca78c95941b158ef8f59ae603cd398cbf145","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 15:23:41.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"7988f380fb08cb2066bab2f3a42e59c77769f487","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 15:24:08.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1200d063f208ac02e32d7f42f69a651f1e443e43","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-10-04 00:55:37.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f8982b21a375881d64578a7a006ffcac1751fdcd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-04 15:36:42.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"cb8155711a18e2c6b4e437ab224a9eb5961dfeda","revisions":{"5a529bc779e3227debab463f06f3c7d2ee5f3786":{"kind":"REWORK","_number":1,"created":"2025-09-24 16:36:25.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/18/1218/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1218/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/1 \u0026\u0026 git checkout -b change-1218 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1218/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ead9944e6d500c83ef4e5629f9122ffdec0a49a2","subject":"crypto: Make some casts to int explicit"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:34:18.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:34:18.000000000","tz":120},"subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()","message":"crypto_epoch: Clean up type handling in ovpn_expand_label()\n\n- Add explicit casts where we have checked the value and\n  need to put it into a smaller type.\n- Adapt some types to actual usage.\n\nChange-Id: Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4b145ea8e447032461229b9fa46061c903026e3b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-09-30 11:03:19.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/18/1218/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1218/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/2 \u0026\u0026 git checkout -b change-1218 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1218/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b35fa43725d1ca82c260c8939c77d622c55d8f93","subject":"crypto: Make some casts to int explicit"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:34:18.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 10:55:54.000000000","tz":120},"subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()","message":"crypto_epoch: Clean up type handling in ovpn_expand_label()\n\n- Add explicit casts where we have checked the value and\n  need to put it into a smaller type.\n- Adapt some types to actual usage.\n\nChange-Id: Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"225443564a58f7d57de163e295c7d8c6d0b6f3bd":{"kind":"REWORK","_number":3,"created":"2025-09-30 15:23:41.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/18/1218/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1218/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/3 \u0026\u0026 git checkout -b change-1218 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1218/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b35fa43725d1ca82c260c8939c77d622c55d8f93","subject":"crypto: Make some casts to int explicit"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:34:18.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 15:22:28.000000000","tz":120},"subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()","message":"crypto_epoch: Clean up type handling in ovpn_expand_label()\n\n- Add explicit casts where we have checked the value and\n  need to put it into a smaller type.\n- Adapt some types to actual usage.\n\nChange-Id: Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"cb8155711a18e2c6b4e437ab224a9eb5961dfeda":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-10-04 15:36:42.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/18/1218/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/1218/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/4 \u0026\u0026 git checkout -b change-1218 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/1218/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/1218/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"290a14cd9edf95f07940f63993c290dc045c2a44","subject":"dco-win: fix broken ASSERT in dco_new_key"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-04 06:15:38.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-04 14:15:40.000000000","tz":120},"subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()","message":"crypto_epoch: Clean up type handling in ovpn_expand_label()\n\n- Add explicit casts where we have checked the value and\n  need to put it into a smaller type.\n- Adapt some types to actual usage.\n\nChange-Id: Iad717f0ff3c79ae199c8be5f93bc51bf258c68c3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1218\nMessage-Id: \u003c20251004061545.7277-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59242119/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}