)]}'
{"id":"openvpn~1222","triplet_id":"openvpn~master~I16d90221d0a75193035253817ff195f6da9dc0b3","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-19 13:41:31.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-19 11:40:26.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-19 13:41:31.000000000","reason":"Change was submitted"},"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-11-19 13:41:31.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I16d90221d0a75193035253817ff195f6da9dc0b3","subject":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately","status":"MERGED","created":"2025-09-26 13:47:07.000000000","updated":"2025-11-19 13:41:31.000000000","submitted":"2025-11-19 13:41:31.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1222","meta_rev_id":"e698918032b5e89482087ca3432d1d202b826b59","_number":1222,"virtual_id_number":1222,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-26 13:47:08.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-26 13:47:08.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-26 13:47:08.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-15 17:07:03.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"2c8603fdb264a2db33e8269d4efd044211e65cfa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-09-26 13:47:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8dea3f53d78ddc7b897e194f6631f58108bc032b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-29 17:30:17.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"173bcbbaaaee173fad6a9f1f45d028c74be659a1","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-15 17:07:03.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b5ce654f863aca75ed17729f95ae5b9886b01115","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-11-18 05:57:58.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"28b290f403861c2a9e0cb4f8ce89b8b3069b99c8","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-11-18 05:58:46.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d153d30f4bef77407568658dc3c5125320219328","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-18 18:42:28.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"ff7faaec167f5c580f4d8ef843d85905a5f41570","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-11-19 03:22:20.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"9ba14abcf10e4a6e0c10d1a6824220a70b6b3050","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-11-19 03:23:07.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"32a5d7104d929663ebf07baa4175c7a065821605","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-19 11:40:26.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"e698918032b5e89482087ca3432d1d202b826b59","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-19 13:41:31.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"2777cdd3783776a91514804233c5e2b715d11d64","revisions":{"23ea00eb9cacfa5308a5ab88152b7df00c603ccf":{"kind":"REWORK","_number":1,"created":"2025-09-26 13:47:07.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/22/1222/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/1222/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/1 \u0026\u0026 git checkout -b change-1222 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/1222/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0fb5a00549be6b065f9a4d61940ee06786d9fa61","subject":"OpenVPN Release 2.7_beta2"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-09-26 13:34:25.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-09-26 13:34:25.000000000","tz":120},"subject":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately","message":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately\n\nRight now there is the assumption that the gateway used for net_gateway is the same used to reach the VPN server.\nHowever, these two gateways may be different (i.e. when there is a specific hostroute for the VPN server using a different nexthop).\nFor this reason we must adapt init_route_list() to fetch the two gateways separately.\n\nChange-Id: I16d90221d0a75193035253817ff195f6da9dc0b3\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"cdaf9954b7df84223676f6cc229e78832e05584f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-29 17:30:17.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/22/1222/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/1222/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/2 \u0026\u0026 git checkout -b change-1222 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/1222/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f938d991a8222bb3304865f2cd7b368d7f8a9224","subject":"Install host routes for out-of-subnet ifconfig-push addresses when DCO is enabled"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-09-26 13:34:25.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-29 17:29:06.000000000","tz":60},"subject":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately","message":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately\n\nRight now there is the assumption that the gateway used for net_gateway is the same used to reach the VPN server.\nHowever, these two gateways may be different (i.e. when there is a specific hostroute for the VPN server using a different nexthop).\nFor this reason we must adapt init_route_list() to fetch the two gateways separately.\n\nChange-Id: I16d90221d0a75193035253817ff195f6da9dc0b3\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"0cdf7a88179900d2b58ca832712e1dd3ad412c3f":{"kind":"REWORK","_number":3,"created":"2025-11-18 05:57:58.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/22/1222/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/1222/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/3 \u0026\u0026 git checkout -b change-1222 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/1222/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d6ee27b4ff31e4469d699f3bfd7b9998ab167230","subject":"OpenVPN Release 2.7_rc2"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-09-26 13:34:25.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-11-18 05:55:28.000000000","tz":60},"subject":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately","message":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately\n\nRight now there is the assumption that the gateway used for net_gateway is the same used to reach the VPN server.\nHowever, these two gateways may be different (i.e. when there is a specific hostroute for the VPN server using a different nexthop).\nFor this reason we must adapt init_route_list() to fetch the two gateways separately.\n\nGithub: fixes OpenVPN/openvpn#890\n\nChange-Id: I16d90221d0a75193035253817ff195f6da9dc0b3\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"35bc52c8b86acf92aaade60cbe64da481e9f8b08":{"kind":"REWORK","_number":4,"created":"2025-11-19 03:22:20.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/22/1222/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/1222/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/4 \u0026\u0026 git checkout -b change-1222 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/1222/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d6ee27b4ff31e4469d699f3bfd7b9998ab167230","subject":"OpenVPN Release 2.7_rc2"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-09-26 13:34:25.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-11-19 03:21:11.000000000","tz":60},"subject":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately","message":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately\n\nRight now there is the assumption that the gateway used for net_gateway is the same used to reach the VPN server.\nHowever, these two gateways may be different (i.e. when there is a specific hostroute for the VPN server using a different nexthop).\nFor this reason we must adapt init_route_list() to fetch the two gateways separately.\n\nGithub: fixes OpenVPN/openvpn#890\n\nChange-Id: I16d90221d0a75193035253817ff195f6da9dc0b3\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"2777cdd3783776a91514804233c5e2b715d11d64":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-11-19 13:41:31.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/22/1222/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/22/1222/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/5 \u0026\u0026 git checkout -b change-1222 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/22/1222/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/22/1222/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d0d4b1cf6c77f107af323e0ec81b0273c211867","subject":"vcpkg-ports/pkcs11-helper: bump version to 1.31"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-11-19 11:40:35.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-19 13:32:56.000000000","tz":60},"subject":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately","message":"route: handle default gateway (net_gateway) and nexthop towards VPN server separately\n\nRight now there is the assumption that the gateway used for net_gateway is the same used to reach the VPN server.\nHowever, these two gateways may be different (i.e. when there is a specific hostroute for the VPN server using a different nexthop).\nFor this reason we must adapt init_route_list() to fetch the two gateways separately.\n\nGithub: fixes OpenVPN/openvpn#890\n\nChange-Id: I16d90221d0a75193035253817ff195f6da9dc0b3\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1222\nMessage-Id: \u003c20251119114041.17665-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34529.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
