)]}'
{"id":"openvpn~1223","triplet_id":"openvpn~master~I3b1243461ec9b6e85897f452f78dc4b05f7e126d","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-29 18:51:01.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-29 15:14:29.000000000","reason":"removed on reply"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-09-29 18:51:01.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I3b1243461ec9b6e85897f452f78dc4b05f7e126d","subject":"dco-win: fix broken ASSERT in dco_new_key","status":"MERGED","created":"2025-09-29 08:47:30.000000000","updated":"2025-09-29 18:51:01.000000000","submitted":"2025-09-29 18:51:01.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1223","meta_rev_id":"86e2129c348bfa79dffd854716e1a0101fbbd0fe","_number":1223,"virtual_id_number":1223,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-29 08:47:31.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-29 08:47:31.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-29 08:47:31.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"134048830af5ee45ce6ce47f1f43f5b18d2b3b96","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-29 08:47:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ebdaf2fa6f617372371ca84431c1eba97d1e7c8b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-29 15:14:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ca3220b60b46c25a40447ebb3649a4f45dc6d58b","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-29 15:29:07.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"86e2129c348bfa79dffd854716e1a0101fbbd0fe","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-29 18:51:01.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"290a14cd9edf95f07940f63993c290dc045c2a44","revisions":{"05511dc36540593471d28a2e72e7bb9e437b0b12":{"kind":"REWORK","_number":1,"created":"2025-09-29 08:47:30.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/23/1223/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1223/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/1 \u0026\u0026 git checkout -b change-1223 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1223/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36a09c8dbfb68c9df745943886dc974513998c07","subject":"dco: Change sd argument to dco_new_peer from int to socket_descriptor_t"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-29 08:45:08.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-29 08:45:08.000000000","tz":180},"subject":"dco-win: fix broken ASSERT in dco_new_key","message":"dco-win: fix broken ASSERT in dco_new_key\n\nCommit\n\n  e77c343 (\"dco_win: In dco_new_key, document size assumptions for the integer casts\")\n\nhas added an ASSERT on key-id, but didn\u0027t take into account that\nkey-id 0 is a perfectly valid value and is the first key-id. This\nessentially broke dco-win.\n\nFix by adjusting ASSERT to \u003e\u003d 0.\n\nChange-Id: I3b1243461ec9b6e85897f452f78dc4b05f7e126d\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"290a14cd9edf95f07940f63993c290dc045c2a44":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-09-29 18:51:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/23/1223/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/23/1223/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/2 \u0026\u0026 git checkout -b change-1223 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/23/1223/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/23/1223/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"36a09c8dbfb68c9df745943886dc974513998c07","subject":"dco: Change sd argument to dco_new_peer from int to socket_descriptor_t"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-29 15:28:41.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-29 18:48:32.000000000","tz":120},"subject":"dco-win: fix broken ASSERT in dco_new_key","message":"dco-win: fix broken ASSERT in dco_new_key\n\nCommit\n\n  e77c343 (\"dco_win: In dco_new_key, document size assumptions for the integer casts\")\n\nhas added an ASSERT on key-id, but didn\u0027t take into account that\nkey-id 0 is a perfectly valid value and is the first key-id. This\nessentially broke dco-win.\n\nFix by adjusting ASSERT to \u003e\u003d 0.\n\nChange-Id: I3b1243461ec9b6e85897f452f78dc4b05f7e126d\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1223\nMessage-Id: \u003c20250929152841.177424-1-frank@lichtenheld.com\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59240115/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}