)]}'
{"id":"openvpn~1241","triplet_id":"openvpn~master~Ie0c0fbf4f7f8b379d46b6755c4eff209acc20fef","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-07 07:37:07.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-07 07:37:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie0c0fbf4f7f8b379d46b6755c4eff209acc20fef","subject":"dhcp: Fix conversion warnings","status":"MERGED","created":"2025-09-30 11:03:19.000000000","updated":"2025-10-07 07:37:07.000000000","submitted":"2025-10-07 07:37:07.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1241-wconversion","meta_rev_id":"db7571203d2850529daa51260447210e1ee7ff34","_number":1241,"virtual_id_number":1241,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-30 11:03:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-30 11:03:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-06 21:01:13.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"50764f7558e70a52556da715fd2bf2706c46950c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 11:03:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"303951ae4e78dcbc3c4374780d7b4d39f105ccf1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 15:23:41.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"933aae40693b0490bb07f0cb1b8fbe96d92090a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-06 16:06:59.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"f0028a921c858b5941791ab10ad271b50f439b73","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-06 21:01:13.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"db7571203d2850529daa51260447210e1ee7ff34","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-07 07:37:07.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"d446715c537764076ea8d61233bf37d3bafa7624","revisions":{"ede2306d01954cda118e8629f96689ece3ef076e":{"kind":"REWORK","_number":1,"created":"2025-09-30 11:03:19.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/41/1241/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1241/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/1 \u0026\u0026 git checkout -b change-1241 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1241/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4b145ea8e447032461229b9fa46061c903026e3b","subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 11:01:02.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 11:01:02.000000000","tz":120},"subject":"dhcp: Fix conversion warnings","message":"dhcp: Fix conversion warnings\n\n- Use correct type for pointer difference\n- Make sure that small sizeof sum is treated as int\n\nChange-Id: Ie0c0fbf4f7f8b379d46b6755c4eff209acc20fef\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"09c380c3b0ce5845eeb2c6ce1178eb8f878e9740":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-09-30 15:23:41.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/41/1241/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1241/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/2 \u0026\u0026 git checkout -b change-1241 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1241/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"225443564a58f7d57de163e295c7d8c6d0b6f3bd","subject":"crypto_epoch: Clean up type handling in ovpn_expand_label()"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 11:01:02.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 15:22:28.000000000","tz":120},"subject":"dhcp: Fix conversion warnings","message":"dhcp: Fix conversion warnings\n\n- Use correct type for pointer difference\n- Make sure that small sizeof sum is treated as int\n\nChange-Id: Ie0c0fbf4f7f8b379d46b6755c4eff209acc20fef\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0a4b1ec03f2e230d569d85c5741a9fe2381c3db7":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-10-06 16:06:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/41/1241/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1241/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/3 \u0026\u0026 git checkout -b change-1241 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1241/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"087d745579bee559513f94741626649de01e54d0","subject":"crypto: Make some casts to int explicit"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 11:01:02.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-06 16:06:15.000000000","tz":120},"subject":"dhcp: Fix conversion warnings","message":"dhcp: Fix conversion warnings\n\n- Use correct type for pointer difference\n- Make sure that small sizeof sum is treated as int\n\nChange-Id: Ie0c0fbf4f7f8b379d46b6755c4eff209acc20fef\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d446715c537764076ea8d61233bf37d3bafa7624":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-10-07 07:37:07.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/41/1241/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1241/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/4 \u0026\u0026 git checkout -b change-1241 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1241/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1241/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0e3dd1ccba4612fc461f6bbf0a076eae1033e141","subject":"Review CMocka assertion usage"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-06 21:01:21.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-07 07:33:56.000000000","tz":120},"subject":"dhcp: Fix conversion warnings","message":"dhcp: Fix conversion warnings\n\n- Use correct type for pointer difference\n- Make sure that small sizeof sum is treated as int\n\nChange-Id: Ie0c0fbf4f7f8b379d46b6755c4eff209acc20fef\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1241\nMessage-Id: \u003c20251006210127.28679-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59243110/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}