)]}'
{"id":"openvpn~1243","triplet_id":"openvpn~master~I937105abeb5e8f796bf6bbe8432972adb60b3e2a","project":"openvpn","branch":"master","topic":"options_parse","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-07 20:17:40.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-07 20:17:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I937105abeb5e8f796bf6bbe8432972adb60b3e2a","subject":"unit_tests: Remove useless wrapping for argv/buffer tests","status":"MERGED","created":"2025-09-30 13:42:19.000000000","updated":"2025-10-07 20:17:40.000000000","submitted":"2025-10-07 20:17:40.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1243-options_parse","meta_rev_id":"45c700056c580c0b5e36bb1b22f8b3310632401c","_number":1243,"virtual_id_number":1243,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-30 13:42:20.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-30 13:42:20.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-07 18:52:02.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"e4383a97ccdd524ba37f2fb6e6803e89baa7f708","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 13:42:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"07c2e105406c5b32a9a3d5a6af442de64c3a7164","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-01 10:18:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0ab810617b1888d110de0eac637dae04e4fd7794","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-07 18:52:02.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"45c700056c580c0b5e36bb1b22f8b3310632401c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-07 20:17:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d2428900ef07b1eb9d52a5de8ba5802b37a99d65","revisions":{"0b2e844a0ee26c3a1ef6b7002b880e4181adc74e":{"kind":"REWORK","_number":1,"created":"2025-09-30 13:42:19.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/43/1243/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/1243/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/1 \u0026\u0026 git checkout -b change-1243 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/1243/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"833c9e2b0e85d2fab03384d60a8b2020c8e67769","subject":"options: Factor out parsing code to separate options_parse.c"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 13:13:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 13:41:08.000000000","tz":120},"subject":"unit_tests: Remove useless wrapping for argv/buffer tests","message":"unit_tests: Remove useless wrapping for argv/buffer tests\n\nIf not using mock() or check_expected(), and\nnot linking the original function, then there\nis no need for wrapping support.\n\nChange-Id: I937105abeb5e8f796bf6bbe8432972adb60b3e2a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2a235eb29830f426fdb93ad05269f4859582ecc8":{"kind":"REWORK","_number":2,"created":"2025-10-01 10:18:27.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/43/1243/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/1243/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/2 \u0026\u0026 git checkout -b change-1243 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/1243/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"833c9e2b0e85d2fab03384d60a8b2020c8e67769","subject":"options: Factor out parsing code to separate options_parse.c"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 13:13:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-01 10:16:31.000000000","tz":120},"subject":"unit_tests: Remove useless wrapping for argv/buffer tests","message":"unit_tests: Remove useless wrapping for argv/buffer tests\n\nIf not using mock() or check_expected(), and\nnot linking the original function, then there\nis no need for wrapping support.\n\nChange-Id: I937105abeb5e8f796bf6bbe8432972adb60b3e2a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d2428900ef07b1eb9d52a5de8ba5802b37a99d65":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-07 20:17:40.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/43/1243/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/43/1243/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/3 \u0026\u0026 git checkout -b change-1243 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/43/1243/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/43/1243/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ebf781b8a15932ff7b7911ce41bdcedf70d0eb06","subject":"options: Factor out parsing code to separate options_parse.c"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-07 18:52:09.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-07 20:16:11.000000000","tz":120},"subject":"unit_tests: Remove useless wrapping for argv/buffer tests","message":"unit_tests: Remove useless wrapping for argv/buffer tests\n\nIf not using mock() or check_expected(), and\nnot linking the original function, then there\nis no need for wrapping support.\n\nChange-Id: I937105abeb5e8f796bf6bbe8432972adb60b3e2a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1243\nMessage-Id: \u003c20251007185217.19381-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59243508/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}