)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"58fa35e733972c3872df09edfb28dbe68b9e8ab0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"271ccdae_045e2bb8","updated":"2025-10-05 20:45:22.000000000","message":"The commit message needs to contain a bit more background on why this change is made (people actually do read commit messages ;-) ).\n\nSomething like \"PUSH_UPDATE does not yet function correctly with DCO when the VPN IP address is updated (new ifconfig values pushed)\".\n\nI\u0027ll add that on the fly.","commit_id":"f4cb69972074ccce5ec077838d523e76e5a3d9df"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"6e8198a79694c1979af92e605e755b1151fdd797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"075d4b2b_ef11db25","in_reply_to":"271ccdae_045e2bb8","updated":"2025-10-06 08:10:31.000000000","message":"Done","commit_id":"f4cb69972074ccce5ec077838d523e76e5a3d9df"}],"src/openvpn/push.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"8cbeecfd7dd79f88d886bbab1e28c5d84d21fa0e","unresolved":true,"context_lines":[{"line_number":1114,"context_line":"    {"},{"line_number":1115,"context_line":"        if (dco_enabled(\u0026c-\u003eoptions))"},{"line_number":1116,"context_line":"        {"},{"line_number":1117,"context_line":"            msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be received while DCO is enabled, ignoring.\""},{"line_number":1118,"context_line":"                        \" To receive PUSH_UPDATE messages, be sure to use the --disable-dco option.\");"},{"line_number":1119,"context_line":"            return PUSH_MSG_ERROR;"},{"line_number":1120,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"cff164a5_fe297422","line":1117,"updated":"2025-10-08 07:42:53.000000000","message":"I\u0027d reword: \"be received while..\" -\u003e \"be processed in client mode while..\"","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"02e602b544540455a385265ec9cb9350c5fa0bc1","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"    {"},{"line_number":1115,"context_line":"        if (dco_enabled(\u0026c-\u003eoptions))"},{"line_number":1116,"context_line":"        {"},{"line_number":1117,"context_line":"            msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be received while DCO is enabled, ignoring.\""},{"line_number":1118,"context_line":"                        \" To receive PUSH_UPDATE messages, be sure to use the --disable-dco option.\");"},{"line_number":1119,"context_line":"            return PUSH_MSG_ERROR;"},{"line_number":1120,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"3127766f_33b50006","line":1117,"in_reply_to":"cff164a5_fe297422","updated":"2025-10-08 08:19:58.000000000","message":"Done","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"8cbeecfd7dd79f88d886bbab1e28c5d84d21fa0e","unresolved":true,"context_lines":[{"line_number":1115,"context_line":"        if (dco_enabled(\u0026c-\u003eoptions))"},{"line_number":1116,"context_line":"        {"},{"line_number":1117,"context_line":"            msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be received while DCO is enabled, ignoring.\""},{"line_number":1118,"context_line":"                        \" To receive PUSH_UPDATE messages, be sure to use the --disable-dco option.\");"},{"line_number":1119,"context_line":"            return PUSH_MSG_ERROR;"},{"line_number":1120,"context_line":"        }"},{"line_number":1121,"context_line":"        return process_incoming_push_update(c, permission_mask, option_types_found, \u0026buf, false);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"c79ce5b0_07a07e3b","line":1118,"updated":"2025-10-08 07:42:53.000000000","message":"I\u0027d reword: \"To receive..\" -\u003e \"To be able to process..\"","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"02e602b544540455a385265ec9cb9350c5fa0bc1","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"        if (dco_enabled(\u0026c-\u003eoptions))"},{"line_number":1116,"context_line":"        {"},{"line_number":1117,"context_line":"            msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be received while DCO is enabled, ignoring.\""},{"line_number":1118,"context_line":"                        \" To receive PUSH_UPDATE messages, be sure to use the --disable-dco option.\");"},{"line_number":1119,"context_line":"            return PUSH_MSG_ERROR;"},{"line_number":1120,"context_line":"        }"},{"line_number":1121,"context_line":"        return process_incoming_push_update(c, permission_mask, option_types_found, \u0026buf, false);"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"c5e2e7d0_4498f1b8","line":1118,"in_reply_to":"c79ce5b0_07a07e3b","updated":"2025-10-08 08:19:58.000000000","message":"Done","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"}],"src/openvpn/push_util.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2b48590de5bc7668f6a0006572d5e22aae110e25","unresolved":true,"context_lines":[{"line_number":301,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":302,"context_line":"    {"},{"line_number":303,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":304,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the `--disable-dco` option.\");"},{"line_number":305,"context_line":"        return false;"},{"line_number":306,"context_line":"    }"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"901153d2_c4cc2b99","line":304,"updated":"2025-10-01 15:10:50.000000000","message":"```suggestion\n                    \" To send a PUSH_UPDATE message, be sure to use the --disable-dco option.\");\n```\n\nRemove the quotes, we do not use them in other error messages.","commit_id":"b760563c1ffb57ec36b34d872a8874edadaeb65c"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"6aee32455e0706ff751aa9a34f6957647a57774d","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":302,"context_line":"    {"},{"line_number":303,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":304,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the `--disable-dco` option.\");"},{"line_number":305,"context_line":"        return false;"},{"line_number":306,"context_line":"    }"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"023aa3c3_1be34cad","line":304,"in_reply_to":"901153d2_c4cc2b99","updated":"2025-10-01 22:09:42.000000000","message":"Done","commit_id":"b760563c1ffb57ec36b34d872a8874edadaeb65c"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2b48590de5bc7668f6a0006572d5e22aae110e25","unresolved":true,"context_lines":[{"line_number":317,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":318,"context_line":"    {"},{"line_number":319,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":320,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the `--disable-dco` option.\");"},{"line_number":321,"context_line":"        return false;"},{"line_number":322,"context_line":"    }"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ff703365_a978f0ce","line":320,"updated":"2025-10-01 15:10:50.000000000","message":"```suggestion\n                    \" To send a PUSH_UPDATE message, be sure to use the --disable-dco option.\");\n```\n\nRemove the quotes, we do not use them in other error messages.","commit_id":"b760563c1ffb57ec36b34d872a8874edadaeb65c"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"6aee32455e0706ff751aa9a34f6957647a57774d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":318,"context_line":"    {"},{"line_number":319,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":320,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the `--disable-dco` option.\");"},{"line_number":321,"context_line":"        return false;"},{"line_number":322,"context_line":"    }"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9c773132_33d644e2","line":320,"in_reply_to":"ff703365_a978f0ce","updated":"2025-10-01 22:09:42.000000000","message":"Done","commit_id":"b760563c1ffb57ec36b34d872a8874edadaeb65c"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"8cbeecfd7dd79f88d886bbab1e28c5d84d21fa0e","unresolved":true,"context_lines":[{"line_number":298,"context_line":"management_callback_send_push_update_broadcast(void *arg, const char *options)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"    struct multi_context *m \u003d arg;"},{"line_number":301,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":302,"context_line":"    {"},{"line_number":303,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":304,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the --disable-dco option.\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e9277b6d_e934a501","line":301,"updated":"2025-10-08 07:42:53.000000000","message":"Why not doing this check only once at the beginning of `send_push_update()` ?","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"02e602b544540455a385265ec9cb9350c5fa0bc1","unresolved":false,"context_lines":[{"line_number":298,"context_line":"management_callback_send_push_update_broadcast(void *arg, const char *options)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"    struct multi_context *m \u003d arg;"},{"line_number":301,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":302,"context_line":"    {"},{"line_number":303,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":304,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the --disable-dco option.\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"13c28d61_88982957","line":301,"in_reply_to":"e9277b6d_e934a501","updated":"2025-10-08 08:19:58.000000000","message":"Done","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"},{"author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"02e602b544540455a385265ec9cb9350c5fa0bc1","unresolved":false,"context_lines":[{"line_number":298,"context_line":"management_callback_send_push_update_broadcast(void *arg, const char *options)"},{"line_number":299,"context_line":"{"},{"line_number":300,"context_line":"    struct multi_context *m \u003d arg;"},{"line_number":301,"context_line":"    if (dco_enabled(\u0026m-\u003etop.options))"},{"line_number":302,"context_line":"    {"},{"line_number":303,"context_line":"        msg(M_WARN, \"WARN: PUSH_UPDATE messages cannot currently be sent while DCO is enabled.\""},{"line_number":304,"context_line":"                    \" To send a PUSH_UPDATE message, be sure to use the --disable-dco option.\");"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b41cfce5_b268256b","line":301,"in_reply_to":"e9277b6d_e934a501","updated":"2025-10-08 08:19:58.000000000","message":"Done","commit_id":"326bab9212ec5ad937592bfebabf116e63019d67"}]}