)]}'
{"id":"openvpn~1246","triplet_id":"openvpn~master~I3724660bf0f8336ee58c172acfb7c4f38e457393","project":"openvpn","branch":"master","topic":"options_parse","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-08 10:33:32.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-08 10:44:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3724660bf0f8336ee58c172acfb7c4f38e457393","subject":"buffer: Fix buf_parse eating input","status":"MERGED","created":"2025-10-01 15:00:32.000000000","updated":"2025-10-08 10:44:04.000000000","submitted":"2025-10-08 10:44:04.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1246-options_parse","meta_rev_id":"fca1534d4da6db887bbc2a24fbe86630a82de687","_number":1246,"virtual_id_number":1246,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-01 15:00:33.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-01 15:00:33.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-08 10:29:48.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"f2059d7402328600e6fec1e61d25d63f69b5a948","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-01 15:00:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e85dad7b5e80c0898998fcf210e8c459693d0166","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-08 10:29:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ac3a1215a9adf0f13a9ed1d146687cf46b395c8e","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-08 10:33:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fca1534d4da6db887bbc2a24fbe86630a82de687","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-08 10:44:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f5a2e2319bc7c3cce7f5cdccae44b9bae3e33375","revisions":{"21c230cccf6ac2e29199eeda7fbf85ffa0b617dd":{"kind":"REWORK","_number":1,"created":"2025-10-01 15:00:32.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/46/1246/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1246/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/1 \u0026\u0026 git checkout -b change-1246 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/46/1246/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03d37975e2983dd5cf60e9d6852603b4e1f6e0a1","subject":"test_options_parse: Start new UT for options_parse.c"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-01 14:36:56.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-01 14:56:57.000000000","tz":120},"subject":"buffer: Fix buf_parse eating input","message":"buffer: Fix buf_parse eating input\n\nWhen parsing a \"line\" that is longer than the\navailable line buffer, then buf_parse was\neating up to 2 characters. It advanced past\nthem but they were not part of the output.\n\nThis can lead to unexpected results if buf_parse\nis used in a while loop on unrestricted input,\nlike e.g. when reading configs (see in_src_get()\nused for check_inline_file_via_buf()).\n\nChange-Id: I3724660bf0f8336ee58c172acfb7c4f38e457393\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f5a2e2319bc7c3cce7f5cdccae44b9bae3e33375":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-10-08 10:44:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/46/1246/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/46/1246/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/2 \u0026\u0026 git checkout -b change-1246 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/46/1246/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/46/1246/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"80981cf33880d9bf995da0dbd09becedce421d5e","subject":"test_options_parse: Start new UT for options_parse.c"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-08 10:29:55.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-08 10:36:18.000000000","tz":120},"subject":"buffer: Fix buf_parse eating input","message":"buffer: Fix buf_parse eating input\n\nWhen parsing a \"line\" that is longer than the\navailable line buffer, then buf_parse was\neating up to 2 characters. It advanced past\nthem but they were not part of the output.\n\nThis can lead to unexpected results if buf_parse\nis used in a while loop on unrestricted input,\nlike e.g. when reading configs (see in_src_get()\nused for check_inline_file_via_buf()).\n\nChange-Id: I3724660bf0f8336ee58c172acfb7c4f38e457393\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1246\nMessage-Id: \u003c20251008103001.7696-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59243829/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}