)]}'
{"id":"openvpn~1248","triplet_id":"openvpn~master~I9b099924286f9bccb6833e1e40606abe72714bbb","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-09 17:33:46.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-10-09 17:33:46.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-09 17:33:46.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-10-09 17:33:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9b099924286f9bccb6833e1e40606abe72714bbb","subject":"Preserve ifconfig(_ipv6)_local across reconnect","status":"MERGED","created":"2025-10-06 11:47:10.000000000","updated":"2025-10-09 17:33:46.000000000","submitted":"2025-10-09 17:33:46.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1248","meta_rev_id":"f489697b1d47464e25ceb99d654d97c47522e6c1","_number":1248,"virtual_id_number":1248,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-06 11:47:10.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-06 11:47:10.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-06 11:47:10.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-09 17:18:12.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"863fece30fa315eb563991b33a888c8ddfb72a41","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-10-06 11:47:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6d425c48e9cfd9d94d6c6b76ffb9d252b60807b0","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-09 17:18:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ade6bf3de4ce60c69826c0406a876c70ebf3d389","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-09 17:19:01.000000000","message":"Patch Set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f489697b1d47464e25ceb99d654d97c47522e6c1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-09 17:33:46.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8a8360fc176b3996bfefee0ea894dc5c8a9ead1a","revisions":{"9e5376ff30221cd6fc772d6e763f26c981ed6c3c":{"kind":"REWORK","_number":1,"created":"2025-10-06 11:47:10.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/48/1248/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1248/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/1 \u0026\u0026 git checkout -b change-1248 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1248/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eadae51341dbf80c83e827bb4011e80dfcbc6927","subject":"platform: Do not assume uid_t/gid_t are signed"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-10-06 11:25:11.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-10-06 11:43:43.000000000","tz":180},"subject":"Preserve ifconfig(_ipv6)_local across reconnect","message":"Preserve ifconfig(_ipv6)_local across reconnect\n\nTurns out that ifconfig_(ipv6)_local options are set once\nand are not reset on a reconnect.\n\nConsider following scenario:\n\n - connect first time, server pushes ifconfig-ipv6\n - add a ipv6 network route because ifconfig_ipv6_local is set\n - reconnect, server doesn\u0027t push ifconfig-ipv6\n\nBecause of ifconfig_ipv6_local is not reset and holds the value\nset by the first connect, client adds a ipv6 network route -\nbut this is wrong, since ipv6 wasn\u0027t pushed this time by the server.\n\nFix by saving/restoring ifconfig(_ipv6)_local in a\nstruct options_pre_connect along with other options which\npreserves the initial values until --pull modifications\nare applied.\n\nChange-Id: I9b099924286f9bccb6833e1e40606abe72714bbb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"765d5189eabd609b70c98efd943bba5c5e2be960":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-10-09 17:19:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/48/1248/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1248/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/2 \u0026\u0026 git checkout -b change-1248 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1248/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eadae51341dbf80c83e827bb4011e80dfcbc6927","subject":"platform: Do not assume uid_t/gid_t are signed"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-10-06 11:25:11.000000000","tz":180},"committer":{"name":"cron2","email":"gert@greenie.muc.de","date":"2025-10-09 17:19:01.000000000","tz":0},"subject":"Preserve ifconfig(_ipv6)_local across reconnect","message":"Preserve ifconfig(_ipv6)_local across reconnect\n\nTurns out that ifconfig_(ipv6)_local options are set once\nand are not reset on a reconnect.\n\nConsider following scenario:\n\n - connect first time, server pushes ifconfig-ipv6\n - add a ipv6 network route because ifconfig_ipv6_local is set\n - reconnect, server doesn\u0027t push ifconfig-ipv6\n\nBecause of ifconfig_ipv6_local is not reset and holds the value\nset by the first connect, client adds a ipv6 network route -\nbut this is wrong, since ipv6 wasn\u0027t pushed this time by the server.\n\nFix by saving/restoring ifconfig(_ipv6)_local in a\nstruct options_pre_connect along with other options which\npreserves the initial values until --pull modifications\nare applied.\n\nGithub: OpenVPN/openvpn#850\nChange-Id: I9b099924286f9bccb6833e1e40606abe72714bbb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"8a8360fc176b3996bfefee0ea894dc5c8a9ead1a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-09 17:33:46.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/48/1248/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1248/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/3 \u0026\u0026 git checkout -b change-1248 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1248/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1248/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8fd8c4fa5d6c113925ebf42d47d9e8d3f292309f","subject":"options_util: Fix conversion warning in atoi_constrained"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-10-09 17:19:11.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-09 17:31:58.000000000","tz":120},"subject":"Preserve ifconfig(_ipv6)_local across reconnect","message":"Preserve ifconfig(_ipv6)_local across reconnect\n\nTurns out that ifconfig_(ipv6)_local options are set once\nand are not reset on a reconnect.\n\nConsider following scenario:\n\n - connect first time, server pushes ifconfig-ipv6\n - add a ipv6 network route because ifconfig_ipv6_local is set\n - reconnect, server doesn\u0027t push ifconfig-ipv6\n\nBecause of ifconfig_ipv6_local is not reset and holds the value\nset by the first connect, client adds a ipv6 network route -\nbut this is wrong, since ipv6 wasn\u0027t pushed this time by the server.\n\nFix by saving/restoring ifconfig(_ipv6)_local in a\nstruct options_pre_connect along with other options which\npreserves the initial values until --pull modifications\nare applied.\n\nGithub: OpenVPN/openvpn#850\nChange-Id: I9b099924286f9bccb6833e1e40606abe72714bbb\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1248\nMessage-Id: \u003c20251009171916.12811-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59244523/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}