)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"9d162a89341704ab8b249d1a9b7723ce8bc8ae9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42cc52c7_40bf8715","updated":"2025-10-07 12:18:08.000000000","message":"we have added more ASSERTS, but they should all trigger during development.\nAt least now, we have all types properly inherited.","commit_id":"43a5b4516d377bf8f07878ac00616b2ae626c561"}],"src/openvpn/networking_sitnl.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"876b2cf52cc171d86a681b1d9f76d7e973c539e2","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    struct rtattr *rta \u003d sitnl_nlmsg_tail(n);"},{"line_number":149,"context_line":"    rta-\u003erta_type \u003d type;"},{"line_number":150,"context_line":"    rta-\u003erta_len \u003d (unsigned short)len;"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if (!data)"},{"line_number":153,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"586c07ec_1e0e87a3","line":150,"updated":"2025-10-06 19:51:46.000000000","message":"what happens if we rather make everything unsigned short instead of passing through size_t?\n(technically speaking here we could have a value that is larger than USHRT_MAX, because len and maxlen are size_t)","commit_id":"bad766eb0adce151753ec62dee623f014e25c838"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2a52cdd406633c8471f42701e9908e0780fae97c","unresolved":true,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    struct rtattr *rta \u003d sitnl_nlmsg_tail(n);"},{"line_number":149,"context_line":"    rta-\u003erta_type \u003d type;"},{"line_number":150,"context_line":"    rta-\u003erta_len \u003d (unsigned short)len;"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if (!data)"},{"line_number":153,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"f96e2ed5_3791b0fb","line":150,"in_reply_to":"586c07ec_1e0e87a3","updated":"2025-10-07 10:52:03.000000000","message":"I still think it is better to use size_t for the arguments. We often use sizeof for these arguments so some compiler might throw warnings at us. Better to make the cast here later.\n\nBut yes, we should add an assert here like in the other places.","commit_id":"bad766eb0adce151753ec62dee623f014e25c838"}]}