)]}'
{"id":"openvpn~1255","triplet_id":"openvpn~master~I7c28da72be11c7efbed3068fbfc65f2959227bec","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-10 14:43:08.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-10-10 14:19:16.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-10 14:43:08.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-10-09 11:50:25.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-10-10 14:43:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7c28da72be11c7efbed3068fbfc65f2959227bec","subject":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client","status":"MERGED","created":"2025-10-08 11:31:03.000000000","updated":"2025-10-10 14:43:08.000000000","submitted":"2025-10-10 14:43:08.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1255","meta_rev_id":"62864071530e460571a86c104f436b1ef436cf78","_number":1255,"virtual_id_number":1255,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-08 11:31:03.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-08 11:31:03.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-08 11:31:03.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-08 12:03:01.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2025-10-08 12:10:48.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"},{"updated":"2025-10-09 18:28:40.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"5fdd67f70a8ef0b02d73db5cfb0290d094d799c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-08 11:31:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8c05c3eb0bdb4c146f8072c555a21718132d615","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-10-08 12:03:01.000000000","message":"Patch Set 1: Code-Review-2\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9a98bbf86e6349bb82a60d6e4413867d738a43df","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-08 12:10:48.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bd36d58560c9e6a33ba01630f7ea38f0e6f57cf0","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-08 12:19:06.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"57f084a3c0b5688a68bc16a3b2e7f9805e049846","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-08 12:21:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2b45845d2c6c3cec02286fdc6dbd4eb13bc10316","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-08 13:32:01.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"cedaaf61d2913939fd132c69452f80cbb4caa3ab","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-08 13:32:24.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7cca2fe11d69a8b45262c7b935c19cfc2ab8a630","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-10-09 11:21:47.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a735034dede54016d05f22fadee443e4cd243f4c","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-09 11:45:08.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"59b410a40d2c20e62a051cb53c4b03fcd2c15202","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-10-09 11:50:25.000000000","message":"Patch Set 2: -Code-Review","accounts_in_message":[],"_revision_number":2},{"id":"015af5ba593c30dc93ce51e298e25d100459c641","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-10-09 11:52:59.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"856a350d08ef582ef87b1a44440e98c1ca5e4494","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-09 18:28:40.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"245ed7d7fb09bcb50667df1eb5e8a1d856e3c290","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 08:03:31.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ee0931963eb9d5767b959dee1523c0df9c59d6de","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 10:23:18.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1bdc8cce5f362dcd61e4034928ae90637c85cbb3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 14:19:16.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fa3fabe2a35b9bee28dc598b29fb75d6884bd392","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 14:20:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"62864071530e460571a86c104f436b1ef436cf78","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 14:43:08.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"855094893e8cd808ddc74d2e6d392cf04bd06a65","revisions":{"ff545a94061c2f567d4c48008b1fe95af0932ee8":{"kind":"REWORK","_number":1,"created":"2025-10-08 11:31:03.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/55/1255/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1255/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/1 \u0026\u0026 git checkout -b change-1255 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1255/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"775488b81c493382625c368a71f06d009f826a35","subject":"test_options_parse: Add test for read_config_string"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-08 11:18:29.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-08 11:26:28.000000000","tz":120},"subject":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client","message":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client\n\nBefore sending the PUSH_UPDATE message to the client, we must verify that\nthe client has actually sent IV_PROTO_PUSH_UPDATE to the server, declaring that\nit supports push-updates.\n\nChange-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"6ed264057316c8792c958979a7009d66d049eecd":{"kind":"REWORK","_number":2,"created":"2025-10-08 13:32:01.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/55/1255/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1255/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/2 \u0026\u0026 git checkout -b change-1255 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1255/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"775488b81c493382625c368a71f06d009f826a35","subject":"test_options_parse: Add test for read_config_string"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-08 11:18:29.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-08 13:28:20.000000000","tz":120},"subject":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client","message":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client\n\nBefore sending the PUSH_UPDATE message to the client, we must verify that\nthe client has actually sent IV_PROTO_PUSH_UPDATE to the server, declaring that\nit supports push-updates.\n\nAlso fixed a gc_arena memory leak in one of the error paths and asserted\nmi-\u003econtext.c2.tls_multi .\n\nChange-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"855094893e8cd808ddc74d2e6d392cf04bd06a65":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-10 14:43:08.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/55/1255/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/1255/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/3 \u0026\u0026 git checkout -b change-1255 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/1255/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/1255/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"107f80b8e3102cca3a2cc008d37895f96ec2f17c","subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-09 18:28:49.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-10 14:34:51.000000000","tz":120},"subject":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client","message":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client\n\nBefore sending the PUSH_UPDATE message to the client, we must verify that\nthe client has actually sent IV_PROTO_PUSH_UPDATE to the server, declaring that\nit supports push-updates.\n\nAlso fixed a gc_arena memory leak in one of the error paths and asserted\nmi-\u003econtext.c2.tls_multi .\n\nChange-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1255\nMessage-Id: \u003c20251009182855.18712-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59244566/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}