)]}'
{"id":"openvpn~1258","triplet_id":"openvpn~master~I60df1e61ed89be52e9d032b5b49133a784f9811e","project":"openvpn","branch":"master","topic":"options_parse","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-08 16:24:24.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-08 16:24:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I60df1e61ed89be52e9d032b5b49133a784f9811e","subject":"test_options_parse: Remove --wrap","status":"MERGED","created":"2025-10-08 15:29:34.000000000","updated":"2025-10-08 16:24:24.000000000","submitted":"2025-10-08 16:24:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1258-options_parse","meta_rev_id":"6cde8893d037f8b861bdba0076c9a16f63133a19","_number":1258,"virtual_id_number":1258,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-08 15:29:34.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-08 15:29:34.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-08 16:13:38.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"64054e8942ba0127d63d26589ad04e1cbc00ba33","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-08 15:29:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"76fb4fb413296e7069ac994f7970768190d1e8b3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-08 16:13:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6cde8893d037f8b861bdba0076c9a16f63133a19","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-08 16:24:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8f3e3de7d76c2c7e7ad57586a2dfc60850dacf03","revisions":{"ebfd40bef2457f88a24607e37f8dc158f4e9f7b9":{"kind":"REWORK","_number":1,"created":"2025-10-08 15:29:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/58/1258/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/1258/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/1 \u0026\u0026 git checkout -b change-1258 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/58/1258/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f9c6aa2b4eae4e0608300f6f69dc787963e6a974","subject":"GHA: Run options_parse test for MinGW"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-08 14:19:31.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-08 14:19:31.000000000","tz":120},"subject":"test_options_parse: Remove --wrap","message":"test_options_parse: Remove --wrap\n\nAfter removing --wrap from some other tests in\na previous commit I got confused here myself.\n--wrap is really only needed when you have the\noriginal function linked in. Somehow I thought\nthe call ordering and mocking logic needed this.\n\nBut this is wrong, so no need to use --wrap here\nsince we currently do not link any of those\nfunctions.\n\nChange-Id: I60df1e61ed89be52e9d032b5b49133a784f9811e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"8f3e3de7d76c2c7e7ad57586a2dfc60850dacf03":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-10-08 16:24:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/58/1258/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/58/1258/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/2 \u0026\u0026 git checkout -b change-1258 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/58/1258/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/58/1258/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a06b9b2fcdea0ee36545019c6984baad2236e51d","subject":"proto: Clean up conversion warnings related to checksum macros"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-08 16:13:52.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-08 16:18:07.000000000","tz":120},"subject":"test_options_parse: Remove --wrap","message":"test_options_parse: Remove --wrap\n\nAfter removing --wrap from some other tests in\na previous commit I got confused here myself.\n--wrap is really only needed when you have the\noriginal function linked in. Somehow I thought\nthe call ordering and mocking logic needed this.\n\nBut this is wrong, so no need to use --wrap here\nsince we currently do not link any of those\nfunctions.\n\nChange-Id: I60df1e61ed89be52e9d032b5b49133a784f9811e\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1258\nMessage-Id: \u003c20251008161357.5679-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59244071/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}