)]}'
{"id":"openvpn~1264","triplet_id":"openvpn~master~I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-10 14:30:53.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-10 14:30:53.000000000","reason":"Change was submitted"},"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-10-10 14:30:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0","subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing","status":"MERGED","created":"2025-10-10 10:07:40.000000000","updated":"2025-10-10 14:30:53.000000000","submitted":"2025-10-10 14:30:53.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1264","meta_rev_id":"622391b73626451044207d1dfa4d25857773e77f","_number":1264,"virtual_id_number":1264,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-10 10:07:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-10 10:07:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-10 10:07:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-10 14:19:48.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"9f3c45a4facd79457e7ce24bd12c19886334863e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 10:07:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b30625a005660c132fbce558676432c1ee7c66f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 11:04:40.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"45a1bd5995abad73fa0ac82b9c53be5e8634cc5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 12:48:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"136d6429c0e38ae10730b84573f5063236e56198","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 13:32:49.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1de403f7e95ce730dede7bcd0977c838ccb0e6f6","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 14:19:48.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"622391b73626451044207d1dfa4d25857773e77f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 14:30:53.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"107f80b8e3102cca3a2cc008d37895f96ec2f17c","revisions":{"7cccf2a85b058029fd0ed06fcbaa27e31f350abb":{"kind":"REWORK","_number":1,"created":"2025-10-10 10:07:40.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/64/1264/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1264/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/1 \u0026\u0026 git checkout -b change-1264 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1264/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"290a14cd9edf95f07940f63993c290dc045c2a44","subject":"dco-win: fix broken ASSERT in dco_new_key"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 09:53:17.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 09:53:17.000000000","tz":120},"subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing","message":"PUSH_UPDATE server: bug-fix, reset buffer after processing\n\nIn the send_single_push_update() function the buffer containing\nthe message was not reset after processing, so o in a push-update-broad\nthe messages sent starting from the second client would have been\nshrunk (offset advanced and size decreased).\n\nChange-Id: I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"46190767c9ce8e160ef02ba5e1c1fb1857d47681":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-10 11:04:40.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/64/1264/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1264/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/2 \u0026\u0026 git checkout -b change-1264 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1264/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"083867b0a626b94ab93194834dddf4a38ebc8b6e","subject":"socks: Fix conversion warnings with MinGW"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 09:53:17.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 11:02:08.000000000","tz":120},"subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing","message":"PUSH_UPDATE server: bug-fix, reset buffer after processing\n\nIn the send_single_push_update() function the buffer containing\nthe message was not reset after processing, so o in a push-update-broad\nthe messages sent starting from the second client would have been\nshrunk (offset advanced and size decreased).\n\nChange-Id: I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"3a781d46d957f22675ecbdda055f8cdaf7670308":{"kind":"REWORK","_number":3,"created":"2025-10-10 12:48:23.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/64/1264/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1264/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/3 \u0026\u0026 git checkout -b change-1264 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1264/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"083867b0a626b94ab93194834dddf4a38ebc8b6e","subject":"socks: Fix conversion warnings with MinGW"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 09:53:17.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 12:45:53.000000000","tz":120},"subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing","message":"PUSH_UPDATE server: bug-fix, reset buffer after processing\n\nIn the send_single_push_update() function the buffer containing\nthe message was not reset after processing, so o in a push-update-broad\nthe messages sent starting from the second client would have been\nshrunk (offset advanced and size decreased).\n\nChange-Id: I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"84c59a8a9f4371a795a343e6b6a9838bde905743":{"kind":"REWORK","_number":4,"created":"2025-10-10 13:32:49.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/64/1264/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1264/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/4 \u0026\u0026 git checkout -b change-1264 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1264/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"083867b0a626b94ab93194834dddf4a38ebc8b6e","subject":"socks: Fix conversion warnings with MinGW"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 09:53:17.000000000","tz":120},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 13:30:19.000000000","tz":120},"subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing","message":"PUSH_UPDATE server: bug-fix, reset buffer after processing\n\nIn the send_single_push_update() function the buffer containing\nthe message was not reset after processing, so o in a push-update-broad\nthe messages sent starting from the second client would have been\nshrunk (offset advanced and size decreased).\n\nChange-Id: I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"107f80b8e3102cca3a2cc008d37895f96ec2f17c":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-10-10 14:30:53.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/64/1264/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1264/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/5 \u0026\u0026 git checkout -b change-1264 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1264/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1264/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"083867b0a626b94ab93194834dddf4a38ebc8b6e","subject":"socks: Fix conversion warnings with MinGW"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 14:19:56.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-10 14:22:32.000000000","tz":120},"subject":"PUSH_UPDATE server: bug-fix, reset buffer after processing","message":"PUSH_UPDATE server: bug-fix, reset buffer after processing\n\nIn the send_single_push_update() function the buffer containing\nthe message was not reset after processing, so o in a push-update-broad\nthe messages sent starting from the second client would have been\nshrunk (offset advanced and size decreased).\n\nChange-Id: I41d08a9a2e79ac1f1104e72dd5b7b7617e2071a0\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1264\nMessage-Id: \u003c20251010142002.27308-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59244933/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}