)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"91f36730ba98e6875a23faf60dc0917f225e71db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8bdc323c_af530f84","updated":"2026-01-14 16:01:00.000000000","message":"Hi. Had ignored this for a while mostly because mingw 13.0.0 isn\u0027t present in our buildbot fleet, yet. But tested it now and it indeed resolves the issue. But see comments about error handling.","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"}],"src/openvpn/tun.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"91f36730ba98e6875a23faf60dc0917f225e71db","unresolved":true,"context_lines":[{"line_number":3562,"context_line":""},{"line_number":3563,"context_line":"        if (ret \u003c 0 || ret \u003e\u003d sizeof(unit_string))"},{"line_number":3564,"context_line":"        {"},{"line_number":3565,"context_line":"            msg(M_FATAL, \"Error constructing unit string for %s\", enum_name);"},{"line_number":3566,"context_line":"        }"},{"line_number":3567,"context_line":""},{"line_number":3568,"context_line":"        status \u003d RegOpenKeyEx(HKEY_LOCAL_MACHINE, unit_string, 0, KEY_READ, \u0026unit_key);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8ce84b65_d5cb1a44","line":3565,"range":{"start_line":3565,"start_character":16,"end_line":3565,"end_character":23},"updated":"2026-01-14 16:01:00.000000000","message":"I think M_FATAL is too drastic here. A continue would also be okay, like we do for errors on RegOpenKeyEx a few lines below.","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ee18e9ac41e4c932f3a0e607d82ea80a526e2223","unresolved":false,"context_lines":[{"line_number":3562,"context_line":""},{"line_number":3563,"context_line":"        if (ret \u003c 0 || ret \u003e\u003d sizeof(unit_string))"},{"line_number":3564,"context_line":"        {"},{"line_number":3565,"context_line":"            msg(M_FATAL, \"Error constructing unit string for %s\", enum_name);"},{"line_number":3566,"context_line":"        }"},{"line_number":3567,"context_line":""},{"line_number":3568,"context_line":"        status \u003d RegOpenKeyEx(HKEY_LOCAL_MACHINE, unit_string, 0, KEY_READ, \u0026unit_key);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"d68ea71a_95163523","line":3565,"range":{"start_line":3565,"start_character":16,"end_line":3565,"end_character":23},"in_reply_to":"82bebc2d_983e8fec","updated":"2026-01-21 11:54:16.000000000","message":"Done","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a3473c6e58481a9bb7b6ebe40ff8ac3e191b4f65","unresolved":true,"context_lines":[{"line_number":3562,"context_line":""},{"line_number":3563,"context_line":"        if (ret \u003c 0 || ret \u003e\u003d sizeof(unit_string))"},{"line_number":3564,"context_line":"        {"},{"line_number":3565,"context_line":"            msg(M_FATAL, \"Error constructing unit string for %s\", enum_name);"},{"line_number":3566,"context_line":"        }"},{"line_number":3567,"context_line":""},{"line_number":3568,"context_line":"        status \u003d RegOpenKeyEx(HKEY_LOCAL_MACHINE, unit_string, 0, KEY_READ, \u0026unit_key);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"82bebc2d_983e8fec","line":3565,"range":{"start_line":3565,"start_character":16,"end_line":3565,"end_character":23},"in_reply_to":"8ce84b65_d5cb1a44","updated":"2026-01-20 18:18:07.000000000","message":"changed to M_WARN and continue","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"91f36730ba98e6875a23faf60dc0917f225e71db","unresolved":true,"context_lines":[{"line_number":3677,"context_line":""},{"line_number":3678,"context_line":"        if (ret \u003c 0 || ret \u003e\u003d sizeof(connection_string))"},{"line_number":3679,"context_line":"        {"},{"line_number":3680,"context_line":"            msg(M_FATAL, \"Error constructing connection string for %s\", enum_name);"},{"line_number":3681,"context_line":"        }"},{"line_number":3682,"context_line":""},{"line_number":3683,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3f5b513f_6359ba5c","line":3680,"updated":"2026-01-14 16:01:00.000000000","message":"I think M_FATAL is too drastic here. A continue would also be okay, like we do for errors on RegOpenKeyEx a few lines below.","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a3473c6e58481a9bb7b6ebe40ff8ac3e191b4f65","unresolved":true,"context_lines":[{"line_number":3677,"context_line":""},{"line_number":3678,"context_line":"        if (ret \u003c 0 || ret \u003e\u003d sizeof(connection_string))"},{"line_number":3679,"context_line":"        {"},{"line_number":3680,"context_line":"            msg(M_FATAL, \"Error constructing connection string for %s\", enum_name);"},{"line_number":3681,"context_line":"        }"},{"line_number":3682,"context_line":""},{"line_number":3683,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"79e63da6_66dea17c","line":3680,"in_reply_to":"3f5b513f_6359ba5c","updated":"2026-01-20 18:18:07.000000000","message":"changed to M_WARN and continue","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ee18e9ac41e4c932f3a0e607d82ea80a526e2223","unresolved":false,"context_lines":[{"line_number":3677,"context_line":""},{"line_number":3678,"context_line":"        if (ret \u003c 0 || ret \u003e\u003d sizeof(connection_string))"},{"line_number":3679,"context_line":"        {"},{"line_number":3680,"context_line":"            msg(M_FATAL, \"Error constructing connection string for %s\", enum_name);"},{"line_number":3681,"context_line":"        }"},{"line_number":3682,"context_line":""},{"line_number":3683,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"de6a3602_4b832d38","line":3680,"in_reply_to":"79e63da6_66dea17c","updated":"2026-01-21 11:54:16.000000000","message":"Done","commit_id":"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a"}]}
