)]}'
{"id":"openvpn~1272","triplet_id":"openvpn~master~I54b11a5540fb236580a3b80c6d1e8678b24bd852","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-01-24 15:49:52.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-01-21 11:54:16.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"I54b11a5540fb236580a3b80c6d1e8678b24bd852","subject":"Silence compiler truncation warning by checking snprintf return value","status":"MERGED","created":"2025-10-14 11:33:55.000000000","updated":"2026-01-24 15:49:52.000000000","submitted":"2026-01-24 15:49:52.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1272","meta_rev_id":"36fddac46eb4999de6de5a0e28105601d0463eb3","_number":1272,"virtual_id_number":1272,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-14 11:33:56.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-14 11:33:56.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"fb8544bc135b146053dfb316f97022c722ecbc7a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-14 11:33:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"239197ec395a6d9ab5ce31635b27b41ae94c4a9f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-14 11:50:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f69fe4a00b14acda6056f12beb054ca46a1466b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-14 15:58:25.000000000","message":"Patch Set 3: Patch Set 2 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000003\u003e","accounts_in_message":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"_revision_number":3},{"id":"91f36730ba98e6875a23faf60dc0917f225e71db","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-14 16:01:00.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"37a8f7e7c8e01962a8ab5915cf4b5d850cee576c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-01-20 18:17:34.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"a3473c6e58481a9bb7b6ebe40ff8ac3e191b4f65","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2026-01-20 18:18:07.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"ee18e9ac41e4c932f3a0e607d82ea80a526e2223","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-21 11:54:16.000000000","message":"Patch Set 4: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"8432ba3b6d82d0ea832dfdc9ae8e91d21ae309e9","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-01-21 12:19:33.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4},{"id":"36fddac46eb4999de6de5a0e28105601d0463eb3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-01-24 15:49:52.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"1fe958183fa5877d9e00cbfbe0d29477adff7187","revisions":{"019d9395207515329b846e66716872fd378ca593":{"kind":"REWORK","_number":1,"created":"2025-10-14 11:33:55.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/1272/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/1272/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/1 \u0026\u0026 git checkout -b change-1272 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/72/1272/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b298a7418e3776972159d84c4636c829ec6f6946","subject":"dhcp: Clean up type handling of write_dhcp_*"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-14 11:31:10.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-14 11:33:41.000000000","tz":120},"subject":"Silence unhelpful compiler truncation warning with bigger buffer","message":"Silence unhelpful compiler truncation warning with bigger buffer\n\nOn the more recent mingw compilers (homebrew mingw 13.0.0, GCC 15.2.0) the\ncompiler complains about a potential truncation in these two places.\n\n  src/openvpn/tun.c:3806:57:\n  error: \u0027%s\u0027 directive output may be truncated writing up\n  to 255 bytes into a region of size 178\n  [-Werror\u003dformat-truncation\u003d]\n\nThis not very helpful but just increasing the buffer sizes makes the warning\ngo away.\n\nChange-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"2f8956be553b7d1b5a77c148e8ec7651f01400d0":{"kind":"REWORK","_number":2,"created":"2025-10-14 11:50:52.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/1272/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/1272/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/2 \u0026\u0026 git checkout -b change-1272 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/72/1272/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9c78bdf6de34137c24f869d483fd962e81dccf9c","subject":"Install host routes for ifconfig-push routes when DCO is enabled"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-14 11:31:10.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-14 11:49:57.000000000","tz":120},"subject":"Silence compiler truncation warning by checking snprintf return value","message":"Silence compiler truncation warning by checking snprintf return value\n\nOn the more recent mingw compilers (homebrew mingw 13.0.0, GCC 15.2.0) the\ncompiler complains about a potential truncation in these two places.\n\n  src/openvpn/tun.c:3806:57:\n  error: \u0027%s\u0027 directive output may be truncated writing up\n  to 255 bytes into a region of size 178\n  [-Werror\u003dformat-truncation\u003d]\n\nThis not very helpful but checking the snprintf return value\nwill make the compiler not warn about this.\n\nChange-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"2d87f2de6adcc27aa6a0035f05cf6f9602a9393a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-01-14 15:58:25.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/72/1272/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/1272/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/3 \u0026\u0026 git checkout -b change-1272 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/72/1272/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d61d3c2a71136cee146ede8b834b460721dd8d23","subject":"socket: Remove old \u0027dynamic remote\u0027 feature"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-14 11:31:10.000000000","tz":120},"committer":{"name":"plaisthos","email":"arne@rfc2549.org","date":"2026-01-14 15:58:25.000000000","tz":0},"subject":"Silence compiler truncation warning by checking snprintf return value","message":"Silence compiler truncation warning by checking snprintf return value\n\nOn the more recent mingw compilers (homebrew mingw 13.0.0, GCC 15.2.0) the\ncompiler complains about a potential truncation in these two places.\n\n  src/openvpn/tun.c:3806:57:\n  error: \u0027%s\u0027 directive output may be truncated writing up\n  to 255 bytes into a region of size 178\n  [-Werror\u003dformat-truncation\u003d]\n\nThis not very helpful but checking the snprintf return value\nwill make the compiler not warn about this.\n\nChange-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"bc441315cb2f2d6a6dff1acd432184715159dd91":{"kind":"REWORK","_number":4,"created":"2026-01-20 18:17:34.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/72/1272/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/1272/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/4 \u0026\u0026 git checkout -b change-1272 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/72/1272/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2cc00e80bca26c1c7129fa45e48714ca68b56b28","subject":"socket: Avoid conversion warning in get_addr_generic"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-14 11:31:10.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-01-20 18:17:09.000000000","tz":60},"subject":"Silence compiler truncation warning by checking snprintf return value","message":"Silence compiler truncation warning by checking snprintf return value\n\nOn the more recent mingw compilers (homebrew mingw 13.0.0, GCC 15.2.0) the\ncompiler complains about a potential truncation in these two places.\n\n  src/openvpn/tun.c:3806:57:\n  error: \u0027%s\u0027 directive output may be truncated writing up\n  to 255 bytes into a region of size 178\n  [-Werror\u003dformat-truncation\u003d]\n\nThis not very helpful but checking the snprintf return value\nwill make the compiler not warn about this.\n\nChange-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"1fe958183fa5877d9e00cbfbe0d29477adff7187":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2026-01-24 15:49:52.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/72/1272/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/72/1272/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/5 \u0026\u0026 git checkout -b change-1272 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/72/1272/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/72/1272/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a31efb4950a48913e1a79dc948c6a173d744fb7","subject":"port-share: Check return value of fork()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2026-01-21 12:18:30.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-01-24 15:47:48.000000000","tz":60},"subject":"Silence compiler truncation warning by checking snprintf return value","message":"Silence compiler truncation warning by checking snprintf return value\n\nOn the more recent mingw compilers (homebrew mingw 13.0.0, GCC 15.2.0) the\ncompiler complains about a potential truncation in these two places.\n\n  src/openvpn/tun.c:3806:57:\n  error: \u0027%s\u0027 directive output may be truncated writing up\n  to 255 bytes into a region of size 178\n  [-Werror\u003dformat-truncation\u003d]\n\nThis not very helpful but checking the snprintf return value\nwill make the compiler not warn about this.\n\nChange-Id: I54b11a5540fb236580a3b80c6d1e8678b24bd852\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1272\nMessage-Id: \u003c20260121121830.27244-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35367.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
