)]}'
{"id":"openvpn~1275","triplet_id":"openvpn~master~I53dd40fabdeacb9dca843e28fdd3b357711c5a84","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-19 17:07:50.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-10-19 17:02:32.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-19 17:07:50.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-10-19 17:07:50.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-10-19 17:07:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I53dd40fabdeacb9dca843e28fdd3b357711c5a84","subject":"dco-freebsd: store peer stats directly in c2","status":"MERGED","created":"2025-10-15 07:25:21.000000000","updated":"2025-10-19 17:07:50.000000000","submitted":"2025-10-19 17:07:50.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1275","meta_rev_id":"2807b7c4e2ee73c80902be3a1b2b0dcfe97eab07","_number":1275,"virtual_id_number":1275,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-15 07:25:22.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-15 07:25:22.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-15 07:25:22.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-18 17:01:34.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"},{"updated":"2025-10-18 21:29:34.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"CC"}],"messages":[{"id":"56d8c7be5bbaab45d2faeeb9198d2b15216e6c76","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-15 07:25:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ab90352579c313f177fcfae86087187e771aa13","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-15 09:41:23.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a03439831d4dcf89d010598dce4c0a1b20ef58df","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-18 17:01:34.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"511bee86dcc353c89fcd495cc482c52e713a95e7","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-10-18 21:29:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"621cc5c4e16fba7674ba0ac7100d4ca125fd3050","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-19 08:36:58.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"22a140a305a6061adc54779931cd87b6a453dda4","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-19 08:37:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c87308709c7cecdb2ad5e4fa1f246f196cdfa3be","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-19 12:05:57.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d448ed10930b8c149ccd08b8e7e65103cb37f5c2","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-19 17:02:32.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"2807b7c4e2ee73c80902be3a1b2b0dcfe97eab07","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-19 17:07:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"bf01a965dfbfc2651eaf3dbe4d37da74f3071628","revisions":{"a3a7a478d38ac6166310dc04c4c840f2ae5663d6":{"kind":"REWORK","_number":1,"created":"2025-10-15 07:25:21.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/75/1275/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1275/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/1 \u0026\u0026 git checkout -b change-1275 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/1275/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"290a14cd9edf95f07940f63993c290dc045c2a44","subject":"dco-win: fix broken ASSERT in dco_new_key"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-15 06:58:51.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-15 06:58:51.000000000","tz":120},"subject":"dco-freebsd: store peer stats directly in c2","message":"dco-freebsd: store peer stats directly in c2\n\nThe dco_context_t structure includes a reference to the general context\nstructure c, which allows us to store dco_read_bytes and dco_write_bytes\ndirectly as c2 fields. This aligns the FreeBSD implementation with how\nwe handle DCO peer stats on Linux and Windows.\n\nChange-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8f119b9658818aa98f337e9d48a5b0c1c9b5d95c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-15 09:41:23.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/75/1275/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1275/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/2 \u0026\u0026 git checkout -b change-1275 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/1275/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b298a7418e3776972159d84c4636c829ec6f6946","subject":"dhcp: Clean up type handling of write_dhcp_*"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-15 06:58:51.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-15 09:40:53.000000000","tz":120},"subject":"dco-freebsd: store peer stats directly in c2","message":"dco-freebsd: store peer stats directly in c2\n\nThe dco_context_t structure includes a reference to the general context\nstructure c, which allows us to store dco_read_bytes and dco_write_bytes\ndirectly as c2 fields. This aligns the FreeBSD implementation with how\nwe handle DCO peer stats on Linux and Windows.\n\nChange-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"061ca36bcd08f8ab319c4ed54720c6494b50597c":{"kind":"REWORK","_number":3,"created":"2025-10-19 08:36:58.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/75/1275/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1275/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/3 \u0026\u0026 git checkout -b change-1275 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/1275/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a8b8e41c7906c895ba6c88aa748e6dfa3946aff5","subject":"push_util: Fix conversion warnings"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-15 06:58:51.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-19 08:19:41.000000000","tz":120},"subject":"dco-freebsd: store peer stats directly in c2","message":"dco-freebsd: store peer stats directly in c2\n\nThe dco_context_t structure includes a reference to the general context\nstructure c, which allows us to store dco_read_bytes and dco_write_bytes\ndirectly as c2 fields. This aligns the FreeBSD implementation with how\nwe handle DCO peer stats on Linux and Windows.\n\nChange-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"043ad846e622b4f6c63f195488a96168a845e76d":{"kind":"REWORK","_number":4,"created":"2025-10-19 12:05:57.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/75/1275/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1275/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/4 \u0026\u0026 git checkout -b change-1275 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/1275/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a8b8e41c7906c895ba6c88aa748e6dfa3946aff5","subject":"push_util: Fix conversion warnings"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-15 06:58:51.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-19 12:04:55.000000000","tz":120},"subject":"dco-freebsd: store peer stats directly in c2","message":"dco-freebsd: store peer stats directly in c2\n\nThe dco_context_t structure includes a reference to the general context\nstructure c, which allows us to store dco_read_bytes and dco_write_bytes\ndirectly as c2 fields. This aligns the FreeBSD implementation with how\nwe handle DCO peer stats on Linux and Windows.\n\nChange-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"bf01a965dfbfc2651eaf3dbe4d37da74f3071628":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-10-19 17:07:50.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/75/1275/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1275/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/5 \u0026\u0026 git checkout -b change-1275 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/1275/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/1275/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a8b8e41c7906c895ba6c88aa748e6dfa3946aff5","subject":"push_util: Fix conversion warnings"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-19 17:02:42.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-19 17:05:07.000000000","tz":120},"subject":"dco-freebsd: store peer stats directly in c2","message":"dco-freebsd: store peer stats directly in c2\n\nThe dco_context_t structure includes a reference to the general context\nstructure c, which allows us to store dco_read_bytes and dco_write_bytes\ndirectly as c2 fields. This aligns the FreeBSD implementation with how\nwe handle DCO peer stats on Linux and Windows.\n\nChange-Id: I53dd40fabdeacb9dca843e28fdd3b357711c5a84\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1275\nMessage-Id: \u003c20251019170249.30942-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33791.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}