)]}'
{"id":"openvpn~1280","triplet_id":"openvpn~master~I7b718a14b81e3759398e7a52fe151102494cc821","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-17 19:30:28.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-17 19:30:28.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-10-17 19:30:28.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7b718a14b81e3759398e7a52fe151102494cc821","subject":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled","status":"MERGED","created":"2025-10-16 15:49:10.000000000","updated":"2025-10-17 19:30:28.000000000","submitted":"2025-10-17 19:30:28.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1280","meta_rev_id":"a822fad86d8bf4d76a1d7ac132b7462af84ea60a","_number":1280,"virtual_id_number":1280,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-16 15:49:11.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-16 15:49:11.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-16 15:49:11.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-17 19:15:31.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"29aa50c4227031d57fd19bc78a0d524db7fbd22c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-16 15:49:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f6eb237f8738b0a3ac65728c871d489cf59eeb9d","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-16 15:50:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e8c8b813ac0cd88887dedf5d6e4c09d8e5466c74","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-17 07:48:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b39e65f634a0c9a24910585dde6bd04dc920fc9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-17 15:20:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7e0d68e30e6540a755ede0b321975a67dc9be192","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-17 19:15:31.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"a822fad86d8bf4d76a1d7ac132b7462af84ea60a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-17 19:30:28.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c9a320649bd4ec43d3f2640f70476178d8fcc660","revisions":{"45bb65476e49344733e547823d93f1a5fc9c7ad3":{"kind":"REWORK","_number":1,"created":"2025-10-16 15:49:10.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/80/1280/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/80/1280/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/1 \u0026\u0026 git checkout -b change-1280 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/80/1280/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23d70b08a94b150f5df76449e2acbf7a1160146a","subject":"proxy: factor out send code common with socks proxy"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-16 15:04:12.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-16 15:45:51.000000000","tz":120},"subject":"dco: disable DCO when using --reneg-bytes/pkts","message":"dco: disable DCO when using --reneg-bytes/pkts\n\nWhen using --reneg-bytes or --reneg-pkts, openvpn negotiates a new key\nupon reaching the specified threshold. This implies the usage of per-key\ncounters. DCO, on the other hand, provides only global statistics,\nmaking it currently impossible to track when renegotiation should occur.\n\nTo avoid introducing unnecessary complexity into DCO, it is disabled\nwhen either of these options is specified. Instead, the automatic key\nrenegotiation mechanism is preferred, as it provides a more modern and\nstreamlined approach.\n\nChange-Id: I7b718a14b81e3759398e7a52fe151102494cc821\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"0ab37395458c3995699d4987b12ab3eb645e4de7":{"kind":"REWORK","_number":2,"created":"2025-10-17 07:48:10.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/80/1280/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/80/1280/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/2 \u0026\u0026 git checkout -b change-1280 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/80/1280/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23d70b08a94b150f5df76449e2acbf7a1160146a","subject":"proxy: factor out send code common with socks proxy"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-16 15:04:12.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-17 07:31:03.000000000","tz":120},"subject":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled","message":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled\n\nThe --reneg-bytes and --reneg-pkts options rely on per-key counters to\ntrigger key renegotiation. DCO, however, only provides global\nstatistics, making it incompatible with these options.\n\nRather than adding complexity to support legacy behavior, ignore these\noptions when DCO is enabled. Print a warning to inform users and update\nthe manpage accordingly.\n\nChange-Id: I7b718a14b81e3759398e7a52fe151102494cc821\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"42a73b70ddad86f3ad1a302cab1902946201d953":{"kind":"REWORK","_number":3,"created":"2025-10-17 15:20:56.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/80/1280/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/80/1280/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/3 \u0026\u0026 git checkout -b change-1280 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/80/1280/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23d70b08a94b150f5df76449e2acbf7a1160146a","subject":"proxy: factor out send code common with socks proxy"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-16 15:04:12.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-17 15:13:35.000000000","tz":120},"subject":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled","message":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled\n\nThresholds specified by --reneg-bytes and --reneg-pkts cannot be\nenforced when DCO is enabled, as it only provides global statistics.\n\nRather than adding complexity to support these options, ignore them when\nDCO is enabled. Print a warning to inform users and update the manpage\naccordingly.\n\nChange-Id: I7b718a14b81e3759398e7a52fe151102494cc821\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c9a320649bd4ec43d3f2640f70476178d8fcc660":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-10-17 19:30:28.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/80/1280/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/80/1280/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/4 \u0026\u0026 git checkout -b change-1280 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/80/1280/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1280/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"23d70b08a94b150f5df76449e2acbf7a1160146a","subject":"proxy: factor out send code common with socks proxy"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-17 19:16:06.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-17 19:20:01.000000000","tz":120},"subject":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled","message":"options: warn and ignore --reneg-bytes/pkts when DCO is enabled\n\nThresholds specified by --reneg-bytes and --reneg-pkts cannot be\nenforced when DCO is enabled, as it only provides global statistics.\n\nRather than adding complexity to support these options, ignore them when\nDCO is enabled. Print a warning to inform users and update the manpage\naccordingly.\n\nChange-Id: I7b718a14b81e3759398e7a52fe151102494cc821\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1280\nMessage-Id: \u003c20251017191612.15642-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59248122/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}