)]}'
{"id":"openvpn~1285","triplet_id":"openvpn~master~Ifb1c49fce75e671f699f5db5f6da7246f6e0b519","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-28 18:53:25.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-28 18:53:25.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-10-28 18:53:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifb1c49fce75e671f699f5db5f6da7246f6e0b519","subject":"management: ensure consistent BYTECOUNT timing on server","status":"MERGED","created":"2025-10-20 06:37:17.000000000","updated":"2025-10-28 18:53:25.000000000","submitted":"2025-10-28 18:53:25.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1285","meta_rev_id":"eaf9dce7db3dc6f4eca09e26f65021d5bee5c286","_number":1285,"virtual_id_number":1285,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-20 06:37:17.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-20 06:37:17.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-20 06:37:17.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-21 07:00:17.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"483314e22b9ea86460dc28963fc3543d2ee41839","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-20 06:37:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"201e70baec0f99031bc52c899433ffd36ee6ab10","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-20 13:31:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a9ee8e8b448504b8831ef615778bccfd08f6b0fe","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-10-21 07:00:17.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"eaf9dce7db3dc6f4eca09e26f65021d5bee5c286","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-28 18:53:25.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a5ee6a1d642ae365eae78fd04d51976c365b2b59","revisions":{"c633dd12301fac19b3d56b785d3a96a9a85e3a2a":{"kind":"REWORK","_number":1,"created":"2025-10-20 06:37:17.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/85/1285/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1285/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/1 \u0026\u0026 git checkout -b change-1285 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/1285/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e76d8f8a475d08bcb50321e742a06c53e19d45d","subject":"dco: remove dco_read/write_bytes from dco_context_t"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-19 21:33:16.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-20 06:31:03.000000000","tz":120},"subject":"management: ensure consistent BYTECOUNT timing on server","message":"management: ensure consistent BYTECOUNT timing on server\n\nThe BYTECOUNT notification is expected to be emitted every N seconds\nwhen a management client issues the \u0027bytecount N\u0027 command. However, the\nserver currently relies on timeouts from unrelated periodic operations,\nresulting in irregular notification timing.\n\nThis issue is especially noticeable with low bytecount intervals and DCO\nenabled, as openvpn handles less traffic in userspace, causing the main\nloop to run less frequently.\n\nTo address this, refactor the timeout logic and pass the timeval\nreference to management_check_bytecount_server so that the timeout is\ncorrectly set and notifications adhere to the specified interval.\n\nChange-Id: Ifb1c49fce75e671f699f5db5f6da7246f6e0b519\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"bbd4633a29ce5f659134e23e536b4bb76e41644f":{"kind":"REWORK","_number":2,"created":"2025-10-20 13:31:26.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/85/1285/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1285/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/2 \u0026\u0026 git checkout -b change-1285 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/1285/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e76d8f8a475d08bcb50321e742a06c53e19d45d","subject":"dco: remove dco_read/write_bytes from dco_context_t"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-19 21:33:16.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-20 13:31:15.000000000","tz":120},"subject":"management: ensure consistent BYTECOUNT timing on server","message":"management: ensure consistent BYTECOUNT timing on server\n\nThe BYTECOUNT notification is expected to be emitted every N seconds\nwhen a management client issues the \u0027bytecount N\u0027 command. However, the\nserver currently relies on timeouts from unrelated periodic operations,\nresulting in irregular notification timing.\n\nThis issue is especially noticeable with low bytecount intervals and DCO\nenabled, as openvpn handles less traffic in userspace, causing the main\nloop to run less frequently.\n\nTo address this, refactor the timeout logic and pass the timeval\nreference to management_check_bytecount_server so that the timeout is\ncorrectly set and notifications adhere to the specified interval.\n\nChange-Id: Ifb1c49fce75e671f699f5db5f6da7246f6e0b519\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"a5ee6a1d642ae365eae78fd04d51976c365b2b59":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-28 18:53:25.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/85/1285/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1285/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/3 \u0026\u0026 git checkout -b change-1285 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/1285/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1285/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d6a0cf599c68edc672c67c6afa4bdff0e1a30b8a","subject":"Warn if push is used without --mode server/--server/--server-bridge"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-21 07:08:20.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-28 18:45:30.000000000","tz":60},"subject":"management: ensure consistent BYTECOUNT timing on server","message":"management: ensure consistent BYTECOUNT timing on server\n\nThe BYTECOUNT notification is expected to be emitted every N seconds\nwhen a management client issues the \u0027bytecount N\u0027 command. However, the\nserver currently relies on timeouts from unrelated periodic operations,\nresulting in irregular notification timing.\n\nThis issue is especially noticeable with low bytecount intervals and DCO\nenabled, as openvpn handles less traffic in userspace, causing the main\nloop to run less frequently.\n\nTo address this, refactor the timeout logic and pass the timeval\nreference to management_check_bytecount_server so that the timeout is\ncorrectly set and notifications adhere to the specified interval.\n\nChange-Id: Ifb1c49fce75e671f699f5db5f6da7246f6e0b519\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nMessage-Id: \u003c20251021070825.20773-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33812.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}