)]}'
{"id":"openvpn~1287","triplet_id":"openvpn~master~I27f2fcd903d26ccbfbd0cdc45f99cc3cd8b0e49a","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-28 19:22:22.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-28 19:22:22.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I27f2fcd903d26ccbfbd0cdc45f99cc3cd8b0e49a","subject":"crypto_backend: Change len argument of md_ctx_update to size_t","status":"MERGED","created":"2025-10-20 13:31:03.000000000","updated":"2025-10-28 19:22:22.000000000","submitted":"2025-10-28 19:22:22.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1287-wconversion","meta_rev_id":"43b15b447e09710b99f214cb44a2266ce5d200e2","_number":1287,"virtual_id_number":1287,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-20 13:31:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-20 13:31:05.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-28 18:56:52.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"f19e62a15c17e917fbd64ed689741fc037d63313","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-20 13:31:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0e486661fa35b976c8ea33d031df12b0cd53fd7e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-20 15:13:58.000000000","message":"Topic set to wconversion","accounts_in_message":[],"_revision_number":1},{"id":"f71052cf5f285dccf5154bebbb7b1e628ed5751e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-24 16:52:30.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"c2b88710222c9cf4d239f723998286236c388993","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-28 18:56:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"43b15b447e09710b99f214cb44a2266ce5d200e2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-28 19:22:22.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6607e4be62e71c8c006d3286e99ec582cb9912b6","revisions":{"271117da9089f882595449bc51084660623610a5":{"kind":"REWORK","_number":1,"created":"2025-10-20 13:31:03.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/87/1287/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1287/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/1 \u0026\u0026 git checkout -b change-1287 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1287/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f62a0fd1eb3a4ef36f61c4c07bb791cfdf34df0","subject":"gremlin: Avoid some conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-20 13:28:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-20 13:28:24.000000000","tz":120},"subject":"crypto_backend: Change len argument of md_ctx_update to size_t","message":"crypto_backend: Change len argument of md_ctx_update to size_t\n\nThe underlying APIs already use size_t and all the\nusers (only httpdigest and push) already put size_t\ninto it. So avoid conversion warnings.\n\nAlso fix one trivial conversion warning in push.c\nto able to easily remove the -Wconversion override\nfrom the affected code paths.\n\nChange-Id: I27f2fcd903d26ccbfbd0cdc45f99cc3cd8b0e49a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"50466a0649f8cc56e92e9bec6f0755c45e9e5b1d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-24 16:52:30.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/87/1287/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1287/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/2 \u0026\u0026 git checkout -b change-1287 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1287/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3f9b3a09689b90188c7b52d5c3210f031fd0a8bd","subject":"gremlin: Avoid some conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-20 13:28:24.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:50:29.000000000","tz":120},"subject":"crypto_backend: Change len argument of md_ctx_update to size_t","message":"crypto_backend: Change len argument of md_ctx_update to size_t\n\nThe underlying APIs already use size_t and all the\nusers (only httpdigest and push) already put size_t\ninto it. So avoid conversion warnings.\n\nAlso fix one trivial conversion warning in push.c\nto able to easily remove the -Wconversion override\nfrom the affected code paths.\n\nChange-Id: I27f2fcd903d26ccbfbd0cdc45f99cc3cd8b0e49a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6607e4be62e71c8c006d3286e99ec582cb9912b6":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-28 19:22:22.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/87/1287/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1287/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/3 \u0026\u0026 git checkout -b change-1287 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1287/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1287/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15b77d47f5a9dc78615cdafc50bbb05d5a21c3d6","subject":"gremlin: Avoid some conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-28 18:57:01.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-28 19:21:15.000000000","tz":60},"subject":"crypto_backend: Change len argument of md_ctx_update to size_t","message":"crypto_backend: Change len argument of md_ctx_update to size_t\n\nThe underlying APIs already use size_t and all the\nusers (only httpdigest and push) already put size_t\ninto it. So avoid conversion warnings.\n\nAlso fix one trivial conversion warning in push.c\nto able to easily remove the -Wconversion override\nfrom the affected code paths.\n\nChange-Id: I27f2fcd903d26ccbfbd0cdc45f99cc3cd8b0e49a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1287\nMessage-Id: \u003c20251028185706.1247-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33973.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
