)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5b50a3b2dc711c7b36022e9387e109db3d945fbc","unresolved":true,"context_lines":[{"line_number":11,"context_line":"negotiation compatibility way rather than actually negotiating"},{"line_number":12,"context_line":"protocol features."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also remove an used macro."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f7cedb8d_5f290a51","line":14,"updated":"2025-10-20 14:57:01.000000000","message":"\"unused\" I assume","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0aca1c9e0421c6d255d1af2d122afb5a30026596","unresolved":false,"context_lines":[{"line_number":11,"context_line":"negotiation compatibility way rather than actually negotiating"},{"line_number":12,"context_line":"protocol features."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also remove an used macro."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d7f5c5d0_97f445f3","line":14,"in_reply_to":"f7cedb8d_5f290a51","updated":"2025-10-20 16:16:03.000000000","message":"Acknowledged","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffe652f7ea5a4f88dd686cdb44f07ac220394082","unresolved":true,"context_lines":[{"line_number":11,"context_line":"negotiation compatibility way rather than actually negotiating"},{"line_number":12,"context_line":"protocol features."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also remove an anused macro."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c"},{"line_number":17,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a1908839_a42c5e1a","line":14,"updated":"2025-10-21 10:48:00.000000000","message":"```suggestion\nAlso remove an unused macro.\n```","commit_id":"84bae9db50a0c01f485d0cac44fa74307e151842"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffe652f7ea5a4f88dd686cdb44f07ac220394082","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11f9e715_1241cb6a","updated":"2025-10-21 10:48:00.000000000","message":"LGTM, but still a typo in commit message","commit_id":"84bae9db50a0c01f485d0cac44fa74307e151842"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5b50a3b2dc711c7b36022e9387e109db3d945fbc","unresolved":true,"context_lines":[{"line_number":3334,"context_line":"                        \"Ignoring these options.\");"},{"line_number":3335,"context_line":"        }"},{"line_number":3336,"context_line":"    }"},{"line_number":3337,"context_line":"    "},{"line_number":3338,"context_line":"    if (o-\u003epush_list.head \u0026\u0026 o-\u003emode !\u003d MODE_SERVER)"},{"line_number":3339,"context_line":"    {"},{"line_number":3340,"context_line":"        msg(M_WARN, \"Note: Using --push without --mode server is an unsupported\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d6b588cf_299e97fa","line":3337,"updated":"2025-10-20 14:57:01.000000000","message":"whitespace","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0aca1c9e0421c6d255d1af2d122afb5a30026596","unresolved":false,"context_lines":[{"line_number":3334,"context_line":"                        \"Ignoring these options.\");"},{"line_number":3335,"context_line":"        }"},{"line_number":3336,"context_line":"    }"},{"line_number":3337,"context_line":"    "},{"line_number":3338,"context_line":"    if (o-\u003epush_list.head \u0026\u0026 o-\u003emode !\u003d MODE_SERVER)"},{"line_number":3339,"context_line":"    {"},{"line_number":3340,"context_line":"        msg(M_WARN, \"Note: Using --push without --mode server is an unsupported\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9676fd5c_46a87c6f","line":3337,"in_reply_to":"d6b588cf_299e97fa","updated":"2025-10-20 16:16:03.000000000","message":"Done","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5b50a3b2dc711c7b36022e9387e109db3d945fbc","unresolved":true,"context_lines":[{"line_number":3335,"context_line":"        }"},{"line_number":3336,"context_line":"    }"},{"line_number":3337,"context_line":"    "},{"line_number":3338,"context_line":"    if (o-\u003epush_list.head \u0026\u0026 o-\u003emode !\u003d MODE_SERVER)"},{"line_number":3339,"context_line":"    {"},{"line_number":3340,"context_line":"        msg(M_WARN, \"Note: Using --push without --mode server is an unsupported\""},{"line_number":3341,"context_line":"                    \" configuration. Negotiation of OpenVPN features is expected to fail.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf2317ec_7c3577ee","line":3338,"updated":"2025-10-20 14:57:01.000000000","message":"We have a lot of warnings and errors that we potentially throw if not in --mode server, see code around line 2650. Maybe this new check would be better put there?","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0aca1c9e0421c6d255d1af2d122afb5a30026596","unresolved":false,"context_lines":[{"line_number":3335,"context_line":"        }"},{"line_number":3336,"context_line":"    }"},{"line_number":3337,"context_line":"    "},{"line_number":3338,"context_line":"    if (o-\u003epush_list.head \u0026\u0026 o-\u003emode !\u003d MODE_SERVER)"},{"line_number":3339,"context_line":"    {"},{"line_number":3340,"context_line":"        msg(M_WARN, \"Note: Using --push without --mode server is an unsupported\""},{"line_number":3341,"context_line":"                    \" configuration. Negotiation of OpenVPN features is expected to fail.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"04ba28cd_b064d58d","line":3338,"in_reply_to":"bf2317ec_7c3577ee","updated":"2025-10-20 16:16:03.000000000","message":"Done","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5b50a3b2dc711c7b36022e9387e109db3d945fbc","unresolved":true,"context_lines":[{"line_number":3337,"context_line":"    "},{"line_number":3338,"context_line":"    if (o-\u003epush_list.head \u0026\u0026 o-\u003emode !\u003d MODE_SERVER)"},{"line_number":3339,"context_line":"    {"},{"line_number":3340,"context_line":"        msg(M_WARN, \"Note: Using --push without --mode server is an unsupported\""},{"line_number":3341,"context_line":"                    \" configuration. Negotiation of OpenVPN features is expected to fail.\");"},{"line_number":3342,"context_line":"    }"},{"line_number":3343,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1d984d7c_11af20d7","line":3340,"updated":"2025-10-20 14:57:01.000000000","message":"We probably also should add a note under --push in the documentation.","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0aca1c9e0421c6d255d1af2d122afb5a30026596","unresolved":false,"context_lines":[{"line_number":3337,"context_line":"    "},{"line_number":3338,"context_line":"    if (o-\u003epush_list.head \u0026\u0026 o-\u003emode !\u003d MODE_SERVER)"},{"line_number":3339,"context_line":"    {"},{"line_number":3340,"context_line":"        msg(M_WARN, \"Note: Using --push without --mode server is an unsupported\""},{"line_number":3341,"context_line":"                    \" configuration. Negotiation of OpenVPN features is expected to fail.\");"},{"line_number":3342,"context_line":"    }"},{"line_number":3343,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"861ffac4_9f1909cd","line":3340,"in_reply_to":"1d984d7c_11af20d7","updated":"2025-10-20 16:16:03.000000000","message":"Done","commit_id":"7d906c7448426d88659ba4346d3b67eb13e8d512"}]}