)]}'
{"id":"openvpn~1288","triplet_id":"openvpn~master~I82c7c61be07593ecd5bf2f854767dda74ab5170c","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-28 17:46:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-21 10:48:00.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I82c7c61be07593ecd5bf2f854767dda74ab5170c","subject":"Warn if push is used without --mode server/--server/--server-bridge","status":"MERGED","created":"2025-10-20 14:16:23.000000000","updated":"2025-10-28 17:46:45.000000000","submitted":"2025-10-28 17:46:45.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":10,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1288","meta_rev_id":"49250f4a504153140b611c72d5ceec913e533a0c","_number":1288,"virtual_id_number":1288,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-20 14:16:23.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-20 14:16:23.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"0a2029578f543cb9e3613e47a8d962b4d7f2ad3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-20 14:16:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b50a3b2dc711c7b36022e9387e109db3d945fbc","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-20 14:57:01.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0aca1c9e0421c6d255d1af2d122afb5a30026596","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-20 16:16:03.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"98a205f0efaacd8396ff43ff664b07531d522374","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-20 16:20:13.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ffe652f7ea5a4f88dd686cdb44f07ac220394082","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-21 10:48:00.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"49250f4a504153140b611c72d5ceec913e533a0c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-28 17:46:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d6a0cf599c68edc672c67c6afa4bdff0e1a30b8a","revisions":{"7d906c7448426d88659ba4346d3b67eb13e8d512":{"kind":"REWORK","_number":1,"created":"2025-10-20 14:16:23.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/88/1288/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1288/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/1 \u0026\u0026 git checkout -b change-1288 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1288/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e76d8f8a475d08bcb50321e742a06c53e19d45d","subject":"dco: remove dco_read/write_bytes from dco_context_t"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-20 13:39:08.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-20 14:14:59.000000000","tz":120},"subject":"Warn if push is used without --mode server/--server/--server-bridge","message":"Warn if push is used without --mode server/--server/--server-bridge\n\nThis is not a supported configuration and will often work good enough\nto get a connection working but will operate more in a weird pre P2P\nnegotiation compatibility way rather than actually negotiating\nprotocol features.\n\nAlso remove an used macro.\n\nChange-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c\n"},"branch":"refs/heads/master"},"84bae9db50a0c01f485d0cac44fa74307e151842":{"kind":"REWORK","_number":2,"created":"2025-10-20 16:20:13.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/88/1288/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1288/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/2 \u0026\u0026 git checkout -b change-1288 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1288/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e76d8f8a475d08bcb50321e742a06c53e19d45d","subject":"dco: remove dco_read/write_bytes from dco_context_t"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-20 13:39:08.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-20 16:20:03.000000000","tz":120},"subject":"Warn if push is used without --mode server/--server/--server-bridge","message":"Warn if push is used without --mode server/--server/--server-bridge\n\nThis is not a supported configuration and will often work good enough\nto get a connection working but will operate more in a weird pre P2P\nnegotiation compatibility way rather than actually negotiating\nprotocol features.\n\nAlso remove an anused macro.\n\nChange-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"d6a0cf599c68edc672c67c6afa4bdff0e1a30b8a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-28 17:46:45.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/1288/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1288/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/3 \u0026\u0026 git checkout -b change-1288 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1288/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1288/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0d96fd8732bd903ab390bb5047a13880cdcac9b","subject":"tcp: apply CLOEXEC to accepted socket, not listener"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-23 15:56:08.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-28 17:36:25.000000000","tz":60},"subject":"Warn if push is used without --mode server/--server/--server-bridge","message":"Warn if push is used without --mode server/--server/--server-bridge\n\nThis is not a supported configuration and will often work good enough\nto get a connection working but will operate more in a weird pre P2P\nnegotiation compatibility way rather than actually negotiating\nprotocol features.\n\nWhile at it, remove an unused macro (PUSH_DEFINED).\n\nChange-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1288\nMessage-Id: \u003c20251023155614.20642-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33856.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}