)]}'
{"id":"openvpn~1290","triplet_id":"openvpn~master~I92b5f3996f2a2180fa5e94719603078c1fc2f7f6","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-28 11:46:18.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-28 11:46:18.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-10-28 11:46:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I92b5f3996f2a2180fa5e94719603078c1fc2f7f6","subject":"dco-freebsd: fix peer stats storage on client instances","status":"MERGED","created":"2025-10-21 08:09:22.000000000","updated":"2025-10-28 11:46:18.000000000","submitted":"2025-10-28 11:46:18.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1290","meta_rev_id":"9a7cfa2a8dd4e4d9d9329d6c2116eb646fb5c0b0","_number":1290,"virtual_id_number":1290,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-21 08:09:22.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-21 08:09:22.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-21 08:09:22.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-21 11:42:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"state":"REVIEWER"},{"updated":"2025-10-28 11:32:55.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"6724147d535fcfe1f525168050584e0ab1f56615","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-10-21 08:09:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c02bbcb8f63697646436782aa82bb2bda2efd28","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-21 11:42:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"889597087a54cf1aad1fd0cffa72b2e93d8478b0","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-28 11:32:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9a7cfa2a8dd4e4d9d9329d6c2116eb646fb5c0b0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-28 11:46:18.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dc6b75788c626add84384ac121e11b65f9e02a6a","revisions":{"17395d7755762cc61888277232a41deb1c3dea01":{"kind":"REWORK","_number":1,"created":"2025-10-21 08:09:22.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/90/1290/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1290/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/1 \u0026\u0026 git checkout -b change-1290 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1290/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e76d8f8a475d08bcb50321e742a06c53e19d45d","subject":"dco: remove dco_read/write_bytes from dco_context_t"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-21 07:54:18.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-21 08:02:52.000000000","tz":120},"subject":"dco-freebsd: fix peer stats storage on client instances","message":"dco-freebsd: fix peer stats storage on client instances\n\nCommit bf01a96 introduced a bug in the dco-freebsd path by attempting to\nstore peer statistics in a structure that only exists on server\ninstances. This leads to a SIGSEGV on non-server instances due to a NULL\nmulti_context pointer.\n\nResolve this by checking what mode the current instance is running in\nand storing peer stats accordingly.\n\nFixes: https://github.com/OpenVPN/openvpn/issues/875\nChange-Id: I92b5f3996f2a2180fa5e94719603078c1fc2f7f6\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"dc6b75788c626add84384ac121e11b65f9e02a6a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-10-28 11:46:18.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/90/1290/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1290/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/2 \u0026\u0026 git checkout -b change-1290 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1290/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1290/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18309ff64833523c1ad19e7d56d6f756b53966af","subject":"Avoid possible race condition that kill OpenVPN itself"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-10-28 11:33:05.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-28 11:43:08.000000000","tz":60},"subject":"dco-freebsd: fix peer stats storage on client instances","message":"dco-freebsd: fix peer stats storage on client instances\n\nCommit bf01a96 introduced a bug in the dco-freebsd path by attempting to\nstore peer statistics in a structure that only exists on server\ninstances. This leads to a SIGSEGV on non-server instances due to a NULL\nmulti_context pointer.\n\nResolve this by checking what mode the current instance is running in\nand storing peer stats accordingly.\n\nFixes: https://github.com/OpenVPN/openvpn/issues/875\nChange-Id: I92b5f3996f2a2180fa5e94719603078c1fc2f7f6\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1290\nMessage-Id: \u003c20251028113310.19921-1-gert@greenie.muc.de\u003e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}