)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"cafbc2217175255e0c8cb1056b72d0a4b6f4e8e9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f3d3938f_1a6d7071","updated":"2025-11-17 07:59:08.000000000","message":"Not sure I understand all the implications.  It would be good if @arne-openvpn@rfc2549.org had a look.","commit_id":"ff24d26d421c2d878331addc02f3cb9070efbb03"}],"src/openvpn/push.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"cafbc2217175255e0c8cb1056b72d0a4b6f4e8e9","unresolved":true,"context_lines":[{"line_number":448,"context_line":"    if (time_elapsed \u003c 0 || time_elapsed \u003e\u003d (time_t)max_timeout)"},{"line_number":449,"context_line":"    {"},{"line_number":450,"context_line":"        return false;"},{"line_number":451,"context_line":"    }"},{"line_number":452,"context_line":"    max_timeout -\u003d (unsigned int)time_elapsed;"},{"line_number":453,"context_line":"    timeout \u003d min_uint(max_timeout, timeout);"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"0f14fa70_d0079f91","line":451,"updated":"2025-11-17 07:59:08.000000000","message":"I\u0027m a bit unsure about that.  In the (unlikely) case of time_elapsed \u003e max_timeout (not sure if this could happen, but maybe if the userland process happens to be busy with ill-behaved scripts?) then we\u0027ll not do any AUTH_PENDING at all?  Or am I misreading this?","commit_id":"ff24d26d421c2d878331addc02f3cb9070efbb03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a3515cf4acfc9cc5949d4c6d85d2b54a7cfcdbb0","unresolved":true,"context_lines":[{"line_number":448,"context_line":"    if (time_elapsed \u003c 0 || time_elapsed \u003e\u003d (time_t)max_timeout)"},{"line_number":449,"context_line":"    {"},{"line_number":450,"context_line":"        return false;"},{"line_number":451,"context_line":"    }"},{"line_number":452,"context_line":"    max_timeout -\u003d (unsigned int)time_elapsed;"},{"line_number":453,"context_line":"    timeout \u003d min_uint(max_timeout, timeout);"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"9d217d86_9a244d8c","line":451,"in_reply_to":"0f14fa70_d0079f91","updated":"2025-11-20 14:42:04.000000000","message":"But isn\u0027t that correct? In that case \"max_timeout\" has already expired, so shouldn\u0027t we fail?","commit_id":"ff24d26d421c2d878331addc02f3cb9070efbb03"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"16a3610a664a2d25ad2f0d355432228b81dcc45a","unresolved":true,"context_lines":[{"line_number":448,"context_line":"    if (time_elapsed \u003c 0 || time_elapsed \u003e\u003d (time_t)max_timeout)"},{"line_number":449,"context_line":"    {"},{"line_number":450,"context_line":"        return false;"},{"line_number":451,"context_line":"    }"},{"line_number":452,"context_line":"    max_timeout -\u003d (unsigned int)time_elapsed;"},{"line_number":453,"context_line":"    timeout \u003d min_uint(max_timeout, timeout);"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1ede80cb_484f24b6","line":451,"in_reply_to":"9d217d86_9a244d8c","updated":"2026-01-21 12:32:09.000000000","message":"Since this return value is only what the management interface gets back, it is probably okay to return false here. \n\nI don\u0027t think we need time_elapsed \u003c 0 here since that now \u003c ks-\u003einital is something that should never happen and checking for it here might be more confusing than good.","commit_id":"ff24d26d421c2d878331addc02f3cb9070efbb03"}]}