)]}'
{"id":"openvpn~1297","triplet_id":"openvpn~master~I71e9d4a61d37483685723c16e98f59755694cadf","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-11 16:21:01.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-12 15:54:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I71e9d4a61d37483685723c16e98f59755694cadf","subject":"ssl: change return type of calc_control_channel_frame_overhead to size_t","status":"MERGED","created":"2025-10-24 16:52:30.000000000","updated":"2025-11-12 15:54:29.000000000","submitted":"2025-11-12 15:54:29.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1297-wconversion","meta_rev_id":"04e404c20f25da19e28b19424f91f99d54b3094e","_number":1297,"virtual_id_number":1297,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-24 16:52:35.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-24 16:52:35.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"492b2bcc0232d133ed6ddbaae1ec9b48ab50309a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-24 16:52:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ed7731341b8469c3e5d88cb7f4e956a5aa3da5bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-29 13:13:15.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"7da0b297296f562b49025821f53993e87a915249","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-05 17:40:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"07c17790a0a101ae214df145d7ab6e7a7572f8a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-11 14:26:54.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"373de3647bb4adcc86ae4217e43cd4354071166d","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-11-11 16:21:01.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"04e404c20f25da19e28b19424f91f99d54b3094e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-12 15:54:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"8b0554d988f6bfdefd30620290ec8ff690a37ce2","revisions":{"db4c6580c7f490c0a568ed7ff503b21f902db39e":{"kind":"REWORK","_number":1,"created":"2025-10-24 16:52:30.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1297/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1297/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/1 \u0026\u0026 git checkout -b change-1297 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1297/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2342d2dbf352d400f436885fe9eea963c639ce29","subject":"pkcs11: Avoid some conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:20:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:50:29.000000000","tz":120},"subject":"ssl: change return type of calc_control_channel_frame_overhead to size_t","message":"ssl: change return type of calc_control_channel_frame_overhead to size_t\n\nThis avoids dealing with conversion warnings inside\nthe function. Since we only add values that are\nsupposed to be positive this should be safe.\n\nNote that we now cast the return value to int at\nthe caller side. There we actually substract it and\nwant to catch the case where the result gets negative.\nSince all the involved values are quite small compared\nto INT_MAX I decided to just cast it without further\nchecks.\n\nChange-Id: I71e9d4a61d37483685723c16e98f59755694cadf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a557be7313332f750d9dca6d1979c953d35272e2":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-10-29 13:13:15.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1297/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1297/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/2 \u0026\u0026 git checkout -b change-1297 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1297/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f77a188afa421350f87cffaf29091e88243ef85","subject":"pkcs11: Avoid some conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:20:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-29 13:09:32.000000000","tz":60},"subject":"ssl: change return type of calc_control_channel_frame_overhead to size_t","message":"ssl: change return type of calc_control_channel_frame_overhead to size_t\n\nThis avoids dealing with conversion warnings inside\nthe function. Since we only add values that are\nsupposed to be positive this should be safe.\n\nNote that we now cast the return value to int at\nthe caller side. There we actually substract it and\nwant to catch the case where the result gets negative.\nSince all the involved values are quite small compared\nto INT_MAX I decided to just cast it without further\nchecks.\n\nChange-Id: I71e9d4a61d37483685723c16e98f59755694cadf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"3f6c4f9aa48b3982fd81da5da7b61d70d9546dd8":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-11-05 17:40:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1297/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1297/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/3 \u0026\u0026 git checkout -b change-1297 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1297/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8545a3db4e83d0294d823ad6489a3040de10984e","subject":"init: make some functions static"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:20:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-05 17:38:43.000000000","tz":60},"subject":"ssl: change return type of calc_control_channel_frame_overhead to size_t","message":"ssl: change return type of calc_control_channel_frame_overhead to size_t\n\nThis avoids dealing with conversion warnings inside\nthe function. Since we only add values that are\nsupposed to be positive this should be safe.\n\nNote that we now cast the return value to int at\nthe caller side. There we actually substract it and\nwant to catch the case where the result gets negative.\nSince all the involved values are quite small compared\nto INT_MAX I decided to just cast it without further\nchecks.\n\nChange-Id: I71e9d4a61d37483685723c16e98f59755694cadf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"8b51abba6a56db2abebd3ca1c767f8f587fbb3a5":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-11-11 14:26:54.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/97/1297/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1297/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/4 \u0026\u0026 git checkout -b change-1297 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1297/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e0b68aeeaebeed71b902299c436371ebc83170e","subject":"dco_freebsd.c: fix integer warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:20:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-11 14:17:07.000000000","tz":60},"subject":"ssl: change return type of calc_control_channel_frame_overhead to size_t","message":"ssl: change return type of calc_control_channel_frame_overhead to size_t\n\nThis avoids dealing with conversion warnings inside\nthe function. Since we only add values that are\nsupposed to be positive this should be safe.\n\nNote that we now cast the return value to int at\nthe caller side. There we actually substract it and\nwant to catch the case where the result gets negative.\nSince all the involved values are quite small compared\nto INT_MAX I decided to just cast it without further\nchecks.\n\nChange-Id: I71e9d4a61d37483685723c16e98f59755694cadf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"8b0554d988f6bfdefd30620290ec8ff690a37ce2":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-11-12 15:54:29.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/1297/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1297/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/5 \u0026\u0026 git checkout -b change-1297 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1297/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1297/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"de82ad64735ac230a8ae7ae31a83164bc60b1fcb","subject":"pkcs11: Avoid some conversion warnings"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-11 17:24:31.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-12 15:53:29.000000000","tz":60},"subject":"ssl: change return type of calc_control_channel_frame_overhead to size_t","message":"ssl: change return type of calc_control_channel_frame_overhead to size_t\n\nThis avoids dealing with conversion warnings inside\nthe function. Since we only add values that are\nsupposed to be positive this should be safe.\n\nNote that we now cast the return value to int at\nthe caller side. There we actually substract it and\nwant to catch the case where the result gets negative.\nSince all the involved values are quite small compared\nto INT_MAX I decided to just cast it without further\nchecks.\n\nChange-Id: I71e9d4a61d37483685723c16e98f59755694cadf\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1297\nMessage-Id: \u003c20251111172437.7634-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34326.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}