)]}'
{"id":"openvpn~1299","triplet_id":"openvpn~master~I6bc3147d10ca50291110335cd9fc3be961280c1b","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-16 22:02:26.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-16 22:02:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6bc3147d10ca50291110335cd9fc3be961280c1b","subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","status":"MERGED","created":"2025-10-24 16:52:30.000000000","updated":"2025-11-16 22:02:26.000000000","submitted":"2025-11-16 22:02:26.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1299-wconversion","meta_rev_id":"d2d4550403543477dbdffb50486d0cce08a3a590","_number":1299,"virtual_id_number":1299,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-24 16:52:35.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-24 16:52:35.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-16 18:36:09.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"e574087f019fde30bd4e031a94476af557028c29","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-24 16:52:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6e907a155d4196b5235347ef4604e63ebd24bc9e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-25 07:47:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"411c1c2acd386f63e1aaeb16b44876cbafda0e71","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-29 13:13:15.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"16280de22fe713f1be29ce469f6f3a6cdfa3f2d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-05 17:40:07.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"164e992ea74fa0f2fd767893df8b37d6c6e7db48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-11 14:26:54.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"f9b63b339e58e801eeee36e3c36121307ac27c60","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-16 18:36:09.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"d2d4550403543477dbdffb50486d0cce08a3a590","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-16 22:02:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"0e2fc09d4336bd3e87dfb37123ba4df208b1c048","revisions":{"ab2a6fa1c9b0834305a7d0df18b0e1a6ee389d2b":{"kind":"REWORK","_number":1,"created":"2025-10-24 16:52:30.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/99/1299/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1299/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/1 \u0026\u0026 git checkout -b change-1299 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1299/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0a3e7d21ab758054aa8fdc0fdc92614456e71fc","subject":"ssl: Fix conversion warning in tls_prepend_opcode_v1"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:28:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:51:10.000000000","tz":120},"subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","message":"ssl: Change update argument of compute_earliest_wakeup to time_t\n\nSince we usually input a diff of two time_t values here\nthe input value will be officially time_t. So avoid\nconversion warnings at almost every caller site.\n\nWe can safely cast it to interval_t here because we\nchecked that it is smaller than the interval_t value\nearliest. And all negative values are treated equal,\nso exact value doesn\u0027t matter.\n\nChange-Id: I6bc3147d10ca50291110335cd9fc3be961280c1b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e81c9d0dc7e7cf010dda559dc3a001d16fa3768b":{"kind":"REWORK","_number":2,"created":"2025-10-25 07:47:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/99/1299/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1299/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/2 \u0026\u0026 git checkout -b change-1299 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1299/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c0a3e7d21ab758054aa8fdc0fdc92614456e71fc","subject":"ssl: Fix conversion warning in tls_prepend_opcode_v1"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:28:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-25 07:46:06.000000000","tz":120},"subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","message":"ssl: Change update argument of compute_earliest_wakeup to time_t\n\nSince we usually input a diff of two time_t values here\nthe input value will be officially time_t. So avoid\nconversion warnings at almost every caller site.\n\nWe can safely cast it to interval_t here because we\nchecked that it is smaller than the interval_t value\nearliest. And all negative values are treated equal,\nso exact value doesn\u0027t matter.\n\nChange-Id: I6bc3147d10ca50291110335cd9fc3be961280c1b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"88672341d9e034ee2e6a91f83e2c5676c663bc2e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-10-29 13:13:15.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/99/1299/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1299/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/3 \u0026\u0026 git checkout -b change-1299 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1299/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f119cc0352d4e98dd9bb5e0370d9701c8fe1e4b6","subject":"ssl: Fix conversion warning in tls_prepend_opcode_v1"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:28:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-29 13:09:32.000000000","tz":60},"subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","message":"ssl: Change update argument of compute_earliest_wakeup to time_t\n\nSince we usually input a diff of two time_t values here\nthe input value will be officially time_t. So avoid\nconversion warnings at almost every caller site.\n\nWe can safely cast it to interval_t here because we\nchecked that it is smaller than the interval_t value\nearliest. And all negative values are treated equal,\nso exact value doesn\u0027t matter.\n\nChange-Id: I6bc3147d10ca50291110335cd9fc3be961280c1b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b58e284b69f02875ea140c5964b6e3cc0fcadc7e":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-11-05 17:40:07.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/99/1299/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1299/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/4 \u0026\u0026 git checkout -b change-1299 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1299/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c6a62bc9f872189e9979a2cf2976f2b0c743d9fc","subject":"ssl: Fix conversion warning in tls_prepend_opcode_v1"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:28:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-05 17:38:43.000000000","tz":60},"subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","message":"ssl: Change update argument of compute_earliest_wakeup to time_t\n\nSince we usually input a diff of two time_t values here\nthe input value will be officially time_t. So avoid\nconversion warnings at almost every caller site.\n\nWe can safely cast it to interval_t here because we\nchecked that it is smaller than the interval_t value\nearliest. And all negative values are treated equal,\nso exact value doesn\u0027t matter.\n\nChange-Id: I6bc3147d10ca50291110335cd9fc3be961280c1b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"66d7b043d40aaf047004a80a9c87fc1be8a89cb1":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2025-11-11 14:26:54.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/99/1299/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1299/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/5 \u0026\u0026 git checkout -b change-1299 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1299/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"33310e5bd3a0749918827065b3c9ac77d9a777ab","subject":"ssl: Fix conversion warning in tls_prepend_opcode_v1"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-24 16:28:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-11 14:22:29.000000000","tz":60},"subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","message":"ssl: Change update argument of compute_earliest_wakeup to time_t\n\nSince we usually input a diff of two time_t values here\nthe input value will be officially time_t. So avoid\nconversion warnings at almost every caller site.\n\nWe can safely cast it to interval_t here because we\nchecked that it is smaller than the interval_t value\nearliest. And all negative values are treated equal,\nso exact value doesn\u0027t matter.\n\nChange-Id: I6bc3147d10ca50291110335cd9fc3be961280c1b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0e2fc09d4336bd3e87dfb37123ba4df208b1c048":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2025-11-16 22:02:26.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/99/1299/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1299/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/6 \u0026\u0026 git checkout -b change-1299 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1299/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1299/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d926257bf4636ea43f6f5c25f5235baa25f65203","subject":"ssl: Fix conversion warning in tls_prepend_opcode_v1"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-16 18:36:15.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-16 21:58:37.000000000","tz":60},"subject":"ssl: Change update argument of compute_earliest_wakeup to time_t","message":"ssl: Change update argument of compute_earliest_wakeup to time_t\n\nSince we usually input a diff of two time_t values here\nthe input value will be officially time_t. So avoid\nconversion warnings at almost every caller site.\n\nWe can safely cast it to interval_t here because we\nchecked that it is smaller than the interval_t value\nearliest. And all negative values are treated equal,\nso exact value doesn\u0027t matter.\n\nChange-Id: I6bc3147d10ca50291110335cd9fc3be961280c1b\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1299\nMessage-Id: \u003c20251116183622.11727-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34482.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}