)]}'
{"id":"openvpn~1305","triplet_id":"openvpn~release%2F2.6~I5b6881dc73358c8d1249ee2ceb968ede295105b0","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000035":{"account":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"last_update":"2025-10-27 10:02:43.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-27 10:02:43.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-27 10:02:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5b6881dc73358c8d1249ee2ceb968ede295105b0","subject":"ssl_mbedtls: fix missing perf_pop() call","status":"MERGED","created":"2025-10-26 14:32:56.000000000","updated":"2025-10-27 10:02:43.000000000","submitted":"2025-10-27 10:02:43.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1305","meta_rev_id":"24746e81776da03e2aae165321d0e4f15f57fd91","_number":1305,"virtual_id_number":1305,"owner":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-26 14:32:56.000000000","updated_by":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-26 14:32:56.000000000","updated_by":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-26 14:32:56.000000000","updated_by":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-26 14:35:06.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"d5de7344e96867b97d2f8885c56ddacd5dd8cc3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"date":"2025-10-26 14:32:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8d237f3b2e93a453a1bbc0e18bf6a3dc736cd3e9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-26 14:35:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"24746e81776da03e2aae165321d0e4f15f57fd91","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-27 10:02:43.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e83c63f58135913bb2ca2f4345da8cd77098474b","revisions":{"beb0b7addbe84e1ebe1d18f009dc19f1097fa787":{"kind":"REWORK","_number":1,"created":"2025-10-26 14:32:56.000000000","uploader":{"_account_id":1000035,"name":"syzzer","display_name":"Steffan Karger","email":"steffan@karger.me","username":"syzzer","status":"Commits and comments are my own views, not those of my employer."},"ref":"refs/changes/05/1305/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/05/1305/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/1 \u0026\u0026 git checkout -b change-1305 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/05/1305/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0848531640f670f7f6bb79833223ac8a05c1b36e","subject":"Do not try to use the encrypt-then-mac ciphers from OpenSSL 3.6.0"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2025-10-26 14:20:20.000000000","tz":60},"committer":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2025-10-26 14:32:12.000000000","tz":60},"subject":"ssl_mbedtls: fix missing perf_pop() call","message":"ssl_mbedtls: fix missing perf_pop() call\n\nThis was triggered by a bug report submitted by Joshua Rogers, who\nused ZeroPath to discover we missed a perf_pop() call in one of the\nerror paths of ssl_mbedtls.c.\n\nMove an existing perf_pop call a bit upwards to fix that.\n\nThe perf code is always disabled by ENABLE_PERFORMANCE_METRICS being\ncommented out in perf.h. There is no configure flag. None of the active\ndevelopers remembers using it and the git log shows no actual code changes\nsince at least the project structure overhaul of 2012. So this has no\nreal-world impact.\n\nChange-Id: I5b6881dc73358c8d1249ee2ceb968ede295105b0\nSigned-off-by: Steffan Karger \u003csteffan@karger.me\u003e\n"},"branch":"refs/heads/release/2.6"},"e83c63f58135913bb2ca2f4345da8cd77098474b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-10-27 10:02:43.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/05/1305/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/05/1305/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/2 \u0026\u0026 git checkout -b change-1305 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/05/1305/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/05/1305/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0848531640f670f7f6bb79833223ac8a05c1b36e","subject":"Do not try to use the encrypt-then-mac ciphers from OpenSSL 3.6.0"}],"author":{"name":"Steffan Karger","email":"steffan@karger.me","date":"2025-10-26 14:35:14.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-27 09:45:50.000000000","tz":60},"subject":"ssl_mbedtls: fix missing perf_pop() call","message":"ssl_mbedtls: fix missing perf_pop() call\n\nThis was triggered by a bug report submitted by Joshua Rogers, who\nused ZeroPath to discover we missed a perf_pop() call in one of the\nerror paths of ssl_mbedtls.c.\n\nMove an existing perf_pop call a bit upwards to fix that.\n\nThe perf code is always disabled by ENABLE_PERFORMANCE_METRICS being\ncommented out in perf.h. There is no configure flag. None of the active\ndevelopers remembers using it and the git log shows no actual code changes\nsince at least the project structure overhaul of 2012. So this has no\nreal-world impact.\n\nChange-Id: I5b6881dc73358c8d1249ee2ceb968ede295105b0\nSigned-off-by: Steffan Karger \u003csteffan@karger.me\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1305\nMessage-Id: \u003c20251026143521.13291-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33870.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}