)]}'
{"id":"openvpn~1306","triplet_id":"openvpn~master~I92804da010bab36cd0326759c04f955f2bda74de","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-30 21:14:37.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-30 21:14:37.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-10-30 21:14:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I92804da010bab36cd0326759c04f955f2bda74de","subject":"iservice: check return value of MultiByteToWideChar","status":"MERGED","created":"2025-10-26 16:30:09.000000000","updated":"2025-10-30 21:14:37.000000000","submitted":"2025-10-30 21:14:37.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1306","meta_rev_id":"9a2c6cc54a27b21b59ce8c2f8632c4e37681fc14","_number":1306,"virtual_id_number":1306,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-26 16:30:09.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-26 16:30:09.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-26 16:30:09.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-30 19:47:23.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"deebc88a2b8a4733324f8148185b12ef6ff36d59","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-10-26 16:30:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"02732904d79032af0d19f6b3dfc931df6d2fd3fc","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 19:47:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9a2c6cc54a27b21b59ce8c2f8632c4e37681fc14","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 21:14:37.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fdd4072541ba52e297c19672d3b1e7021d14bc91","revisions":{"54b4f5d903803d9a658ca7b929a06f0664628951":{"kind":"REWORK","_number":1,"created":"2025-10-26 16:30:09.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/06/1306/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1306/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/1 \u0026\u0026 git checkout -b change-1306 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1306/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0abf6e716b5a50b2b7f4287b1d50f4889eed36aa","subject":"multi: Fix wrong usage of mroute_extract_openvpn_sockaddr"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-10-26 16:19:51.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-10-26 16:19:51.000000000","tz":60},"subject":"iservice: check return value of MultiByteToWideChar","message":"iservice: check return value of MultiByteToWideChar\n\nIf the first call to MultiByteToWideChar returns 0, something must have\nfailed, because it returns the required buffer size including the\nterminating zero. When it does return 0, just return NULL and indicate\nthat the call to utf8to16(_size) failed.\n\nFound by ZeroPath.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nChange-Id: I92804da010bab36cd0326759c04f955f2bda74de\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"fdd4072541ba52e297c19672d3b1e7021d14bc91":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-10-30 21:14:37.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/06/1306/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1306/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/2 \u0026\u0026 git checkout -b change-1306 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1306/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1306/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9fa32e66c9ec66ca05704f8e8b2fd9db7c711c50","subject":"Ensure that get_sigtype always return non-NULL"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-10-30 19:47:31.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-30 21:06:43.000000000","tz":60},"subject":"iservice: check return value of MultiByteToWideChar","message":"iservice: check return value of MultiByteToWideChar\n\nIf the first call to MultiByteToWideChar returns 0, something must have\nfailed, because it returns the required buffer size including the\nterminating zero. When it does return 0, just return NULL and indicate\nthat the call to utf8to16(_size) failed.\n\nFound by ZeroPath.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nChange-Id: I92804da010bab36cd0326759c04f955f2bda74de\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1306\nMessage-Id: \u003c20251030194736.2151-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34071.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}