)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f55686ddb7a793d4bb2652e6067c6958e6478444","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3bbe1a92_5ca4e5c8","updated":"2025-10-28 19:28:36.000000000","message":"This fails the integer checks on a windows build\n\n```\noC:\\Buildbot\\windows-server-2025-latent-ec2-msbuild-x86-clang\\build\\src\\openvpnserv\\interactive.c(3197,47): error : incompatible pointer to integer conversion passing \u0027LPVOID\u0027 (aka \u0027void *\u0027) to parameter of type \u0027int\u0027 [-Wint-conversion] [C:\\Buildbot\\windows-server-2025-latent-ec2-msbuild-x86-clang\\build\\out\\build\\win-x86-clang-release\\src\\openvpnserv\\openvpnserv.vcxproj]\no  C:\\Buildbot\\windows-server-2025-latent-ec2-msbuild-x86-clang\\build\\src\\openvpnserv\\interactive.c(1007,43): note: passing argument to parameter \u0027if_index\u0027 here\n```","commit_id":"9620609432b79969802f9163c2407b7fb565711f"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"5be85cac0e0650887543f875863d433a91989ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f0ec401_dfaf31c2","in_reply_to":"3bbe1a92_5ca4e5c8","updated":"2025-10-30 08:17:09.000000000","message":"Done","commit_id":"9620609432b79969802f9163c2407b7fb565711f"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"69306d7265d3f382d8b473cb9ceb2e0666d40b94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7b1e63b_c2726872","updated":"2025-10-30 08:31:07.000000000","message":"Built and tested, works as expected.","commit_id":"58c98605b12b096c2d4f1efe6ee38a63d36cc013"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"b538b79770a439717d06c2d3217d0bc49d380211","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25e7ea97_98463656","updated":"2025-10-30 08:18:11.000000000","message":"my concerns have been addressed, thanks","commit_id":"58c98605b12b096c2d4f1efe6ee38a63d36cc013"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"2e88fb0159de91c1b727a1a64ff1bf7eff550a01","unresolved":true,"context_lines":[{"line_number":2907,"context_line":"        {"},{"line_number":2908,"context_line":"            goto out;"},{"line_number":2909,"context_line":"        }"},{"line_number":2910,"context_line":"        free(RemoveListItem(\u0026(*lists)[undo_wins], CmpAny, NULL));"},{"line_number":2911,"context_line":"    }"},{"line_number":2912,"context_line":""},{"line_number":2913,"context_line":"    if (addr_len \u003d\u003d 0 || msg-\u003eheader.type \u003d\u003d msg_del_wins_cfg)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"08e6deb9_153f7b37","line":2910,"updated":"2025-10-30 07:40:50.000000000","message":"Since we removed the only invocation of CmpWString, clang complains that\n\nC:\\Users\\lev\\Projects\\openvpn-build\\src\\openvpn\\src\\openvpnserv\\interactive.c(1055,1): error : unused function \u0027CmpWString\u0027 [-Werror,-Wunused-function] [C:\\Users\\lev\\Projects\\openvpn-build\\src\\openvpn\\out\\build\\win-amd64-clang-debug\\src\\openvpnserv\\openvpnserv.vcxproj]","commit_id":"808293d5c8d20d3cf00b3a83e16e343149cfc367"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"5be85cac0e0650887543f875863d433a91989ba0","unresolved":false,"context_lines":[{"line_number":2907,"context_line":"        {"},{"line_number":2908,"context_line":"            goto out;"},{"line_number":2909,"context_line":"        }"},{"line_number":2910,"context_line":"        free(RemoveListItem(\u0026(*lists)[undo_wins], CmpAny, NULL));"},{"line_number":2911,"context_line":"    }"},{"line_number":2912,"context_line":""},{"line_number":2913,"context_line":"    if (addr_len \u003d\u003d 0 || msg-\u003eheader.type \u003d\u003d msg_del_wins_cfg)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"96f4a51f_2599d222","line":2910,"in_reply_to":"08e6deb9_153f7b37","updated":"2025-10-30 08:17:09.000000000","message":"Done","commit_id":"808293d5c8d20d3cf00b3a83e16e343149cfc367"}]}
