)]}'
{"id":"openvpn~1316","triplet_id":"openvpn~master~Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-31 10:07:35.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-31 10:07:35.000000000","reason":"Change was submitted"},"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-10-31 10:07:35.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9","subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","status":"MERGED","created":"2025-10-27 16:06:40.000000000","updated":"2025-10-31 10:07:35.000000000","submitted":"2025-10-31 10:07:35.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1316","meta_rev_id":"d92377b3b44ac8b09009979deb3c49f49ea79bc3","_number":1316,"virtual_id_number":1316,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-27 16:06:41.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-27 16:06:41.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-27 16:06:41.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-30 19:52:27.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"bc8c1f94a97c5dbff56ee71fbbc7ea239bb26db3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-27 16:06:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"00cac86cbc4ce4f09bc74f0ab54f2e2e564a5882","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-28 10:39:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"48e8e7d7d0c915449d28c2de85ea7779f43eaa88","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-28 10:45:04.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"93fee6bc811e4840b1e773a138ec3a8a7361db61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-28 19:28:21.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f6c019d88843351e2e104bddbfab5678ba3c5572","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-28 19:52:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a219686cdd6f1e1a2aa3043321293effcc68b2a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-29 08:20:44.000000000","message":"Patch Set 3: Commit message was updated.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c56ce5bc4b9e2921fcea956a86bff77895fc0981","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-29 12:53:35.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"a0292f94b2271831470d3b2e894bae239662ee24","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-29 13:18:20.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"6e3b054869296a4e9a565c9d18f098976ccec916","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-29 13:18:55.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"58bb3a644ffa1ebf67eeb670606065efc97248df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-29 14:00:52.000000000","message":"Patch Set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"efc005ed01bcf20d14b87d0431897b5c0bbe9e28","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-29 14:03:33.000000000","message":"Patch Set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"9e725442054d65163ef5dd94bca104aa2c2f0c6e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 19:52:27.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"d92377b3b44ac8b09009979deb3c49f49ea79bc3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-31 10:07:35.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"6b0208e962aadf285ecc7ab47cc973a9018e3f24","revisions":{"ade27bc84b275f28caf2e175c9b035418c5062a6":{"kind":"REWORK","_number":1,"created":"2025-10-27 16:06:40.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/16/1316/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/1 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a8b8e41c7906c895ba6c88aa748e6dfa3946aff5","subject":"push_util: Fix conversion warnings"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 15:48:34.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 16:03:27.000000000","tz":60},"subject":"PUSH_UPDATE server: added new unit tests and improved documentation","message":"PUSH_UPDATE server: added new unit tests and improved documentation\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"71ca94c1bc097daf503c6ffedb74b2dd2e3c3ac8":{"kind":"REWORK","_number":2,"created":"2025-10-28 19:28:21.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/16/1316/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/2 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15b77d47f5a9dc78615cdafc50bbb05d5a21c3d6","subject":"gremlin: Avoid some conversion warnings"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 15:48:34.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-28 19:09:50.000000000","tz":60},"subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","message":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements\n\nThe number of messages calculated before the call to message_splitter(), used\nin the memory allocation in the buffer array, could in certain cases be less\nthan one than the actual number of messages, thus causing an override of the\nsentinel buffer in message_splitter and therefore an invalid read in\nsend_single_push_update(). The case in question would be, for example, a\nsequence of three options \"A, B, C\" with the size of B equal to safe_cap - 1\nand the sum of the sizes of A and C less than safe_cap - 2.\nThe buffer array was therefore replaced with a list of buffers to completely\navoid calculating the number of messages before it was actually computed.\nThe test case in question has been added to the unit tests.\nThe unit tests have been improved using cmocka macros.\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"48667df4fd782798311283b9c6066bc6e984c91b":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-10-29 08:20:44.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/16/1316/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/3 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15b77d47f5a9dc78615cdafc50bbb05d5a21c3d6","subject":"gremlin: Avoid some conversion warnings"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 15:48:34.000000000","tz":60},"committer":{"name":"mrbff","email":"marco@mandelbit.com","date":"2025-10-29 08:20:44.000000000","tz":0},"subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","message":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements\n\nThe number of messages calculated before the call to message_splitter(), used in the memory allocation in the buffer array, could in certain cases be less than one than the actual number of messages, thus causing an override of the sentinel buffer in message_splitter() and therefore an invalid read in send_single_push_update().\nThe case in question would be, for example, a sequence of three options \"A, B, C\" with the size of B equal to safe_cap - 1 and the sum of the sizes of A and C less than safe_cap - 2.\n\nThe buffer array was therefore replaced with a list of buffers to completely avoid calculating the number of messages before it was actually computed.\nThe test case in question has been added to the unit tests.\nThe unit tests have been improved using cmocka macros.\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"bfbb5f2e17bce9137426f04b40b31da63ebc3dc9":{"kind":"REWORK","_number":4,"created":"2025-10-29 13:18:20.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/16/1316/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/4 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f938d991a8222bb3304865f2cd7b368d7f8a9224","subject":"Install host routes for out-of-subnet ifconfig-push addresses when DCO is enabled"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 15:48:34.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-29 13:17:56.000000000","tz":60},"subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","message":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements\n\nThe number of messages calculated before the call to message_splitter(), used\nin the memory allocation in the buffer array, could in certain cases be less\nthan one than the actual number of messages, thus causing an override of the\nsentinel buffer in message_splitter and therefore an invalid read in\nsend_single_push_update(). The case in question would be, for example, a\nsequence of three options \"A, B, C\" with the size of B equal to safe_cap - 1\nand the sum of the sizes of A and C less than safe_cap - 2.\nThe buffer array was therefore replaced with a list of buffers to completely\navoid calculating the number of messages before it was actually computed.\nThe test case in question has been added to the unit tests.\nThe unit tests have been improved using cmocka macros.\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"f94a2ece622e69b925a0ee5dd5f662234758d63b":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-10-29 14:00:52.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/16/1316/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/5 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f938d991a8222bb3304865f2cd7b368d7f8a9224","subject":"Install host routes for out-of-subnet ifconfig-push addresses when DCO is enabled"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 15:48:34.000000000","tz":60},"committer":{"name":"mrbff","email":"marco@mandelbit.com","date":"2025-10-29 14:00:52.000000000","tz":0},"subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","message":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements\n\nThe number of messages calculated before the call to message_splitter(), used\nin the memory allocation in the buffer array, could in certain cases be less\nthan one than the actual number of messages, thus causing an override of the\nsentinel buffer in message_splitter and therefore an invalid read in\nsend_single_push_update(). The case in question would be, for example, a\nsequence of three options \"A,B,C\" with the size of B equal to safe_cap - 1\nand the sum of the sizes of A and C less than safe_cap - 2.\nThe buffer array was therefore replaced with a list of buffers to completely\navoid calculating the number of messages before it was actually computed.\nThe test case in question has been added to the unit tests.\nThe unit tests have been improved using cmocka macros.\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"3a6f01f8eeaf0be9371c92f281bb1f5c70a61ed8":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2025-10-29 14:03:33.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/16/1316/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/6 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f938d991a8222bb3304865f2cd7b368d7f8a9224","subject":"Install host routes for out-of-subnet ifconfig-push addresses when DCO is enabled"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-27 15:48:34.000000000","tz":60},"committer":{"name":"mrbff","email":"marco@mandelbit.com","date":"2025-10-29 14:03:33.000000000","tz":0},"subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","message":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements\n\nThe number of messages calculated before the call to message_splitter(),\nused in the memory allocation in the buffer array, could in certain\ncases be less than one than the actual number of messages, thus causing\nan override of the sentinel buffer in message_splitter() and therefore\nan invalid read in send_single_push_update().\nThe case in question would be, for example, a sequence of three options\n\"A,B,C\" with the size of B equal to safe_cap - 1 and the sum of the\nsizes of A and C less than safe_cap - 2.\n\nThe buffer array was therefore replaced with a list of buffers to\ncompletely avoid calculating the number of messages before it was\nactually computed.\nThe test case in question has been added to the unit tests.\nThe unit tests have been improved using cmocka macros.\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"6b0208e962aadf285ecc7ab47cc973a9018e3f24":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":7,"created":"2025-10-31 10:07:35.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/16/1316/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1316/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/7 \u0026\u0026 git checkout -b change-1316 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1316/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1316/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5e6b72460af88c4d2820195d1a5df62358c41e1","subject":"Add -lpathcch for mingw32 builds using autotools"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-30 19:52:35.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-31 09:51:47.000000000","tz":60},"subject":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements","message":"PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements\n\nThe number of messages calculated before the call to message_splitter(),\nused in the memory allocation in the buffer array, could in certain\ncases be less than one than the actual number of messages, thus causing\nan override of the sentinel buffer in message_splitter() and therefore\nan invalid read in send_single_push_update().\nThe case in question would be, for example, a sequence of three options\n\"A,B,C\" with the size of B equal to safe_cap - 1 and the sum of the\nsizes of A and C less than safe_cap - 2.\n\nThe buffer array was therefore replaced with a list of buffers to\ncompletely avoid calculating the number of messages before it was\nactually computed.\nThe test case in question has been added to the unit tests.\nThe unit tests have been improved using cmocka macros.\n\nChange-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1316\nMessage-Id: \u003c20251030195244.2659-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34073.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}