)]}'
{"id":"openvpn~1326","triplet_id":"openvpn~master~I6c502508026c6b85bb092ada4d16d985b20dd41f","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-30 20:55:50.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-30 20:55:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6c502508026c6b85bb092ada4d16d985b20dd41f","subject":"clean up environment variable handling in verify_user_pass_script","status":"MERGED","created":"2025-10-29 13:17:13.000000000","updated":"2025-10-30 20:55:50.000000000","submitted":"2025-10-30 20:55:50.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1326","meta_rev_id":"e4974d7d942c1e905ebdddd172a384b15c65a4c1","_number":1326,"virtual_id_number":1326,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-29 13:17:14.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-29 13:17:14.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-30 19:43:48.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1912ba1d4c11a6cd5ee45052766d9d45dcd295c1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-29 13:17:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"799e78b1ef06ca5b6f67b40b01b6ad7fc3a380e7","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 19:43:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e4974d7d942c1e905ebdddd172a384b15c65a4c1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 20:55:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3fbba254b8645d2d1241e59f6ebd05e85ce05b52","revisions":{"e1bb644952e9b53dc483af962de0e402c8e030b3":{"kind":"REWORK","_number":1,"created":"2025-10-29 13:17:13.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/26/1326/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/26/1326/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/1 \u0026\u0026 git checkout -b change-1326 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/26/1326/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f938d991a8222bb3304865f2cd7b368d7f8a9224","subject":"Install host routes for out-of-subnet ifconfig-push addresses when DCO is enabled"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-29 13:12:22.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-29 13:16:42.000000000","tz":60},"subject":"clean up environment variable handling in verify_user_pass_script","message":"clean up environment variable handling in verify_user_pass_script\n\nThe username environment variable is already set by the\nset_verify_user_pass_env function before the verify_user_pass_script\nfunction is called, so this call is not doing anything but might erroneously\nmade people think that this needs to be cleaned up.\n\nAlso ensure that the password is clean from the env even in an error case.\n\nReported-by: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\nChange-Id: I6c502508026c6b85bb092ada4d16d985b20dd41f\n"},"branch":"refs/heads/master"},"3fbba254b8645d2d1241e59f6ebd05e85ce05b52":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-10-30 20:55:50.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/26/1326/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/26/1326/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/2 \u0026\u0026 git checkout -b change-1326 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/26/1326/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1326/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cd4cac16555904ea8a8edcf0b669efb34f478609","subject":"manage: Change kill_by_addr to use better types for port/proto"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-30 19:43:56.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-30 20:54:16.000000000","tz":60},"subject":"clean up environment variable handling in verify_user_pass_script","message":"clean up environment variable handling in verify_user_pass_script\n\nThe username environment variable is already set by the\nset_verify_user_pass_env function before the verify_user_pass_script\nfunction is called, so this call is not doing anything but might erroneously\nmade people think that this needs to be cleaned up.\n\nAlso ensure that the password is clean from the env even in an error case.\n\nReported-by: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\nChange-Id: I6c502508026c6b85bb092ada4d16d985b20dd41f\nSigned-off-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1326\nMessage-Id: \u003c20251030194402.1729-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34069.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}