)]}'
{"id":"openvpn~1330","triplet_id":"openvpn~master~I830b6b27fc3efe707e103ba629c4bfe3796a9cbe","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-30 21:03:52.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-30 21:03:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I830b6b27fc3efe707e103ba629c4bfe3796a9cbe","subject":"Ensure return value of snprintf is correctly checked","status":"MERGED","created":"2025-10-29 16:49:47.000000000","updated":"2025-10-30 21:03:52.000000000","submitted":"2025-10-30 21:03:52.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1330","meta_rev_id":"69a689e5eaa31af2b4c772000597e7283d0a53f7","_number":1330,"virtual_id_number":1330,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-10-29 16:49:48.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-10-29 16:49:48.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-10-30 19:36:19.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"5c74942dd24fefe43d0ae571c48b6d24885df55a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-10-29 16:49:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c8626bda86d13c5e7720f9337d3f4148443c3e3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 19:36:19.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"69a689e5eaa31af2b4c772000597e7283d0a53f7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-30 21:03:52.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d7f86ddaf403aafa4a6098d02d76910a821b038e","revisions":{"64e713b91625498979ed89cb2ea627de94f17775":{"kind":"REWORK","_number":1,"created":"2025-10-29 16:49:47.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/30/1330/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/30/1330/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/1 \u0026\u0026 git checkout -b change-1330 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/30/1330/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f938d991a8222bb3304865f2cd7b368d7f8a9224","subject":"Install host routes for out-of-subnet ifconfig-push addresses when DCO is enabled"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-29 16:47:09.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-29 16:49:38.000000000","tz":60},"subject":"Ensure return value of snprintf is correctly checked","message":"Ensure return value of snprintf is correctly checked\n\nCommit 130548fe4d change the usages of openvpn_snprintf to snprintf. When\ndoing that conversion I did not notice that, despite the function name,\nopenvpn_snprintf had a different semantic for the return value.\n\nThis commit goes through all the usages of snprintf and ensures that\nthe return is correctly checked for overruns.\n\nReported-by: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\nChange-Id: I830b6b27fc3efe707e103ba629c4bfe3796a9cbe\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"d7f86ddaf403aafa4a6098d02d76910a821b038e":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-10-30 21:03:52.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/30/1330/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/30/1330/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/2 \u0026\u0026 git checkout -b change-1330 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/30/1330/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/30/1330/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e7df832354fd476defe6a0fb35ab1aa05314c5e3","subject":"Fix warnings about conversion from int to unsigned char/uint8_t"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-10-30 19:36:30.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-30 21:01:54.000000000","tz":60},"subject":"Ensure return value of snprintf is correctly checked","message":"Ensure return value of snprintf is correctly checked\n\nCommit 130548fe4d change the usages of openvpn_snprintf to snprintf. When\ndoing that conversion I did not notice that, despite the function name,\nopenvpn_snprintf had a different semantic for the return value.\n\nThis commit goes through all the usages of snprintf and ensures that\nthe return is correctly checked for overruns.\n\nReported-by: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\nChange-Id: I830b6b27fc3efe707e103ba629c4bfe3796a9cbe\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1330\nMessage-Id: \u003c20251030193638.1010-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34063.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}