)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"d969accd7dce217b7a1262bb7789ddc6d141013d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"beae0983_310bdd11","updated":"2025-11-03 08:30:53.000000000","message":"Why not https://learn.microsoft.com/en-us/windows/win32/api/pathcch/nf-pathcch-pathcchaddbackslashex ?","commit_id":"45000107a7752f9514803b8f8f6c750e3d96b84c"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d7371654e22ebccc3a6e8836864221893ecd7063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4f492bc7_2d1c929b","updated":"2025-11-07 08:14:42.000000000","message":"does not compile on windows","commit_id":"ee74e95b10c50f19e22e19edfc6648451ada6a5a"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"7e899f2ec71f75993fe1aab55b347d3bbf102472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cd1f5cc1_a162adfd","updated":"2025-11-07 22:44:21.000000000","message":"It still fails compilation... googling for the error message led me here\n\nhttps://stackoverflow.com/questions/4845198/fatal-error-no-target-architecture-in-visual-studio\n\nwhich reads as if windows header files need to come after \u003cwindows.h\u003e, never standalone.","commit_id":"b7688be6510e36e9bf80dab41e6a630842bf6328"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"222f4adc7e1fc67ba552c87c88265568e3da1daa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"350d569d_9552d3f3","in_reply_to":"cd1f5cc1_a162adfd","updated":"2025-11-07 22:47:50.000000000","message":"Builds fine when cross-compiling with mingw 🤌","commit_id":"b7688be6510e36e9bf80dab41e6a630842bf6328"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"90887c796677cdf6a19ccbb1ee9fd683697f08ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"83c0ba7c_d88a4212","updated":"2025-11-09 15:25:21.000000000","message":"LGTM","commit_id":"05d728d64b276eff643b41d12332b64c6345dd56"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"c97039eda6c6fadb64707d2d0c825a6fc52e2b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f774e964_ee966e19","updated":"2025-11-08 10:27:30.000000000","message":"my concerns have been addressed, thanks.","commit_id":"05d728d64b276eff643b41d12332b64c6345dd56"}],"src/openvpnserv/common.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d7371654e22ebccc3a6e8836864221893ecd7063","unresolved":true,"context_lines":[{"line_number":68,"context_line":"ensure_trailing_backslash(PWSTR dir, size_t size)"},{"line_number":69,"context_line":"{"},{"line_number":70,"context_line":"    HRESULT res \u003d PathCchAddBackslash(dir, size);"},{"line_number":71,"context_line":"    return res \u003d\u003d S_OK || res \u003d\u003d S_FALSE ? TRUE : FALSE;"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"5866c2c1_a20cb45c","line":71,"updated":"2025-11-07 08:14:42.000000000","message":"please use braces here so it\u0027s clear to the casual reader what part of the boolean goes into the ternary operator","commit_id":"ee74e95b10c50f19e22e19edfc6648451ada6a5a"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"706426423c082bb210ce6ced896497f79aef9516","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ensure_trailing_backslash(PWSTR dir, size_t size)"},{"line_number":69,"context_line":"{"},{"line_number":70,"context_line":"    HRESULT res \u003d PathCchAddBackslash(dir, size);"},{"line_number":71,"context_line":"    return res \u003d\u003d S_OK || res \u003d\u003d S_FALSE ? TRUE : FALSE;"},{"line_number":72,"context_line":"}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"a2b062ca_547b7ce3","line":71,"in_reply_to":"5866c2c1_a20cb45c","updated":"2025-11-07 23:46:48.000000000","message":"Done","commit_id":"ee74e95b10c50f19e22e19edfc6648451ada6a5a"}]}