)]}'
{"id":"openvpn~1342","triplet_id":"openvpn~master~Ie153b3d5bf19200f225cd09131de8583645110be","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-03 15:33:25.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-03 14:35:08.000000000","reason":"removed on reply"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-11-03 15:33:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie153b3d5bf19200f225cd09131de8583645110be","subject":"test_networking: use appropriate assert helpers","status":"MERGED","created":"2025-11-03 14:26:31.000000000","updated":"2025-11-03 15:33:25.000000000","submitted":"2025-11-03 15:33:25.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1342","meta_rev_id":"71892ff514226dc76f186085f67537f33bdeac87","_number":1342,"virtual_id_number":1342,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-03 14:26:31.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-03 14:26:31.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-03 14:26:31.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"f22aa6cb642e92364a20f3bcb0bce6d673273fcd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-11-03 14:26:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"76c09cdcded2efee1b203af8e5d835d489972a26","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-03 14:35:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"71892ff514226dc76f186085f67537f33bdeac87","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-03 15:33:25.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"21b943734f1911a158b7b465d11a04bb6de7f1a8","revisions":{"6ed4190fff7691564e741ecbc06dd07f08a72f50":{"kind":"REWORK","_number":1,"created":"2025-11-03 14:26:31.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/42/1342/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1342/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/1 \u0026\u0026 git checkout -b change-1342 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1342/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"40b29347c05e969dc2d23223a426ce652b123589","subject":"manage: Correctly handle port 65535 in man_kill"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-11-03 14:23:38.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-11-03 14:25:54.000000000","tz":60},"subject":"test_networking: use appropriate assert helpers","message":"test_networking: use appropriate assert helpers\n\nInall unit tests we rely on CMocka\u0027s provided assert\nhelpers.\nHowever, test_networking.c was still on the default\nassert() call, which we try to avoid in favour of more\nappropriate helpers.\n\nSubstitute them all with assert_*() from CMocka.\n\nChange-Id: Ie153b3d5bf19200f225cd09131de8583645110be\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"21b943734f1911a158b7b465d11a04bb6de7f1a8":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-11-03 15:33:25.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/42/1342/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/1342/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/2 \u0026\u0026 git checkout -b change-1342 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/1342/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/1342/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a3d8c40260930ab82ca5d9d71796a7763e74a03d","subject":"openvpnserv: Disallow stdin as config unless user is authorized"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-11-03 14:58:37.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-03 15:31:59.000000000","tz":60},"subject":"test_networking: use appropriate assert helpers","message":"test_networking: use appropriate assert helpers\n\nIn all unit tests we rely on CMocka\u0027s provided assert helpers.\n\nHowever, test_networking.c was still on the default assert() call,\nwhich we try to avoid in favour of more appropriate helpers.\n\nSubstitute them all with assert_*() from CMocka.\n\nChange-Id: Ie153b3d5bf19200f225cd09131de8583645110be\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1342\nMessage-Id: \u003c20251103145842.22969-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34155.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}