)]}'
{"id":"openvpn~1345","triplet_id":"openvpn~master~I61e4968f2e83d12d4d3fc3ccba92a06eb5ed5866","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-04 08:19:57.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-04 08:19:57.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-11-04 08:19:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I61e4968f2e83d12d4d3fc3ccba92a06eb5ed5866","subject":"unit_tests: prefer proper cmocka assert helpers","status":"MERGED","created":"2025-11-03 23:49:59.000000000","updated":"2025-11-04 08:19:57.000000000","submitted":"2025-11-04 08:19:57.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1345","meta_rev_id":"dc0a1d1197ca661810f3b48bfe55a09a775f5ff4","_number":1345,"virtual_id_number":1345,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-03 23:50:00.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-03 23:50:00.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-03 23:50:00.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-04 08:16:25.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"b458b5943e7d93b314060a42a5434e4cd047dd48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-11-03 23:49:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8d0804b600c7ecf7e00096c633750c09c188b78f","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-04 08:16:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"dc0a1d1197ca661810f3b48bfe55a09a775f5ff4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-04 08:19:57.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c5e9950987b153ff572484bdf895b56c5dcc03dd","revisions":{"fe9c6df2f5adee6ac7ffb8bba8ce71b9919a18b2":{"kind":"REWORK","_number":1,"created":"2025-11-03 23:49:59.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/45/1345/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/1345/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/1 \u0026\u0026 git checkout -b change-1345 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/1345/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21b943734f1911a158b7b465d11a04bb6de7f1a8","subject":"test_networking: use appropriate assert helpers"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-11-03 23:44:42.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-11-03 23:47:23.000000000","tz":60},"subject":"unit_tests: prefer proper cmocka assert helpers","message":"unit_tests: prefer proper cmocka assert helpers\n\nWe have agreed to never use the plain assert()\nanywhere in the code.\n\nUnit tests are almost there as they always use\ncmocka provided assert helpers, except for two cases.\nConvert those two to cmocka assert calls too.\n\nWhile at it also ensure that the proper bool helpers\nare used rather than checking _int_equal against true/false.\n\nDrop assert.h in cryptoapi.c as well as it\u0027s not needed\nanymore.\n\nGitHub: Closes OpenVPN/openvpn#894\nChange-Id: I61e4968f2e83d12d4d3fc3ccba92a06eb5ed5866\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"c5e9950987b153ff572484bdf895b56c5dcc03dd":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-11-04 08:19:57.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/45/1345/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/1345/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/2 \u0026\u0026 git checkout -b change-1345 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/1345/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1345/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"59fed2ad127bda2986f4c70d128453740ca63d34","subject":"Use correct undo_list when clearing DNS addresses"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-11-04 08:16:47.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-04 08:18:56.000000000","tz":60},"subject":"unit_tests: prefer proper cmocka assert helpers","message":"unit_tests: prefer proper cmocka assert helpers\n\nWe have agreed to never use the plain assert()\nanywhere in the code.\n\nUnit tests are almost there as they always use\ncmocka provided assert helpers, except for two cases.\nConvert those two to cmocka assert calls too.\n\nWhile at it also ensure that the proper bool helpers\nare used rather than checking _int_equal against true/false.\n\nDrop assert.h in cryptoapi.c as well as it\u0027s not needed\nanymore.\n\nGitHub: Closes OpenVPN/openvpn#894\nChange-Id: I61e4968f2e83d12d4d3fc3ccba92a06eb5ed5866\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1345\nMessage-Id: \u003c20251104081653.3368-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34179.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}