)]}'
{"id":"openvpn~1348","triplet_id":"openvpn~master~Id0bb4c45d373437ab8dbaff7a311745f9b538cbf","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-12-10 11:02:56.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2025-12-10 11:02:56.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-12-10 10:48:24.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-12-10 11:02:56.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Id0bb4c45d373437ab8dbaff7a311745f9b538cbf","subject":"mudp: fix unaligned 32-bit read when parsing peer ID","status":"MERGED","created":"2025-11-04 15:58:29.000000000","updated":"2025-12-10 11:02:56.000000000","submitted":"2025-12-10 11:02:56.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1348","meta_rev_id":"18fcb95cc0c724ba287fd94a11a9da3fb00ee88f","_number":1348,"virtual_id_number":1348,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-04 15:58:29.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-04 15:58:29.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-04 15:58:29.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-14 18:39:24.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"},{"updated":"2025-12-10 10:48:24.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"93dde586ea065a850f08ff6a88a8cf650bb5d70e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-04 15:58:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"853a6756bf381b3f97f3a9ff5afa4f162d4cfb0d","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-06 13:19:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b51431477524cfeb79a0e39fb591c2aa7bc79bad","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-14 15:42:40.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"caac413107500cd740c2fd6687f01c09ae126ba3","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-14 16:07:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9ed895c385f85296a839019d55496e9ddf0799cc","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-14 18:39:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fe67b6747b7ba9d6a2bc5b122988492e7d026f34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-12-01 16:03:05.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ba10e39c027c7d6bfcabdc2218d59fc84928661f","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-12-01 16:03:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dbfd248a774397ec18f3b661a17403c4df25fc2d","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-12-01 16:20:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8569ebe67ba12df5cc37738748dcea9372ed5ab5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-12-01 21:16:25.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"22121764300967c84eee49cf1e77c3a9cc816011","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-12-01 21:17:14.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3c38905e6ec9b221b6529b60ad850fc7f81a1b83","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-10 10:48:24.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"18fcb95cc0c724ba287fd94a11a9da3fb00ee88f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-12-10 11:02:56.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"8bf8bead6d7cc3c743fdf2b915fbb2f3f24e7005","revisions":{"02db0da193e7bb7773b6983e4deddd27496aab38":{"kind":"REWORK","_number":1,"created":"2025-11-04 15:58:29.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/48/1348/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1348/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/1 \u0026\u0026 git checkout -b change-1348 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1348/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"38e9dd636d115affeb4ec519108978058e4d05a1","subject":"PUSH_UPDATE server: update reporting_addr after ifconfig update"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-04 14:44:44.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-04 15:58:18.000000000","tz":60},"subject":"mudp: fix unaligned 32-bit read when parsing peer ID","message":"mudp: fix unaligned 32-bit read when parsing peer ID\n\nThe code previously read a 32-bit value from a uint8_t\nbuffer using a direct cast and dereference.\nThis can cause unaligned memory access and undefined\nbehavior on architectures that do not support unaligned\nreads, potentially leading to a one-packet crash.\n\nThis patch replaces the unsafe cast with a safe\nmemcpy-based read.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\n\nChange-Id: Id0bb4c45d373437ab8dbaff7a311745f9b538cbf\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"78ad34ed6e99b19c475a611d6de1a5a4b4d49900":{"kind":"REWORK","_number":2,"created":"2025-12-01 16:03:05.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/48/1348/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1348/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/2 \u0026\u0026 git checkout -b change-1348 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1348/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da51cc458716605d0d19be9486b8ee08fc6a9e06","subject":"Drop Mbed TLS 2.X compatibility"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-04 14:44:44.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-12-01 15:35:19.000000000","tz":60},"subject":"mudp: fix unaligned 32-bit read when parsing peer ID","message":"mudp: fix unaligned 32-bit read when parsing peer ID\n\nThe code previously read a 32-bit value from a uint8_t\nbuffer using a direct cast and dereference.\nThis can cause unaligned memory access and undefined\nbehavior on architectures that do not support unaligned\nreads, potentially leading to a one-packet crash.\n\nFix this by read the bytes individually and combine\nthem manually.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\n\nChange-Id: Id0bb4c45d373437ab8dbaff7a311745f9b538cbf\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"b831e404c6c7954b77ac584c1b4fed7e9aaceaf9":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-12-01 21:16:25.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/48/1348/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1348/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/3 \u0026\u0026 git checkout -b change-1348 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1348/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da51cc458716605d0d19be9486b8ee08fc6a9e06","subject":"Drop Mbed TLS 2.X compatibility"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-04 14:44:44.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-12-01 21:14:13.000000000","tz":60},"subject":"mudp: fix unaligned 32-bit read when parsing peer ID","message":"mudp: fix unaligned 32-bit read when parsing peer ID\n\nThe code previously read a 32-bit value from a uint8_t\nbuffer using a direct cast and dereference.\nThis can cause unaligned memory access and undefined\nbehavior on architectures that do not support unaligned\nreads, potentially leading to a one-packet crash.\n\nFix this by reading the bytes individually and\ncombining them manually.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\n\nChange-Id: Id0bb4c45d373437ab8dbaff7a311745f9b538cbf\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8bf8bead6d7cc3c743fdf2b915fbb2f3f24e7005":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-12-10 11:02:56.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/48/1348/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/48/1348/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/4 \u0026\u0026 git checkout -b change-1348 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/48/1348/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/48/1348/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f7afbc511b9d30b27d0b6bbb3ee02dfb1abea646","subject":"iservice: set adapter DNS only with search domains"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-12-10 10:48:33.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-12-10 10:53:56.000000000","tz":60},"subject":"mudp: fix unaligned 32-bit read when parsing peer ID","message":"mudp: fix unaligned 32-bit read when parsing peer ID\n\nThe code previously read a 32-bit value from a uint8_t\nbuffer using a direct cast and dereference.\nThis can cause unaligned memory access and undefined\nbehavior on architectures that do not support unaligned\nreads, potentially leading to a one-packet crash.\n\nFix this by reading the bytes individually and\ncombining them manually.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-By: ZeroPath (https://zeropath.com)\n\nChange-Id: Id0bb4c45d373437ab8dbaff7a311745f9b538cbf\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1348\nMessage-Id: \u003c20251210104839.8270-1-gert@greenie.muc.de\u003e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}