)]}'
{"id":"openvpn~1349","triplet_id":"openvpn~master~Ife55cb78401dad921b75f6c86d9bd0642f6a6e83","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-07 17:06:55.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-07 17:06:55.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-07 16:48:40.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ife55cb78401dad921b75f6c86d9bd0642f6a6e83","subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications","status":"MERGED","created":"2025-11-04 21:44:14.000000000","updated":"2025-11-07 17:06:55.000000000","submitted":"2025-11-07 17:06:55.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1349","meta_rev_id":"3477763c1de74a8df9f956d6a62558160671b9b6","_number":1349,"virtual_id_number":1349,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-04 21:44:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-04 21:44:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-04 21:44:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"a49665536ef1d72eedf18894809416df04765ac7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-04 21:44:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cf753f5222e7cf8c4a176edb30bf2cf68e1dfb70","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-06 16:39:14.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"5f619a8f654fbc217046abb0d71a305d8ccee7db","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-07 13:24:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"18214b1c75f55fcc9916d3439602cd82ab27c3bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 16:43:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5c9c6231bac4f92000454231d12b62a0bbac8007","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 16:44:04.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"68d191ef9916780f5719911ec134c7493589fa4b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-07 16:48:40.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"3477763c1de74a8df9f956d6a62558160671b9b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 17:06:55.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6711ffa9990d027f566fea4dcf005a8a0be71f13","revisions":{"7661dea75f2af7a38c8aae02383868b6d684a416":{"kind":"REWORK","_number":1,"created":"2025-11-04 21:44:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/49/1349/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/1349/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/1 \u0026\u0026 git checkout -b change-1349 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/49/1349/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21b943734f1911a158b7b465d11a04bb6de7f1a8","subject":"test_networking: use appropriate assert helpers"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 07:47:37.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-04 21:35:02.000000000","tz":60},"subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications","message":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications\n\nSome of these debug messages only existed on Linux, and made debugging\nDCO issues on FreeBSD more difficult.  Add them, using the same style as\nused for dco_linux.c\n\nChange-Id: Ife55cb78401dad921b75f6c86d9bd0642f6a6e83\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"c51f568fc2a3cb99c2938514e012dae2d32ecf27":{"kind":"NO_CHANGE","_number":2,"created":"2025-11-06 16:39:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/49/1349/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/1349/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/2 \u0026\u0026 git checkout -b change-1349 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/49/1349/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21b943734f1911a158b7b465d11a04bb6de7f1a8","subject":"test_networking: use appropriate assert helpers"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 07:47:37.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 16:24:15.000000000","tz":60},"subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications","message":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications\n\nSome of these debug messages only existed on Linux, and made debugging\nDCO issues on FreeBSD more difficult.  Add them, using the same style as\nused for dco_linux.c\n\nChange-Id: Ife55cb78401dad921b75f6c86d9bd0642f6a6e83\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"beccef04bcb10d0bf8d7497bbb245ca31d3b8068":{"kind":"REWORK","_number":3,"created":"2025-11-07 16:43:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/49/1349/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/1349/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/3 \u0026\u0026 git checkout -b change-1349 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/49/1349/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c4fe7813d8b8eba99549a7b5e9499a31f91c8109","subject":"FreeBSD DCO: repair incoming \u0027delete peer\u0027 notifications in p2p client mode"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 07:47:37.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 16:39:38.000000000","tz":60},"subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications","message":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications\n\nSome of these debug messages only existed on Linux, and made debugging\nDCO issues on FreeBSD more difficult.  Add them, using the same style as\nused for dco_linux.c\n\nWhile at it, change all format strings for \"peerid\" to \"%u\" (wherever\nappropriate, dco-\u003edco_message_peer_id is an \"int\" today and changing\nthis to uint32_t is out of scope for \"make better logging\")\n\nChange-Id: Ife55cb78401dad921b75f6c86d9bd0642f6a6e83\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"6711ffa9990d027f566fea4dcf005a8a0be71f13":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-11-07 17:06:55.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/49/1349/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/49/1349/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/4 \u0026\u0026 git checkout -b change-1349 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/49/1349/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/49/1349/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c4fe7813d8b8eba99549a7b5e9499a31f91c8109","subject":"FreeBSD DCO: repair incoming \u0027delete peer\u0027 notifications in p2p client mode"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 16:50:29.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 17:05:33.000000000","tz":60},"subject":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications","message":"dco_freebsd.c: add D_DCO_DEBUG messages for counters and notifications\n\nSome of these debug messages only existed on Linux, and made debugging\nDCO issues on FreeBSD more difficult.  Add them, using the same style as\nused for dco_linux.c\n\nWhile at it, change all format strings for \"peerid\" to \"%u\" (wherever\nappropriate, dco-\u003edco_message_peer_id is an \"int\" today and changing\nthis to uint32_t is out of scope for \"make better logging\")\n\nChange-Id: Ife55cb78401dad921b75f6c86d9bd0642f6a6e83\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1349\nMessage-Id: \u003c20251107165038.26171-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34250.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}