)]}'
{"id":"openvpn~1351","triplet_id":"openvpn~master~I48c877843d24144450af1282b7524bb3ba18232e","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-09 11:04:02.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-09 11:04:02.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-09 11:04:02.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I48c877843d24144450af1282b7524bb3ba18232e","subject":"FreeBSD DCO: repair --inactive","status":"MERGED","created":"2025-11-06 12:03:28.000000000","updated":"2025-11-09 11:04:02.000000000","submitted":"2025-11-09 11:04:02.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1351","meta_rev_id":"0cc6cc3af4c0436454d844afa725a19c7c50eb92","_number":1351,"virtual_id_number":1351,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"value":0,"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-06 12:03:29.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-06 12:03:29.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-06 12:03:29.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-09 08:02:09.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"state":"REVIEWER"}],"messages":[{"id":"6fa60eeb4b914d7d202dbb724260347c061ce606","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-06 12:03:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"723329239eca502c177dbc0572d59553c07e20f1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-06 16:39:14.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a423b3ca965dbd7400ce690e8ec872b0b3efd3b2","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-07 13:34:40.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0386cba238cd07dec7f6f5c5bad50ddb0bd6abf3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 13:49:48.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"7c71a6cfb411e0f9cbdc5974b04bd705e41d680f","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 13:50:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"188b8adf70429a70b2f17a8a778e3b1252e20eb8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 17:23:02.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"33fc015e5f97590d553962e6af01a10363566b8f","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-11-09 08:02:09.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"0cc6cc3af4c0436454d844afa725a19c7c50eb92","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-09 11:04:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"7fe5cc03abf2e11bb108dba3117923934dc16150","revisions":{"328a07afa475d72e73c5930c17344171616f81fd":{"kind":"REWORK","_number":1,"created":"2025-11-06 12:03:28.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1351/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1351/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/1 \u0026\u0026 git checkout -b change-1351 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1351/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a2edccc3eb54e78eb784f5c3e1c558a37337ddf6","subject":"dco_freebsd: implement dco_get_peer_stats()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 11:46:28.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 12:02:24.000000000","tz":60},"subject":"FreeBSD DCO: repair --inactive","message":"FreeBSD DCO: repair --inactive\n\n--inactive on DCO requires a working DCO counters query function\n(dco_get_peer_stats(), implemented in the previous commit) and\nthat the DCO implementation in use fills the \"tun_{read,write}_bytes\"\nfields for the peer context.\n\nFreeBSD DCO only fills the \"dco_{read,write}_bytes\" counters - which is\nsomething we can\u0027t fix in OpenVPN, this needs kernel enhancements.\n\nSo, to make the feature (mostly) work, check the other set of counters\non FreeBSD.  Caveat: this will count encryption overhead and keepalives,\nso it will still not work for `--inactive \u003cn\u003e` without a byte count, or\nfor byte counts with too tight thresholds.\n\nAdding the #ifdef to forward.c was considered the least bad alternative.\n\nGithub: OpenVPN/openvpn#898\n\nChange-Id: I48c877843d24144450af1282b7524bb3ba18232e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"3e8b826c8f9c71fb38fbe955da6559098ad09604":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-11-06 16:39:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1351/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1351/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/2 \u0026\u0026 git checkout -b change-1351 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1351/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03973c13a2a78c746474228fa34b6d5ce94e51a9","subject":"dco_freebsd: implement dco_get_peer_stats()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 11:46:28.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 16:28:28.000000000","tz":60},"subject":"FreeBSD DCO: repair --inactive","message":"FreeBSD DCO: repair --inactive\n\n--inactive on DCO requires a working DCO counters query function\n(dco_get_peer_stats(), implemented in the previous commit) and\nthat the DCO implementation in use fills the \"tun_{read,write}_bytes\"\nfields for the peer context.\n\nFreeBSD DCO only fills the \"dco_{read,write}_bytes\" counters - which is\nsomething we can\u0027t fix in OpenVPN, this needs kernel enhancements.\n\nSo, to make the feature (mostly) work, check the other set of counters\non FreeBSD.  Caveat: this will count encryption overhead and keepalives,\nso it will still not work for `--inactive \u003cn\u003e` without a byte count, or\nfor byte counts with too tight thresholds.\n\nAdding the #ifdef to forward.c was considered the least bad alternative.\n\nGithub: OpenVPN/openvpn#898\n\nChange-Id: I48c877843d24144450af1282b7524bb3ba18232e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"f27366b290fdc3e10a1142fac95a18da7e1f06f6":{"kind":"REWORK","_number":3,"created":"2025-11-07 13:49:48.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1351/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1351/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/3 \u0026\u0026 git checkout -b change-1351 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1351/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03973c13a2a78c746474228fa34b6d5ce94e51a9","subject":"dco_freebsd: implement dco_get_peer_stats()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 11:46:28.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 13:49:39.000000000","tz":60},"subject":"FreeBSD DCO: repair --inactive","message":"FreeBSD DCO: repair --inactive\n\n--inactive on DCO requires a working DCO counters query function\n(dco_get_peer_stats(), implemented in the previous commit) and\nthat the DCO implementation in use fills the \"tun_{read,write}_bytes\"\nfields for the peer context.\n\nFreeBSD DCO only fills the \"dco_{read,write}_bytes\" counters - which is\nsomething we can\u0027t fix in OpenVPN, this needs kernel enhancements.\n\nSo, to make the feature (mostly) work, check the other set of counters\non FreeBSD.  Caveat: this will count encryption overhead and keepalives,\nso it will still not work for `--inactive \u003cn\u003e` without a byte count, or\nfor byte counts with too tight thresholds.\n\nAdding the #ifdef to forward.c was considered the least bad alternative.\n\nv2: fix rst syntax for manpage addition\n\nGithub: OpenVPN/openvpn#898\n\nChange-Id: I48c877843d24144450af1282b7524bb3ba18232e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"9e5c1b5651adc7384276754b9e793d4b6c89c4c1":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-11-07 17:23:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1351/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1351/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/4 \u0026\u0026 git checkout -b change-1351 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1351/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"27b8494d9f96379752794bd577775b1498b9dcbe","subject":"dco_freebsd: implement dco_get_peer_stats()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 11:46:28.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 17:07:54.000000000","tz":60},"subject":"FreeBSD DCO: repair --inactive","message":"FreeBSD DCO: repair --inactive\n\n--inactive on DCO requires a working DCO counters query function\n(dco_get_peer_stats(), implemented in the previous commit) and\nthat the DCO implementation in use fills the \"tun_{read,write}_bytes\"\nfields for the peer context.\n\nFreeBSD DCO only fills the \"dco_{read,write}_bytes\" counters - which is\nsomething we can\u0027t fix in OpenVPN, this needs kernel enhancements.\n\nSo, to make the feature (mostly) work, check the other set of counters\non FreeBSD.  Caveat: this will count encryption overhead and keepalives,\nso it will still not work for `--inactive \u003cn\u003e` without a byte count, or\nfor byte counts with too tight thresholds.\n\nAdding the #ifdef to forward.c was considered the least bad alternative.\n\nv2: fix rst syntax for manpage addition\n\nGithub: OpenVPN/openvpn#898\n\nChange-Id: I48c877843d24144450af1282b7524bb3ba18232e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"7fe5cc03abf2e11bb108dba3117923934dc16150":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-11-09 11:04:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/1351/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1351/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/5 \u0026\u0026 git checkout -b change-1351 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1351/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1351/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ce99cd6cfc091e17701b471a88644cb45ab21681","subject":"dco_freebsd: implement dco_get_peer_stats()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-09 08:42:31.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-09 11:00:32.000000000","tz":60},"subject":"FreeBSD DCO: repair --inactive","message":"FreeBSD DCO: repair --inactive\n\n--inactive on DCO requires a working DCO counters query function\n(dco_get_peer_stats(), implemented in the previous commit) and\nthat the DCO implementation in use fills the \"tun_{read,write}_bytes\"\nfields for the peer context.\n\nFreeBSD DCO only fills the \"dco_{read,write}_bytes\" counters - which is\nsomething we can\u0027t fix in OpenVPN, this needs kernel enhancements.\n\nSo, to make the feature (mostly) work, check the other set of counters\non FreeBSD.  Caveat: this will count encryption overhead and keepalives,\nso it will still not work for `--inactive \u003cn\u003e` without a byte count, or\nfor byte counts with too tight thresholds.\n\nAdding the #ifdef to forward.c was considered the least bad alternative.\n\nv2: fix rst syntax for manpage addition\n\nGithub: OpenVPN/openvpn#898\n\nChange-Id: I48c877843d24144450af1282b7524bb3ba18232e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1351\nMessage-Id: \u003c20251109084238.11581-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34274.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}