)]}'
{"id":"openvpn~1353","triplet_id":"openvpn~master~I991d6053776efed771bc1a3880acb80b55959cbc","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-07 16:32:09.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-07 16:32:09.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-07 14:13:08.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I991d6053776efed771bc1a3880acb80b55959cbc","subject":"FreeBSD DCO: repair incoming \u0027delete peer\u0027 notifications in p2p client mode","status":"MERGED","created":"2025-11-06 16:39:14.000000000","updated":"2025-11-07 16:32:09.000000000","submitted":"2025-11-07 16:32:09.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1353","meta_rev_id":"db4d32ecbb5b93d6652b639524573480aa5ab243","_number":1353,"virtual_id_number":1353,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-06 16:39:17.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-06 16:39:17.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-06 16:39:17.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"2e4fd60fc4ee193663498517c5c63537be0c9f36","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-06 16:39:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a97ac71ac20ffaad6ec7a9ee1953723962d6b69","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-07 13:29:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"77090a9f550d6eec0b842d0ceca171ced4dce37f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 13:45:37.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"bbbe6a0dbc05276ef94f9c1be8d9d46810da941e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 13:49:48.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"41dc67f72120089a448868a33b3a1469aacf302e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 13:50:56.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f19f8ab3f26d8a2937e0c5474d5f019782b847be","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-07 14:13:08.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"db4d32ecbb5b93d6652b639524573480aa5ab243","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-07 16:32:09.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c4fe7813d8b8eba99549a7b5e9499a31f91c8109","revisions":{"0200509b3449f6b1188de3a08fd27f94c44bdfa8":{"kind":"REWORK","_number":1,"created":"2025-11-06 16:39:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/53/1353/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1353/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/1 \u0026\u0026 git checkout -b change-1353 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/53/1353/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e8b826c8f9c71fb38fbe955da6559098ad09604","subject":"FreeBSD DCO: repair --inactive"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 16:07:09.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 16:28:40.000000000","tz":60},"subject":"FreeBSD DCO: repair incoming \"delete peer\" notifications in p2p client mode","message":"FreeBSD DCO: repair incoming \"delete peer\" notifications in p2p client mode\n\ncommit 4a48841da2 introduced a workaround for spurious DCO notifications\n\"with no useful content\" on Linux - namely, ignoring dco_message_type\u003d\u003d0\nin forward.c, process_incoming_dco(), \"because Linux has no message\ntype 0 anyway\".\n\nEach DCO platform uses its own enum for these notification messages\n*inside* OpenVPN (which might not have the best design decision ever),\nand FreeBSD had OVPN_CMD_DEL_PEER in the enum on \"position 0\"...\n\nFix by changing the enum to start with 1.  Tested with DEL_PEER in p2p\nclient and DEL_PEER \u0026 FLOAT in p2mp server mode.\n\nGithub: fixes OpenVPN/openvpn#881\n\nChange-Id: I991d6053776efed771bc1a3880acb80b55959cbc\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"f28cb3ad66b50750620f0a7763b1a553b94fdfc7":{"kind":"REWORK","_number":2,"created":"2025-11-07 13:45:37.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/53/1353/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1353/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/2 \u0026\u0026 git checkout -b change-1353 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/53/1353/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3e8b826c8f9c71fb38fbe955da6559098ad09604","subject":"FreeBSD DCO: repair --inactive"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 16:07:09.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 13:42:49.000000000","tz":60},"subject":"FreeBSD DCO: repair incoming \"delete peer\" notifications in p2p client mode","message":"FreeBSD DCO: repair incoming \"delete peer\" notifications in p2p client mode\n\ncommit 4a48841da2 introduced a workaround for spurious DCO notifications\n\"with no useful content\" on Linux - namely, ignoring dco_message_type\u003d\u003d0\nin forward.c, process_incoming_dco(), \"because Linux has no message\ntype 0 anyway\".\n\nEach DCO platform uses its own enum for these notification messages\n*inside* OpenVPN (which might not have the best design decision ever),\nand FreeBSD had OVPN_CMD_DEL_PEER in the enum on \"position 0\"...\n\nFix by changing the enum to start with 1.  Tested with DEL_PEER in p2p\nclient and DEL_PEER \u0026 FLOAT in p2mp server mode.\n\nv2:\n  introduce OVPN_CMD_NO_MESSAGE in position 0, and a comment explaining why.\n  A future commit can then clean up forward.c and dco_linux.c to use the\n  constant, and not \"magic 0 which happens to be in there after CLEAR()\".\n\nGithub: fixes OpenVPN/openvpn#881\n\nChange-Id: I991d6053776efed771bc1a3880acb80b55959cbc\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"6049e18cb0e3825268c6a4af3dd6e670fdcf0766":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-11-07 13:49:48.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/53/1353/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1353/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/3 \u0026\u0026 git checkout -b change-1353 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/53/1353/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f27366b290fdc3e10a1142fac95a18da7e1f06f6","subject":"FreeBSD DCO: repair --inactive"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-06 16:07:09.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 13:49:39.000000000","tz":60},"subject":"FreeBSD DCO: repair incoming \"delete peer\" notifications in p2p client mode","message":"FreeBSD DCO: repair incoming \"delete peer\" notifications in p2p client mode\n\ncommit 4a48841da2 introduced a workaround for spurious DCO notifications\n\"with no useful content\" on Linux - namely, ignoring dco_message_type\u003d\u003d0\nin forward.c, process_incoming_dco(), \"because Linux has no message\ntype 0 anyway\".\n\nEach DCO platform uses its own enum for these notification messages\n*inside* OpenVPN (which might not have the best design decision ever),\nand FreeBSD had OVPN_CMD_DEL_PEER in the enum on \"position 0\"...\n\nFix by changing the enum to start with 1.  Tested with DEL_PEER in p2p\nclient and DEL_PEER \u0026 FLOAT in p2mp server mode.\n\nv2:\n  introduce OVPN_CMD_NO_MESSAGE in position 0, and a comment explaining why.\n  A future commit can then clean up forward.c and dco_linux.c to use the\n  constant, and not \"magic 0 which happens to be in there after CLEAR()\".\n\nGithub: fixes OpenVPN/openvpn#881\n\nChange-Id: I991d6053776efed771bc1a3880acb80b55959cbc\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"c4fe7813d8b8eba99549a7b5e9499a31f91c8109":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-11-07 16:32:09.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/53/1353/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/53/1353/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/4 \u0026\u0026 git checkout -b change-1353 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/53/1353/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/53/1353/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8545a3db4e83d0294d823ad6489a3040de10984e","subject":"init: make some functions static"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 14:13:27.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-07 16:29:22.000000000","tz":60},"subject":"FreeBSD DCO: repair incoming \u0027delete peer\u0027 notifications in p2p client mode","message":"FreeBSD DCO: repair incoming \u0027delete peer\u0027 notifications in p2p client mode\n\ncommit 4a48841da2 introduced a workaround for spurious DCO notifications\n\"with no useful content\" on Linux - namely, ignoring dco_message_type\u003d\u003d0\nin forward.c, process_incoming_dco(), \"because Linux has no message\ntype 0 anyway\".\n\nEach DCO platform uses its own enum for these notification messages\n*inside* OpenVPN (which might not have the best design decision ever),\nand FreeBSD had OVPN_CMD_DEL_PEER in the enum on \"position 0\"...\n\nFix by changing the enum to start with 1.  Tested with DEL_PEER in p2p\nclient and DEL_PEER \u0026 FLOAT in p2mp server mode.\n\nv2:\n  introduce OVPN_CMD_NO_MESSAGE in position 0, and a comment explaining why.\n  A future commit can then clean up forward.c and dco_linux.c to use the\n  constant, and not \"magic 0 which happens to be in there after CLEAR()\".\n\nGithub: fixes OpenVPN/openvpn#881\n\nChange-Id: I991d6053776efed771bc1a3880acb80b55959cbc\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1353\nMessage-Id: \u003c20251107141333.12056-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34237.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}