)]}'
{"id":"openvpn~1354","triplet_id":"openvpn~master~I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-12 10:38:00.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-12 10:38:00.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-12 10:38:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b","subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","status":"MERGED","created":"2025-11-06 20:59:21.000000000","updated":"2025-11-12 10:38:00.000000000","submitted":"2025-11-12 10:38:00.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1354","meta_rev_id":"08d51eb205cf544a7cc89947c0cf226eb654ba2d","_number":1354,"virtual_id_number":1354,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-06 20:59:23.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-06 20:59:23.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-06 20:59:23.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-12 09:19:15.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"08d302c9f166aeb71823a8f538e63a3d0f07eac2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-06 20:59:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a0bb3888de90b04a3ed1d53bec520827a1cf2a44","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-07 02:16:22.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"187ac70261bb7044379eada03f1806c4bd17f1fe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-07 18:23:15.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"9e50d1613d686b3fad49cac61000e978052026b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-07 23:36:34.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"5a3b253be3303781040853042cdc57d503b03f3b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-11 01:17:51.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"8e229984b4f3da680a67a21e0227749c3d4aea1f","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-11-12 09:19:15.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"08d51eb205cf544a7cc89947c0cf226eb654ba2d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-12 10:38:00.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"763160a16a8910d039cdb2359b10ec61b8041e4b","revisions":{"f2be502f33fff2278d72d5923058d8455565fb49":{"kind":"REWORK","_number":1,"created":"2025-11-06 20:59:21.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/54/1354/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1354/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/1 \u0026\u0026 git checkout -b change-1354 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1354/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e194b66c25f74d40e1b8876eaf990b9bab946df7","subject":"iservice: make sure directories have trailing \\"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-06 20:57:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-06 20:57:03.000000000","tz":60},"subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","message":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH\n\nSince the define is no longer used, remove configuration-time checks if\nit exists, and also code dealing with situations where it doesn\u0027t.\n\nChange-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"b8835d428113957d48f219186b787fd83df71da1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-11-07 02:16:22.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/54/1354/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1354/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/2 \u0026\u0026 git checkout -b change-1354 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1354/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee74e95b10c50f19e22e19edfc6648451ada6a5a","subject":"iservice: make sure directories have trailing \\"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-06 20:57:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-07 02:16:12.000000000","tz":60},"subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","message":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH\n\nSince the define is no longer used, remove configuration-time checks if\nit exists, and also code dealing with situations where it doesn\u0027t.\n\nChange-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"442ce8b83f4d2232ea07c7fe3f2a4c93fb2fa9ce":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-11-07 18:23:15.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/54/1354/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1354/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/3 \u0026\u0026 git checkout -b change-1354 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1354/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b7688be6510e36e9bf80dab41e6a630842bf6328","subject":"iservice: make sure directories have trailing \\"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-06 20:57:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-07 18:02:25.000000000","tz":60},"subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","message":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH\n\nSince the define is no longer used, remove configuration-time checks if\nit exists, and also code dealing with situations where it doesn\u0027t.\n\nChange-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"9688e69bbcbc92d19d2dce9231b51695d4481348":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-11-07 23:36:34.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/54/1354/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1354/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/4 \u0026\u0026 git checkout -b change-1354 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1354/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"05d728d64b276eff643b41d12332b64c6345dd56","subject":"iservice: make sure directories have trailing \\"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-06 20:57:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-07 23:35:08.000000000","tz":60},"subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","message":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH\n\nSince the define is no longer used, remove configuration-time checks if\nit exists, and also code dealing with situations where it doesn\u0027t.\n\nChange-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"90c985c26ca8b6eac5443f368ed229e636036d44":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2025-11-11 01:17:51.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/54/1354/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1354/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/5 \u0026\u0026 git checkout -b change-1354 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1354/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd48c8836307f2c415f792eb36ab10ebeb53f5d1","subject":"iservice: make sure directories have trailing \\"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-06 20:57:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-11 01:17:35.000000000","tz":60},"subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","message":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH\n\nSince the define is no longer used, remove configuration-time checks if\nit exists, and also code dealing with situations where it doesn\u0027t.\n\nChange-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"763160a16a8910d039cdb2359b10ec61b8041e4b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2025-11-12 10:38:00.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/54/1354/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1354/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/6 \u0026\u0026 git checkout -b change-1354 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1354/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1354/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bbca8141ebf86423026f3867eca892fe82880a68","subject":"iservice: validate config path better"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-12 09:22:10.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-12 10:34:50.000000000","tz":60},"subject":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH","message":"win: remove checks for PATHCCH_ENSURE_TRAILING_SLASH\n\nSince the define is no longer used, remove configuration-time checks if\nit exists, and also code dealing with situations where it doesn\u0027t.\n\nChange-Id: I50f189048ef1a624e6ac84b71d7b22fcbbc3ab6b\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1354\nMessage-Id: \u003c20251112092216.22703-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34335.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
