)]}'
{"id":"openvpn~1359","triplet_id":"openvpn~master~I31024f93d9d9d0f678fb39d4758a7e870bf00873","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-11 10:59:25.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-12 13:58:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I31024f93d9d9d0f678fb39d4758a7e870bf00873","subject":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group","status":"MERGED","created":"2025-11-07 15:38:20.000000000","updated":"2025-11-12 13:58:57.000000000","submitted":"2025-11-12 13:58:57.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1359-wconversion","meta_rev_id":"46f001df2054564efee5ff94cb7c34f2a5de0ab1","_number":1359,"virtual_id_number":1359,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-07 15:38:21.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-07 15:38:21.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"9827b2519a95f781d704718a9206579be95f6210","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-07 15:38:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee341e8f2672ed3ef8fca9e1035a499565a78b25","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-11-11 10:59:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e22e2847cd6e8722d7a9a84ffa0d6ab432f5a97a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-11 14:26:54.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"46f001df2054564efee5ff94cb7c34f2a5de0ab1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-12 13:58:57.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4fa8539a088e490633e0f7114c21e03d61871dd6","revisions":{"46ca54ddbb49231bcd2b54a783b1ddb89d707444":{"kind":"REWORK","_number":1,"created":"2025-11-07 15:38:20.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/59/1359/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1359/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/1 \u0026\u0026 git checkout -b change-1359 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1359/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1053dccdadb030a17c1b33d30ad5ec1b07765066","subject":"ssl: Clean up type handling in parse_early_negotiation_tlvs()"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-07 15:36:23.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-07 15:36:23.000000000","tz":60},"subject":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group","message":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group\n\nSSL_get_negotiated_group is documented to return\nint and SSL_group_to_name definitely expects an int.\n\nBut SSL_get_negotiated_group is actually a macro\nimplemented by SSL_ctrl, which does return a long.\nSo to avoid the conversion warning we need the cast.\n\nChange-Id: I31024f93d9d9d0f678fb39d4758a7e870bf00873\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"26fd60b55a7409f05d3cb0ba142972a425269158":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-11-11 14:26:54.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/59/1359/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1359/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/2 \u0026\u0026 git checkout -b change-1359 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1359/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cba5a8be60c78f9736830d2a77cd11ff569cfa6b","subject":"ssl: Clean up type handling in parse_early_negotiation_tlvs()"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-07 15:36:23.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-11 14:22:29.000000000","tz":60},"subject":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group","message":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group\n\nSSL_get_negotiated_group is documented to return\nint and SSL_group_to_name definitely expects an int.\n\nBut SSL_get_negotiated_group is actually a macro\nimplemented by SSL_ctrl, which does return a long.\nSo to avoid the conversion warning we need the cast.\n\nChange-Id: I31024f93d9d9d0f678fb39d4758a7e870bf00873\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4fa8539a088e490633e0f7114c21e03d61871dd6":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-12 13:58:57.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/59/1359/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1359/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/3 \u0026\u0026 git checkout -b change-1359 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1359/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1359/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0da6116c0c8fccfa12369139ebf9357d113debba","subject":"ssl: Change tls_send_payload size argument to size_t"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-11 15:32:24.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-12 13:57:40.000000000","tz":60},"subject":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group","message":"openssl_compat: Avoid conversion warning for SSL_get_negotiated_group\n\nSSL_get_negotiated_group is documented to return\nint and SSL_group_to_name definitely expects an int.\n\nBut SSL_get_negotiated_group is actually a macro\nimplemented by SSL_ctrl, which does return a long.\nSo to avoid the conversion warning we need the cast.\n\nChange-Id: I31024f93d9d9d0f678fb39d4758a7e870bf00873\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1359\nMessage-Id: \u003c20251111153230.29865-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34316.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}