)]}'
{"src/openvpn/ssl_pkt.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"37f5b9aa42ebc9eeff85fa8dff3b5931a9895997","unresolved":true,"context_lines":[{"line_number":165,"context_line":"                   struct link_socket_actual **to_link_addr, int opcode, int max_ack,"},{"line_number":166,"context_line":"                   bool prepend_ack)"},{"line_number":167,"context_line":"{"},{"line_number":168,"context_line":"    ASSERT(ks-\u003ekey_id \u003e\u003d 0 \u0026\u0026 ks-\u003ekey_id \u003c\u003d 1 \u003c\u003c P_OPCODE_SHIFT);"},{"line_number":169,"context_line":"    ASSERT(opcode \u003e\u003d 0 \u0026\u0026 opcode \u003c\u003d P_LAST_OPCODE);"},{"line_number":170,"context_line":"    uint8_t header \u003d (uint8_t)(ks-\u003ekey_id | (opcode \u003c\u003c P_OPCODE_SHIFT));"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a1fe2aaa_8b703041","line":168,"updated":"2025-11-11 11:13:28.000000000","message":"key should be \u003c\u003d 7 instead of \u003c\u003d 8. I think this is the same problem as in https://gerrit.openvpn.net/c/openvpn/+/1298/3/src/openvpn/ssl.c#3985","commit_id":"01e83cb01becd1324f5cf81ffeca71f3e2ffb7d7"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e0c914819a35c63dece6510b0511a36a6be7bc32","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                   struct link_socket_actual **to_link_addr, int opcode, int max_ack,"},{"line_number":166,"context_line":"                   bool prepend_ack)"},{"line_number":167,"context_line":"{"},{"line_number":168,"context_line":"    ASSERT(ks-\u003ekey_id \u003e\u003d 0 \u0026\u0026 ks-\u003ekey_id \u003c\u003d 1 \u003c\u003c P_OPCODE_SHIFT);"},{"line_number":169,"context_line":"    ASSERT(opcode \u003e\u003d 0 \u0026\u0026 opcode \u003c\u003d P_LAST_OPCODE);"},{"line_number":170,"context_line":"    uint8_t header \u003d (uint8_t)(ks-\u003ekey_id | (opcode \u003c\u003c P_OPCODE_SHIFT));"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"812534fc_d569d84c","line":168,"in_reply_to":"a1fe2aaa_8b703041","updated":"2025-11-11 15:55:07.000000000","message":"Done","commit_id":"01e83cb01becd1324f5cf81ffeca71f3e2ffb7d7"}]}
