)]}'
{"id":"openvpn~1363","triplet_id":"openvpn~master~Ia74a931c703d594bdf8ccada9b783b94608de278","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-14 21:01:12.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-14 21:01:12.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-14 21:01:12.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-11-12 18:59:15.000000000","reason":"\u003cGERRIT_ACCOUNT_1000008\u003e replied on the change","reason_account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}}},"hashtags":["mailsubmitted"],"change_id":"Ia74a931c703d594bdf8ccada9b783b94608de278","subject":"iservice: use saved iface index to restore metric","status":"MERGED","created":"2025-11-11 01:12:01.000000000","updated":"2025-11-14 21:01:12.000000000","submitted":"2025-11-14 21:01:12.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1363","meta_rev_id":"28bef360666cde2f4ba93d83fefe3850cb198af6","_number":1363,"virtual_id_number":1363,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-11 01:12:02.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-11 01:12:02.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-11 01:12:02.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-12 09:32:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"6dd089a0ea8aeaa3100c5e8473803c073191718f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-11 01:12:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dae65f981659e6ac7aaca82eb7dd0b6a47b25f89","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-11-12 09:32:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2600c86cdc4e16d04e9bf06d9b9185f499ef2d31","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-12 14:57:40.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f3f7d236644e2dad159573d6ac89d325a36a2c80","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-12 15:07:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"593008ccdbc8150260fa7068b30b967d9bcb1cfa","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-11-12 18:59:15.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b4655a37df8027efa12683fda1f384479da8549f","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-14 15:36:09.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"28bef360666cde2f4ba93d83fefe3850cb198af6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-14 21:01:12.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a1d4a79487ec0089ee01ab635921761933e4e1d6","revisions":{"d5b0062fccd9ea58187ecff495b4018123609ecc":{"kind":"REWORK","_number":1,"created":"2025-11-11 01:12:01.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/63/1363/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/1363/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/1 \u0026\u0026 git checkout -b change-1363 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/63/1363/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e0b68aeeaebeed71b902299c436371ebc83170e","subject":"dco_freebsd.c: fix integer warnings"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-11 00:13:22.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-11 00:13:22.000000000","tz":60},"subject":"iservice: use saved iface index to restore metric","message":"iservice: use saved iface index to restore metric\n\nWhen adding block rules, the interface metric of the VPN adapter is\ntemporarily modified so that an old version of Windows 10 would pick\nit up first when looking up stuff via DNS. These metrics are reverted to\nthe old value when the block is removed.\n\nWhen reverting them, instead of using the stored interface index where\nthe original values were read from, we were using the interface index\npassed to the service with the wfp block message. That index could\ntheoretically be different from the one stored, which would result in\nthe metric being set to the wrong interface.\n\nReported-by: stephan@srlabs.de\nChange-Id: Ia74a931c703d594bdf8ccada9b783b94608de278\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"041a434c8c5ba32e1ac47b7773ee7c04f22d093d":{"kind":"REWORK","_number":2,"created":"2025-11-12 14:57:40.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/63/1363/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/1363/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/2 \u0026\u0026 git checkout -b change-1363 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/63/1363/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e0b68aeeaebeed71b902299c436371ebc83170e","subject":"dco_freebsd.c: fix integer warnings"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-11 00:13:22.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-12 14:57:29.000000000","tz":60},"subject":"iservice: use saved iface index to restore metric","message":"iservice: use saved iface index to restore metric\n\nWhen adding block rules, the interface metric of the VPN adapter is\ntemporarily modified so that an old version of Windows 10 would pick\nit up first when looking up stuff via DNS. These metrics are reverted to\nthe old value when the block is removed.\n\nWhen reverting them, instead of using the stored interface index where\nthe original values were read from, we were using the interface index\npassed to the service with the wfp block message. That index could\ntheoretically be different from the one stored, which would result in\nthe metric being set to the wrong interface.\n\nReported-by: stephan@srlabs.de\nChange-Id: Ia74a931c703d594bdf8ccada9b783b94608de278\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"a1d4a79487ec0089ee01ab635921761933e4e1d6":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-14 21:01:12.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/63/1363/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/1363/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/3 \u0026\u0026 git checkout -b change-1363 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/63/1363/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/1363/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c716b3b8bf5945e326c5ac7a8b04de9c0c6a4c8f","subject":"options: remove --opt-verify functionality"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-12 21:51:00.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-14 20:57:36.000000000","tz":60},"subject":"iservice: use saved iface index to restore metric","message":"iservice: use saved iface index to restore metric\n\nWhen adding block rules, the interface metric of the VPN adapter is\ntemporarily modified so that an old version of Windows 10 would pick\nit up first when looking up stuff via DNS. These metrics are reverted to\nthe old value when the block is removed.\n\nWhen reverting them, instead of using the stored interface index where\nthe original values were read from, we were using the interface index\npassed to the service with the wfp block message. That index could\ntheoretically be different from the one stored, which would result in\nthe metric being set to the wrong interface.\n\nReported-by: stephan@srlabs.de\nChange-Id: Ia74a931c703d594bdf8ccada9b783b94608de278\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1363\nMessage-Id: \u003c20251112215106.14182-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34400.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}