)]}'
{"id":"openvpn~1364","triplet_id":"openvpn~master~I6a5110a0583b8b33496b06d9c27c1084df38e842","project":"openvpn","branch":"master","topic":"multisocket_cleanup","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-24 18:50:01.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2025-11-24 18:50:01.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-21 21:03:37.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-24 18:50:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6a5110a0583b8b33496b06d9c27c1084df38e842","subject":"multi-socket: do not return tuntap flags on server-side","status":"MERGED","created":"2025-11-11 11:55:18.000000000","updated":"2025-11-24 18:50:01.000000000","submitted":"2025-11-24 18:50:01.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1364-multisocket_cleanup","meta_rev_id":"5a41f3c5388989b2770fd13c489aeeb0326f97b4","_number":1364,"virtual_id_number":1364,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-11 11:55:19.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-11 11:55:19.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-11-11 11:55:19.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-16 12:45:52.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"5b1da1918a4da95f925a5ad948e977285669f435","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-11 11:55:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eff89dc98cef40074a80494c40d7b5c5f9b41b5d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-16 12:45:52.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6d10a4c7fe809b1ac312ad034ef0f57434c80ed3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-20 10:57:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fbbbe026dc077e7d7fff28dcae47f2be16a0b729","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-20 10:58:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"148b738f0fdb8f0aedf7c03834044f9897edda8f","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-21 21:03:37.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"04789ece90b1957226c72dfed39581650ebe554b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-24 08:02:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"29bf2056a7f2ae795ab731e64a9cc7278d1a70db","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-24 17:58:19.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"5a41f3c5388989b2770fd13c489aeeb0326f97b4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-24 18:50:01.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6244e466217a367dd4d858f5e930e3aab415fc42","revisions":{"0c317b79cfa7c42e1ac29c5340831ca6a415f68f":{"kind":"REWORK","_number":1,"created":"2025-11-11 11:55:18.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/64/1364/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1364/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/1 \u0026\u0026 git checkout -b change-1364 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1364/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e0b68aeeaebeed71b902299c436371ebc83170e","subject":"dco_freebsd.c: fix integer warnings"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-05 10:05:57.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-11 11:16:27.000000000","tz":60},"subject":"multi-socket: do not return tuntap flags on server-side","message":"multi-socket: do not return tuntap flags on server-side\n\nTuntap flags are already handled within\nmulti_io_process_io() so return them by\nmulti_io_process_flags() would be redoundant,\nsince we need them only for tun_set().\n\nWhile at it, removed part of the I/O process\nfrom multi_process_io_udp() since those are\nalso handled within multi_io_process_io().\n\nChange-Id: I6a5110a0583b8b33496b06d9c27c1084df38e842\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"2c2bb5c84570121c8ac5a90d083ac60e87a26777":{"kind":"REWORK","_number":2,"created":"2025-11-20 10:57:50.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/64/1364/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1364/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/2 \u0026\u0026 git checkout -b change-1364 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1364/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9807719077b5c9886fa0e1e4f47f9669b04d09f9","subject":"GHA: Add macos-26 and remove OpenSSL 1.1 builds on macOS"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-05 10:05:57.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-20 10:25:57.000000000","tz":60},"subject":"multi-socket: do not return tuntap flags on server-side","message":"multi-socket: do not return tuntap flags on server-side\n\nTuntap flags are already handled within\nmulti_io_process_io() so return them by\nmulti_io_process_flags() would be redoundant,\nsince we need them only for tun_set().\n\nWhile at it, removed part of the I/O process\nfrom multi_process_io_udp() since those are\nalso handled within multi_io_process_io(),\nand changed the IO debug to a more useful\nstyle.\n\nChange-Id: I6a5110a0583b8b33496b06d9c27c1084df38e842\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"27172d2210dad6fe3f705f7a6ac94ff89dfc3f6f":{"kind":"REWORK","_number":3,"created":"2025-11-24 08:02:22.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/64/1364/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1364/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/3 \u0026\u0026 git checkout -b change-1364 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1364/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e2ac94e9cf3d0bdb28339594c8236fa98784967","subject":"iservice: check for NULL pointer"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-05 10:05:57.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-23 23:15:52.000000000","tz":60},"subject":"multi-socket: do not return tuntap flags on server-side","message":"multi-socket: do not return tuntap flags on server-side\n\nTuntap flags are already handled within\nmulti_io_process_io() so return them by\nmulti_io_process_flags() would be redoundant,\nsince we need them only for tun_set().\n\nWhile at it, removed part of the I/O process\nfrom multi_process_io_udp() since those are\nalso handled within multi_io_process_io(),\nremoved the FILE_CLOSED and FILE_SHIFT\ndefines since we now handle that kind of\nevent in multi_io_process_io() through\nthe MULTI_IO_FILE_CLOSE_WRITE define.\n\nChange-Id: I6a5110a0583b8b33496b06d9c27c1084df38e842\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"6244e466217a367dd4d858f5e930e3aab415fc42":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-11-24 18:50:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/64/1364/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/64/1364/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/4 \u0026\u0026 git checkout -b change-1364 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/64/1364/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/64/1364/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a429cb13557356ac14cc458de3b42e3e09f6c62","subject":"Restrict access to the service pipe to SYSTEM and owner"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-24 17:58:27.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-24 18:43:29.000000000","tz":60},"subject":"multi-socket: do not return tuntap flags on server-side","message":"multi-socket: do not return tuntap flags on server-side\n\nTuntap flags are already handled within\nmulti_io_process_io() so return them by\nmulti_io_process_flags() would be redoundant,\nsince we need them only for tun_set().\n\nWhile at it, removed part of the I/O process\nfrom multi_process_io_udp() since those are\nalso handled within multi_io_process_io(),\nremoved the FILE_CLOSED and FILE_SHIFT\ndefines since we now handle that kind of\nevent in multi_io_process_io() through\nthe MULTI_IO_FILE_CLOSE_WRITE define.\n\nChange-Id: I6a5110a0583b8b33496b06d9c27c1084df38e842\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1364\nMessage-Id: \u003c20251124175832.21352-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34650.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}