)]}'
{"id":"openvpn~1374","triplet_id":"openvpn~master~I270f679505c90ef78a5afbad1e05219f166be089","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-16 12:26:11.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-11-16 12:26:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I270f679505c90ef78a5afbad1e05219f166be089","subject":"tapctl: refactor \u0027create\u0027 command","status":"MERGED","created":"2025-11-12 13:47:32.000000000","updated":"2025-11-16 12:26:11.000000000","submitted":"2025-11-16 12:26:11.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"1374","meta_rev_id":"884e7954936f1d85f9ebea1008339bb91ad95d02","_number":1374,"virtual_id_number":1374,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-12 13:47:33.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-12 13:47:33.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-16 12:11:32.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1b4abe483e677576c5edd071137623220dee6aa2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-11-12 13:47:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"90142fb2807ef758771eaf0163f58929e55e1dbd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-11-15 18:57:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6144b3e658fed0919c0959db999d2c3757a8df4a","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-16 12:11:32.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"884e7954936f1d85f9ebea1008339bb91ad95d02","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-16 12:26:11.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8487dbf1606c4c5f787dcf015228f1a05378da17","revisions":{"340288caa138dac28da5518b3473aaa2993772e7":{"kind":"REWORK","_number":1,"created":"2025-11-12 13:47:32.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/74/1374/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/1374/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/1 \u0026\u0026 git checkout -b change-1374 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/74/1374/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9cad4a8f9a4d925da050f3e944cc499eee4aae36","subject":"tapctl: make output of \u0027list\u0027 and \u0027create\u0027 commands more verbose"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-11-12 13:27:14.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-11-12 13:43:44.000000000","tz":120},"subject":"tapctl: refactor \u0027create\u0027 command","message":"tapctl: refactor \u0027create\u0027 command\n\nMake default adapter name selection logic more robust -\nsometimes renaming fails because the deleted adapter name\nmight present in the registry even though adapter is not shown\nanymore in enumeration.\n\nEnsure that adapter name doesn\u0027t contain disallowed symbols.\n\nUse --hwid ovpn-dco by default and update documentation.\n\nChange-Id: I270f679505c90ef78a5afbad1e05219f166be089\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"1b5d363e6739b374d7b2cd79ee3a0dd780ac65b6":{"kind":"REWORK","_number":2,"created":"2025-11-15 18:57:10.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/74/1374/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/1374/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/2 \u0026\u0026 git checkout -b change-1374 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/74/1374/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20167d569ac70ad33d52e824065ba5a8a4d7c76f","subject":"tapctl: make output of \u0027list\u0027 and \u0027create\u0027 commands more verbose"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-11-12 13:27:14.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-11-15 18:51:05.000000000","tz":120},"subject":"tapctl: refactor \u0027create\u0027 command","message":"tapctl: refactor \u0027create\u0027 command\n\nMake default adapter name selection logic more robust -\nsometimes renaming fails because the deleted adapter name\nmight present in the registry even though adapter is not shown\nanymore in enumeration.\n\nEnsure that adapter name doesn\u0027t contain disallowed symbols.\n\nUse --hwid ovpn-dco by default and update documentation.\n\nChange-Id: I270f679505c90ef78a5afbad1e05219f166be089\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"8487dbf1606c4c5f787dcf015228f1a05378da17":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-16 12:26:11.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/74/1374/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/74/1374/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/3 \u0026\u0026 git checkout -b change-1374 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/74/1374/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/74/1374/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c8f0e726f1d3d02d546d7eb3ef03eb7429c44272","subject":"tapctl: make output of \u0027list\u0027 and \u0027create\u0027 commands more verbose"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-11-16 12:11:40.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-16 12:19:32.000000000","tz":60},"subject":"tapctl: refactor \u0027create\u0027 command","message":"tapctl: refactor \u0027create\u0027 command\n\nMake default adapter name selection logic more robust -\nsometimes renaming fails because the deleted adapter name\nmight present in the registry even though adapter is not shown\nanymore in enumeration.\n\nEnsure that adapter name doesn\u0027t contain disallowed symbols.\n\nUse --hwid ovpn-dco by default and update documentation.\n\nChange-Id: I270f679505c90ef78a5afbad1e05219f166be089\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1374\nMessage-Id: \u003c20251116121146.4067-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34455.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
