)]}'
{"id":"openvpn~1384","triplet_id":"openvpn~master~Id1457f8432b4f0a69108b91ca12f2cbd0818f90d","project":"openvpn","branch":"master","topic":"multisocket_cleanup","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-22 21:41:55.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2025-11-22 21:41:55.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id1457f8432b4f0a69108b91ca12f2cbd0818f90d","subject":"multi-socket: remove duplicated/dead code","status":"MERGED","created":"2025-11-20 10:57:50.000000000","updated":"2025-11-22 21:41:55.000000000","submitted":"2025-11-22 21:41:55.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1384-multisocket_cleanup","meta_rev_id":"8d6a45442ed913c2536fe9d6f721aadc2c67ab0d","_number":1384,"virtual_id_number":1384,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-20 10:57:52.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-20 10:57:52.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-22 18:52:24.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"f39f99d74e5c13deb3dbc9c38ba6130fc215be3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-11-20 10:57:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70fe1584671e181777e8f60fdb8fec63d4f79de6","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 18:52:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8d6a45442ed913c2536fe9d6f721aadc2c67ab0d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 21:41:55.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"779ab39d88c8ac83c67b69741d80b79a4587ad25","revisions":{"04db6525199e5e56c1288779518f634dfc126a5f":{"kind":"REWORK","_number":1,"created":"2025-11-20 10:57:50.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/84/1384/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/1384/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/1 \u0026\u0026 git checkout -b change-1384 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/84/1384/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ebbfa966c0727ad19163039f71b370d9e074722","subject":"mudp: fix handling of multiple UDP socket flags"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-20 10:37:26.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-20 10:37:26.000000000","tz":60},"subject":"multi-socket: remove duplicated/dead code","message":"multi-socket: remove duplicated/dead code\n\nRemoved the event_ctl() for ENABLE_ASYNC_PUSH\nin io_wait_dowork() since that function is\nnot executed by servers anymore.\n\nRemoved a duplicated code in multi_io_process_io()\nfor new incoming TCP connections since the same\nthing is done couple lines above.\n\nChange-Id: Id1457f8432b4f0a69108b91ca12f2cbd0818f90d\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"779ab39d88c8ac83c67b69741d80b79a4587ad25":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-11-22 21:41:55.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/84/1384/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/1384/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/2 \u0026\u0026 git checkout -b change-1384 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/84/1384/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/1384/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b39bed539f218f6165d79224adbc343a63a4514d","subject":"iservice: fix buffer size in call to FormatMessage"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-11-22 18:52:33.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-22 21:39:05.000000000","tz":60},"subject":"multi-socket: remove duplicated/dead code","message":"multi-socket: remove duplicated/dead code\n\nRemoved the event_ctl() for ENABLE_ASYNC_PUSH\nin io_wait_dowork() since that function is\nnot executed by servers anymore.\n\nRemoved a duplicated code in multi_io_process_io()\nfor new incoming TCP connections since the same\nthing is done couple lines above.\n\nChange-Id: Id1457f8432b4f0a69108b91ca12f2cbd0818f90d\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1384\nMessage-Id: \u003c20251122185239.26312-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34593.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}