)]}'
{"id":"openvpn~1385","triplet_id":"openvpn~master~Ie7308d549182a95b86cd113e4a8cc65ff45ba3d7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-22 17:39:01.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-11-22 17:39:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie7308d549182a95b86cd113e4a8cc65ff45ba3d7","subject":"tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age","status":"MERGED","created":"2025-11-20 14:52:13.000000000","updated":"2025-11-22 17:39:01.000000000","submitted":"2025-11-22 17:39:01.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1385","meta_rev_id":"7f612e57b913c085574753161bb649e0b76a3e4e","_number":1385,"virtual_id_number":1385,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-20 14:52:15.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-20 14:52:15.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-22 16:25:38.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ad039509629c17af8f0c807416d454e60a65c0a1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-11-20 14:52:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a3381098b26a2ed0e4044dd206d8e38b14184a85","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 16:25:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7f612e57b913c085574753161bb649e0b76a3e4e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 17:39:01.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2969837ad347a227e1d33b1c71390d85f16aa2cd","revisions":{"c25633bd7d39491ae1a54cb94fa8430e6a34275c":{"kind":"REWORK","_number":1,"created":"2025-11-20 14:52:13.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/85/1385/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1385/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/1 \u0026\u0026 git checkout -b change-1385 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/1385/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9807719077b5c9886fa0e1e4f47f9669b04d09f9","subject":"GHA: Add macos-26 and remove OpenSSL 1.1 builds on macOS"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-20 14:45:59.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-20 14:45:59.000000000","tz":60},"subject":"tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age","message":"tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age\n\nCoverity complained about \"overflow_before_widen\" because\nthere is a theoretical overflow that can happen even though\nthe target value is wide enough. For useful values of max_days\nthis is irrelevant but Coverity is not wrong, so change the\ncode accordingly.\n\nChange-Id: Ie7308d549182a95b86cd113e4a8cc65ff45ba3d7\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"2969837ad347a227e1d33b1c71390d85f16aa2cd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-11-22 17:39:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/85/1385/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/1385/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/2 \u0026\u0026 git checkout -b change-1385 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/1385/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/1385/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9807719077b5c9886fa0e1e4f47f9669b04d09f9","subject":"GHA: Add macos-26 and remove OpenSSL 1.1 builds on macOS"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-11-22 16:25:47.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-22 17:37:52.000000000","tz":60},"subject":"tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age","message":"tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age\n\nCoverity complained about \"overflow_before_widen\" because\nthere is a theoretical overflow that can happen even though\nthe target value is wide enough. For useful values of max_days\nthis is irrelevant but Coverity is not wrong, so change the\ncode accordingly.\n\nChange-Id: Ie7308d549182a95b86cd113e4a8cc65ff45ba3d7\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1385\nMessage-Id: \u003c20251122162553.12254-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34585.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}