)]}'
{"id":"openvpn~1387","triplet_id":"openvpn~master~I4c3e5aed23d2e4c543066bb8032ad8808dcd27a8","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-22 17:43:21.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-22 17:43:21.000000000","reason":"Change was submitted"},"1000009":{"account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2025-11-22 17:43:21.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-11-22 17:43:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4c3e5aed23d2e4c543066bb8032ad8808dcd27a8","subject":"iservice: fix buffer size in call to FormatMessage","status":"MERGED","created":"2025-11-20 17:54:27.000000000","updated":"2025-11-22 17:43:21.000000000","submitted":"2025-11-22 17:43:21.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1387","meta_rev_id":"0c2e76630db7fced5c55ee55c7b9af4cc4b7cfce","_number":1387,"virtual_id_number":1387,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-20 17:54:28.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-20 17:54:28.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-20 18:04:39.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2025-11-20 18:04:53.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"REVIEWER"},{"updated":"2025-11-22 15:54:37.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"83cd8a9d0d69ac1f14fd262569b4532ce72cf4b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-20 17:54:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cb5b7f2fff07fd30e96c66768e2e35d27707bb9e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-20 17:55:54.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3eeb683a7bd6ed05ff56541f8f0cbddeb344bdd8","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 15:54:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0c2e76630db7fced5c55ee55c7b9af4cc4b7cfce","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 17:43:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b39bed539f218f6165d79224adbc343a63a4514d","revisions":{"4b44cb1fa7b26cf3d0fbcc6a2ad2f4ffe0cd84bc":{"kind":"REWORK","_number":1,"created":"2025-11-20 17:54:27.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/87/1387/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1387/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/1 \u0026\u0026 git checkout -b change-1387 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1387/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9807719077b5c9886fa0e1e4f47f9669b04d09f9","subject":"GHA: Add macos-26 and remove OpenSSL 1.1 builds on macOS"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-20 17:52:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-20 17:52:03.000000000","tz":60},"subject":"iservice: fix buffer size in call to FormatMessage","message":"iservice: fix buffer size in call to FormatMessage\n\nThe buffer size is to be given in # of TCHARs according to the docs. In\nthis case that is the number of WCHARs in the buffer.\n\nReported-by: stephan@srlabs.de\nChange-Id: I4c3e5aed23d2e4c543066bb8032ad8808dcd27a8\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"8a7602f11e349ed4a527c3b614c45a74a3ca4959":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-11-20 17:55:54.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/87/1387/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1387/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/2 \u0026\u0026 git checkout -b change-1387 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1387/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9807719077b5c9886fa0e1e4f47f9669b04d09f9","subject":"GHA: Add macos-26 and remove OpenSSL 1.1 builds on macOS"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-20 17:52:03.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-20 17:54:58.000000000","tz":60},"subject":"iservice: fix buffer size in call to FormatMessage","message":"iservice: fix buffer size in call to FormatMessage\n\nThe buffer size is to be given in # of TCHARs according to the docs. In\nthis case that is the number of WCHARs in the buffer.\n\nWhile here, remove the unused FORMAT_MESSAGE_ARGUMENT_ARRAY flag. Just\nto make things a bit shorter.\n\nReported-by: stephan@srlabs.de\nChange-Id: I4c3e5aed23d2e4c543066bb8032ad8808dcd27a8\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"b39bed539f218f6165d79224adbc343a63a4514d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-22 17:43:21.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/87/1387/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/87/1387/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/3 \u0026\u0026 git checkout -b change-1387 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/87/1387/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/87/1387/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2969837ad347a227e1d33b1c71390d85f16aa2cd","subject":"tls_crypt: Fix Coverity complaint in tls_crypt_v2_check_client_key_age"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-22 15:55:00.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-22 17:39:35.000000000","tz":60},"subject":"iservice: fix buffer size in call to FormatMessage","message":"iservice: fix buffer size in call to FormatMessage\n\nThe buffer size is to be given in # of TCHARs according to the docs. In\nthis case that is the number of WCHARs in the buffer.\n\nWhile here, remove the unused FORMAT_MESSAGE_ARGUMENT_ARRAY flag. Just\nto make things a bit shorter.\n\nReported-by: stephan@srlabs.de\nChange-Id: I4c3e5aed23d2e4c543066bb8032ad8808dcd27a8\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1387\nMessage-Id: \u003c20251122155506.8901-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34583.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}