)]}'
{"id":"openvpn~1388","triplet_id":"openvpn~master~I1e9c7eee06bf5f2e8aed8cd2523684539294ac8b","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-27 11:59:50.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-27 11:59:50.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-11-27 11:34:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"hashtags":[],"change_id":"I1e9c7eee06bf5f2e8aed8cd2523684539294ac8b","subject":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.","status":"MERGED","created":"2025-11-22 19:05:59.000000000","updated":"2025-11-27 11:59:50.000000000","submitted":"2025-11-27 11:59:50.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1388","meta_rev_id":"c2ccbbea7df620c8a5b798cd0c3c0be6695b621a","_number":1388,"virtual_id_number":1388,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-22 19:06:00.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-22 19:06:00.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-27 10:01:44.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"5166ac12d791d67448d474bd286e03fadc436d15","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-22 19:05:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d6c938d13d56aeac13cfcb1f87e10798998779c","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-11-27 10:01:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"04666b9a9077281b5bbe3f88607e2e42323d5d9e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-27 10:24:19.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ea531142639ae32b45c8f0473eb7fa70f85079b7","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-27 10:34:22.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"be34e6049840d2202b43358e2d278916d00ae774","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-11-27 11:34:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c2ccbbea7df620c8a5b798cd0c3c0be6695b621a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-27 11:59:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f18e3141fae709fff47b82d7931024249ba09cc1","revisions":{"5df7118583ad5c81c1c66b25b39ef627c0a3743b":{"kind":"REWORK","_number":1,"created":"2025-11-22 19:05:59.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/1388/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1388/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/1 \u0026\u0026 git checkout -b change-1388 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1388/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20b234b23d483cecfb5dec07ae5f9d8b393847a7","subject":"Add option to check tls-crypt-v2 key timestamps"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-22 19:00:18.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-22 19:05:12.000000000","tz":60},"subject":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.","message":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.\n\nThis seems to be unlikely to ever happen, but this check won\u0027t harm.\n\nWhile at it, fix pre-C99 local-variable indent block.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\n\nChange-Id: I1e9c7eee06bf5f2e8aed8cd2523684539294ac8b\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"c6360a0631e08704886323ea0db5ac024055a42f":{"kind":"REWORK","_number":2,"created":"2025-11-27 10:24:19.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/1388/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1388/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/2 \u0026\u0026 git checkout -b change-1388 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1388/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20b234b23d483cecfb5dec07ae5f9d8b393847a7","subject":"Add option to check tls-crypt-v2 key timestamps"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-22 19:00:18.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-27 10:10:16.000000000","tz":60},"subject":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.","message":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.\n\nThis seems to be unlikely to ever happen, but this check won\u0027t harm\n- as a matter of coding convention, we do not ensure this inside\nextract_x509_field_ssl(), but in the (single) caller.\n\nWhile at it, fix pre-C99 local-variable indent block, and missing {}\nblock in else/#endif construction.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\n\nChange-Id: I1e9c7eee06bf5f2e8aed8cd2523684539294ac8b\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"f18e3141fae709fff47b82d7931024249ba09cc1":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-27 11:59:50.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/1388/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1388/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/3 \u0026\u0026 git checkout -b change-1388 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1388/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1388/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"afdf0028808b9b7809059f3368a396dcbcdf2565","subject":"configure/CMake: Unify Windows handling"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-27 11:35:12.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-27 11:58:18.000000000","tz":60},"subject":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.","message":"extract_x509_field_ssl(): verify that X509_NAME is not NULL.\n\nThis seems to be unlikely to ever happen, but this check won\u0027t harm\n- as a matter of coding convention, we do not ensure this inside\nextract_x509_field_ssl(), but in the (single) caller.\n\nWhile at it, fix pre-C99 local-variable indent block, and missing {}\nblock in else/#endif construction.\n\nReported-By: Joshua Rogers \u003ccontact@joshua.hu\u003e\nFound-by: ZeroPath (https://zeropath.com/)\n\nChange-Id: I1e9c7eee06bf5f2e8aed8cd2523684539294ac8b\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1388\nMessage-Id: \u003c20251127113517.1352-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34748.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}