)]}'
{"id":"openvpn~1389","triplet_id":"openvpn~master~I8b26c65415f5a751f416d80a22cbb7ff14aa27c0","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-23 13:22:16.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-23 13:22:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8b26c65415f5a751f416d80a22cbb7ff14aa27c0","subject":"iservice: make sure buffer size is not zero","status":"MERGED","created":"2025-11-23 06:47:06.000000000","updated":"2025-11-23 13:22:16.000000000","submitted":"2025-11-23 13:22:16.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1389","meta_rev_id":"f5de7a720ad22e5b731bb414b83cc7b0aaea6e2a","_number":1389,"virtual_id_number":1389,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-23 06:47:08.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-23 06:47:08.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-23 11:37:33.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"89b1cf68f93493253331fd845f3e095f4a87e566","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 06:47:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5741ceff032c2bc02edb7c763de0310f497f8240","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-23 11:37:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f5de7a720ad22e5b731bb414b83cc7b0aaea6e2a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-23 13:22:16.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c20a960a338a2e6e7436260cdae4d6eef298cfb0","revisions":{"93a7f6e1d99a5d07292a876fe78e0a959ad17652":{"kind":"REWORK","_number":1,"created":"2025-11-23 06:47:06.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/89/1389/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1389/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/1 \u0026\u0026 git checkout -b change-1389 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1389/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"779ab39d88c8ac83c67b69741d80b79a4587ad25","subject":"multi-socket: remove duplicated/dead code"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 05:55:08.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:00:10.000000000","tz":60},"subject":"iservice: make sure buffer size is not zero","message":"iservice: make sure buffer size is not zero\n\nGetItfDnsDomains expects a non-zero size buffer to return the domains\nin. Check for the size as well, not just for a valid pointer.\n\nChange-Id: I8b26c65415f5a751f416d80a22cbb7ff14aa27c0\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"c20a960a338a2e6e7436260cdae4d6eef298cfb0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-11-23 13:22:16.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/89/1389/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/89/1389/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/2 \u0026\u0026 git checkout -b change-1389 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/89/1389/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/89/1389/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"779ab39d88c8ac83c67b69741d80b79a4587ad25","subject":"multi-socket: remove duplicated/dead code"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 11:37:42.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-23 13:18:03.000000000","tz":60},"subject":"iservice: make sure buffer size is not zero","message":"iservice: make sure buffer size is not zero\n\nGetItfDnsDomains expects a non-zero size buffer to return the domains\nin. Check for the size as well, not just for a valid pointer.\n\nChange-Id: I8b26c65415f5a751f416d80a22cbb7ff14aa27c0\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1389\nMessage-Id: \u003c20251123113747.17739-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg34606.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}