)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"6680cebe6966aff997d3f87e92a27d533b17966e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcfe9be5_c5f1e75d","updated":"2025-11-23 11:48:28.000000000","message":"I might be misreading this, but I think there is still an char/wchar mixup here","commit_id":"cf0bb5f7b4b97741f5f3e2e68ef9e6ebae90c39f"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"6680cebe6966aff997d3f87e92a27d533b17966e","unresolved":true,"context_lines":[{"line_number":2204,"context_line":""},{"line_number":2205,"context_line":"                /* Add space for the leading dot */"},{"line_number":2206,"context_line":"                domain_len +\u003d 1;"},{"line_number":2207,"context_line":"                domain_size +\u003d 1;"},{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":"                /* Space for the terminating zeros */"},{"line_number":2210,"context_line":"                size_t extra_size \u003d 2 * one_glyph;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d13a1328_0f71fd2d","line":2207,"updated":"2025-11-23 11:48:28.000000000","message":"shouldn\u0027t that be `+\u003d one_glyph` here?  A wide-character dot will still take 2 bytes?\n\nMaybe just move the `size_t domain_size \u003d domain_len * one_glyph` down here so it will get the +1 right away?  (Also it feels a bit more logical to do this after the ListContainsDomain() block, where it is used)","commit_id":"cf0bb5f7b4b97741f5f3e2e68ef9e6ebae90c39f"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"3a3036ba441a2dfd33a8106d9f25baf42bc6b8d2","unresolved":false,"context_lines":[{"line_number":2204,"context_line":""},{"line_number":2205,"context_line":"                /* Add space for the leading dot */"},{"line_number":2206,"context_line":"                domain_len +\u003d 1;"},{"line_number":2207,"context_line":"                domain_size +\u003d 1;"},{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":"                /* Space for the terminating zeros */"},{"line_number":2210,"context_line":"                size_t extra_size \u003d 2 * one_glyph;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4e90d085_1e83014a","line":2207,"in_reply_to":"d13a1328_0f71fd2d","updated":"2025-11-23 19:47:51.000000000","message":"Good catch! Moved it up there in prep for a following patch, adding one_glyph is the way to go.","commit_id":"cf0bb5f7b4b97741f5f3e2e68ef9e6ebae90c39f"}]}