)]}'
{"id":"openvpn~1390","triplet_id":"openvpn~master~I16f9426e57f4802ba038ab51f5b70161464b9428","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-11-26 11:01:27.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-11-26 10:34:12.000000000","reason":"removed on reply"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-11-26 11:01:27.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I16f9426e57f4802ba038ab51f5b70161464b9428","subject":"iservice: fix calculation of converted domains size","status":"MERGED","created":"2025-11-23 06:47:06.000000000","updated":"2025-11-26 11:01:27.000000000","submitted":"2025-11-26 11:01:27.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1390","meta_rev_id":"c258464969e1e9c504e6b4b836a18d76542ec417","_number":1390,"virtual_id_number":1390,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-11-23 06:47:08.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-11-23 06:47:08.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-11-23 11:48:28.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"a6597437ff81a700f0fc279e2e02f4087941b85a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 06:47:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6680cebe6966aff997d3f87e92a27d533b17966e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-23 11:48:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3a3036ba441a2dfd33a8106d9f25baf42bc6b8d2","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 19:47:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c3bf27b55f1a36e1879749c8dcb320df1d4d0ae4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-11-23 19:47:56.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0951f194e77dfb8ce66f386509b86424f52b7853","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-26 10:34:12.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c258464969e1e9c504e6b4b836a18d76542ec417","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-11-26 11:01:27.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ac6c9d65701ed6d41691497846a47cb4e72b2878","revisions":{"cf0bb5f7b4b97741f5f3e2e68ef9e6ebae90c39f":{"kind":"REWORK","_number":1,"created":"2025-11-23 06:47:06.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/90/1390/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1390/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/1 \u0026\u0026 git checkout -b change-1390 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1390/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"93a7f6e1d99a5d07292a876fe78e0a959ad17652","subject":"iservice: make sure buffer size is not zero"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:08:01.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:08:01.000000000","tz":60},"subject":"iservice: fix calculation of converted domains size","message":"iservice: fix calculation of converted domains size\n\nTo keep track of how much of the buffer is already used, the difference\nof the current position and the start of the buffer needs to be\nmultiplied with the size of a character / glyph to bet the byte count,\nwith which calculations are done further down below.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I16f9426e57f4802ba038ab51f5b70161464b9428\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"94db1fae5c2d033b9475ba57ce88d3ff30a1d641":{"kind":"REWORK","_number":2,"created":"2025-11-23 19:47:56.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/90/1390/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1390/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/2 \u0026\u0026 git checkout -b change-1390 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1390/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2e2ac94e9cf3d0bdb28339594c8236fa98784967","subject":"iservice: check for NULL pointer"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 06:08:01.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-23 19:47:28.000000000","tz":60},"subject":"iservice: fix calculation of converted domains size","message":"iservice: fix calculation of converted domains size\n\nTo keep track of how much of the buffer is already used, the difference\nof the current position and the start of the buffer needs to be\nmultiplied with the size of a character / glyph to bet the byte count,\nwith which calculations are done further down below.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I16f9426e57f4802ba038ab51f5b70161464b9428\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"ac6c9d65701ed6d41691497846a47cb4e72b2878":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-11-26 11:01:27.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/90/1390/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/1390/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/3 \u0026\u0026 git checkout -b change-1390 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/1390/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/1390/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6244e466217a367dd4d858f5e930e3aab415fc42","subject":"multi-socket: do not return tuntap flags on server-side"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-11-26 10:34:21.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-11-26 10:57:56.000000000","tz":60},"subject":"iservice: fix calculation of converted domains size","message":"iservice: fix calculation of converted domains size\n\nTo keep track of how much of the buffer is already used, the difference\nof the current position and the start of the buffer needs to be\nmultiplied with the size of a character / glyph to bet the byte count,\nwith which calculations are done further down below.\n\nReported-by: Marc Heuse \u003cmarc@srlabs.de\u003e\nReported-by: stephan@srlabs.de\nChange-Id: I16f9426e57f4802ba038ab51f5b70161464b9428\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1390\nMessage-Id: \u003c20251126103427.4085-1-gert@greenie.muc.de\u003e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}